[patch] threads support for XviD
Hi, The attached patch adds threads support for XviD. Guillaume -- Reinventing the wheel certainly is annoying, but as long as all other wheels are square... Reimar Döffinger
On Sun, Feb 26, 2006 at 11:39:40PM +0100, Guillaume POIRIER wrote:
--- DOCS/man/en/mplayer.1 24 Feb 2006 20:28:16 -0000 1.1234 +++ DOCS/man/en/mplayer.1 26 Feb 2006 22:38:09 -0000 @@ -8550,6 +8549,16 @@ +The following option is only available in CVS version of XviD.
Either "in CVS versions" or "in the CVS version".
+Create n threads to run the motion estimation (default: 0). +The max number of threads that can be used is the picture height
maximum Diego
Hi, On 2/26/06, Diego Biurrun <diego@biurrun.de> wrote:
On Sun, Feb 26, 2006 at 11:39:40PM +0100, Guillaume POIRIER wrote:
--- DOCS/man/en/mplayer.1 24 Feb 2006 20:28:16 -0000 1.1234 +++ DOCS/man/en/mplayer.1 26 Feb 2006 22:38:09 -0000 @@ -8550,6 +8549,16 @@ +The following option is only available in CVS version of XviD.
Either "in CVS versions" or "in the CVS version".
+Create n threads to run the motion estimation (default: 0). +The max number of threads that can be used is the picture height
maximum
Okay, thanks! I'll commit the updated version sometime in the future, and drink the cola in the unlikely case of if it breaks smth. Guillaume -- Reinventing the wheel certainly is annoying, but as long as all other wheels are square... Reimar Döffinger
2006/2/28, Guillaume POIRIER <poirierg@gmail.com>:
Hi,
On 2/26/06, Diego Biurrun <diego@biurrun.de> wrote:
On Sun, Feb 26, 2006 at 11:39:40PM +0100, Guillaume POIRIER wrote:
--- DOCS/man/en/mplayer.1 24 Feb 2006 20:28:16 -0000 1.1234 +++ DOCS/man/en/mplayer.1 26 Feb 2006 22:38:09 -0000 @@ -8550,6 +8549,16 @@ +The following option is only available in CVS version of XviD.
Either "in CVS versions" or "in the CVS version".
+Create n threads to run the motion estimation (default: 0). +The max number of threads that can be used is the picture height
maximum
Okay, thanks!
I'll commit the updated version sometime in the future, and drink the cola in the unlikely case of if it breaks smth.
I can't check at the moment, but i see that the "create->num_threads = xvidenc_num_threads;" is not shielded by any #if / #ifdef. In case it is not structure member since the beginning of api4 (xvid 1.0) it would surely break all previous xvid 1.x releases.
Hi, Ivan Kalvachev wrote:
2006/2/28, Guillaume POIRIER <poirierg@gmail.com>:
Hi,
On 2/26/06, Diego Biurrun <diego@biurrun.de> wrote:
On Sun, Feb 26, 2006 at 11:39:40PM +0100, Guillaume POIRIER wrote:
--- DOCS/man/en/mplayer.1 24 Feb 2006 20:28:16 -0000 1.1234 +++ DOCS/man/en/mplayer.1 26 Feb 2006 22:38:09 -0000 @@ -8550,6 +8549,16 @@ +The following option is only available in CVS version of XviD.
Either "in CVS versions" or "in the CVS version".
+Create n threads to run the motion estimation (default: 0). +The max number of threads that can be used is the picture height
maximum
Okay, thanks!
I'll commit the updated version sometime in the future, and drink the cola in the unlikely case of if it breaks smth.
I can't check at the moment, but i see that the "create->num_threads = xvidenc_num_threads;" is not shielded by any #if / #ifdef. In case it is not structure member since the beginning of api4 (xvid 1.0) it would surely break all previous xvid 1.x releases.
Nope, it's all right, it's been present at least present since Thu 13 Jun 2002: http://www.xvid.org/cvs/chora/co.php/xvidcore/src/xvid.h?login=2&r=1.10 Good thinking though :) Guillaume
2006/2/28, Guillaume Poirier <docmaintainerwannabe@laposte.net>:
Hi,
Ivan Kalvachev wrote:
2006/2/28, Guillaume POIRIER <poirierg@gmail.com>:
Hi,
On 2/26/06, Diego Biurrun <diego@biurrun.de> wrote:
On Sun, Feb 26, 2006 at 11:39:40PM +0100, Guillaume POIRIER wrote:
--- DOCS/man/en/mplayer.1 24 Feb 2006 20:28:16 -0000 1.1234 +++ DOCS/man/en/mplayer.1 26 Feb 2006 22:38:09 -0000 @@ -8550,6 +8549,16 @@ +The following option is only available in CVS version of XviD.
Either "in CVS versions" or "in the CVS version".
+Create n threads to run the motion estimation (default: 0). +The max number of threads that can be used is the picture height
maximum
Okay, thanks!
I'll commit the updated version sometime in the future, and drink the cola in the unlikely case of if it breaks smth.
I can't check at the moment, but i see that the "create->num_threads = xvidenc_num_threads;" is not shielded by any #if / #ifdef. In case it is not structure member since the beginning of api4 (xvid 1.0) it would surely break all previous xvid 1.x releases.
Nope, it's all right, it's been present at least present since Thu 13 Jun 2002: http://www.xvid.org/cvs/chora/co.php/xvidcore/src/xvid.h?login=2&r=1.10
Then commit. BTW would thread=1 start encoding in single separate thread? This could boost speed on SMP machines without quality loss.
REMOVE ME FROM THIS BS LIST, I have clicked the unsubscribe link 10 times NOW, THAT'S ENOUGH Pete KT Satan Cash http://www.satancash.com Office: (248)432-2692 Cell: (248)722-1237 ICQ: 285-458-749 -----Original Message----- From: mplayer-dev-eng-bounces@mplayerhq.hu [mailto:mplayer-dev-eng-bounces@mplayerhq.hu] On Behalf Of Ivan Kalvachev Sent: Tuesday, February 28, 2006 7:54 AM To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] [patch] threads support for XviD 2006/2/28, Guillaume Poirier <docmaintainerwannabe@laposte.net>:
Hi,
Ivan Kalvachev wrote:
2006/2/28, Guillaume POIRIER <poirierg@gmail.com>:
Hi,
On 2/26/06, Diego Biurrun <diego@biurrun.de> wrote:
On Sun, Feb 26, 2006 at 11:39:40PM +0100, Guillaume POIRIER wrote:
--- DOCS/man/en/mplayer.1 24 Feb 2006 20:28:16 -0000 1.1234 +++ DOCS/man/en/mplayer.1 26 Feb 2006 22:38:09 -0000 @@ -8550,6 +8549,16 @@ +The following option is only available in CVS version of XviD.
Either "in CVS versions" or "in the CVS version".
+Create n threads to run the motion estimation (default: 0). +The max number of threads that can be used is the picture height
maximum
Okay, thanks!
I'll commit the updated version sometime in the future, and drink the cola in the unlikely case of if it breaks smth.
I can't check at the moment, but i see that the "create->num_threads = xvidenc_num_threads;" is not shielded by any #if / #ifdef. In case it is not structure member since the beginning of api4 (xvid 1.0) it would surely break all previous xvid 1.x releases.
Nope, it's all right, it's been present at least present since Thu 13 Jun 2002: http://www.xvid.org/cvs/chora/co.php/xvidcore/src/xvid.h?login=2&r=1.10
Then commit. BTW would thread=1 start encoding in single separate thread? This could boost speed on SMP machines without quality loss. _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
On Tue, Feb 28, 2006 at 07:58:58AM -0500, Satan Cash wrote:
REMOVE ME FROM THIS BS LIST, I have clicked the unsubscribe link 10 times NOW, THAT'S ENOUGH
The web interface does not work. Read the mail headers for the unsubscribe address.
Pete KT
Satan Cash
Office: (248)432-2692
Cell: (248)722-1237
ICQ: 285-458-749
Thanks for all the spam. Rich
On Tue, Feb 28, 2006 at 02:53:58PM +0200, Ivan Kalvachev wrote:
2006/2/28, Guillaume Poirier <docmaintainerwannabe@laposte.net>:
Hi,
Ivan Kalvachev wrote:
2006/2/28, Guillaume POIRIER <poirierg@gmail.com>:
Hi,
On 2/26/06, Diego Biurrun <diego@biurrun.de> wrote:
On Sun, Feb 26, 2006 at 11:39:40PM +0100, Guillaume POIRIER wrote:
--- DOCS/man/en/mplayer.1 24 Feb 2006 20:28:16 -0000 1.1234 +++ DOCS/man/en/mplayer.1 26 Feb 2006 22:38:09 -0000 @@ -8550,6 +8549,16 @@ +The following option is only available in CVS version of XviD.
Either "in CVS versions" or "in the CVS version".
+Create n threads to run the motion estimation (default: 0). +The max number of threads that can be used is the picture height
maximum
Okay, thanks!
I'll commit the updated version sometime in the future, and drink the cola in the unlikely case of if it breaks smth.
I can't check at the moment, but i see that the "create->num_threads = xvidenc_num_threads;" is not shielded by any #if / #ifdef. In case it is not structure member since the beginning of api4 (xvid 1.0) it would surely break all previous xvid 1.x releases.
Nope, it's all right, it's been present at least present since Thu 13 Jun 2002: http://www.xvid.org/cvs/chora/co.php/xvidcore/src/xvid.h?login=2&r=1.10
Then commit.
BTW would thread=1 start encoding in single separate thread? This could boost speed on SMP machines without quality loss.
Huh? How would this work? The caller would just sit idle waiting for that thread to finish... Rich
Hi, On 2/28/06, Rich Felker <dalias@aerifal.cx> wrote:
On Tue, Feb 28, 2006 at 02:53:58PM +0200, Ivan Kalvachev wrote:
Then commit.
Ok.
BTW would thread=1 start encoding in single separate thread? This could boost speed on SMP machines without quality loss.
Huh? How would this work? The caller would just sit idle waiting for that thread to finish...
The main thread takes care everything but the motion estimation, all additionnal threads take care of motion estimation only. So yes, thread=1 is probably as lossless as you can get with this code. However, Syskin says that no matter the number of threads (>1) the resulting files are identical... so it looks like it just doesn't matter. Guillaume -- Reinventing the wheel certainly is annoying, but as long as all other wheels are square... Reimar Döffinger
Hi, On 2/26/06, Guillaume POIRIER <poirierg@gmail.com> wrote:
Hi, The attached patch adds threads support for XviD.
Applied a modified version featuring the fixes suggested by Diego. Guillaume -- Reinventing the wheel certainly is annoying, but as long as all other wheels are square... Reimar Döffinger
On Wed, Mar 01, 2006 at 10:19:52AM +0100, Guillaume POIRIER wrote:
Hi,
On 2/26/06, Guillaume POIRIER <poirierg@gmail.com> wrote:
Hi, The attached patch adds threads support for XviD.
Applied a modified version featuring the fixes suggested by Diego.
Guillaume
-- Reinventing the wheel certainly is annoying, but as long as all other wheels are square...
Totally off-topic, but I love this .sig Rich
On Wednesday, 01 March 2006 at 21:39, Rich Felker wrote:
On Wed, Mar 01, 2006 at 10:19:52AM +0100, Guillaume POIRIER wrote:
Hi,
On 2/26/06, Guillaume POIRIER <poirierg@gmail.com> wrote:
Hi, The attached patch adds threads support for XviD.
Applied a modified version featuring the fixes suggested by Diego.
Guillaume
-- Reinventing the wheel certainly is annoying, but as long as all other wheels are square...
Totally off-topic, but I love this .sig
Don't we all? I also love the one quoting a certain GCC developer. I think Guillaume has used it from time to time. I think we need a new "best of MPlayer" page, in English this time. ^_^ R. -- MPlayer developer and RPMs maintainer: http://rpm.greysector.net/mplayer/ There should be a science of discontent. People need hard times and oppression to develop psychic muscles. -- from "Collected Sayings of Muad'Dib" by the Princess Irulan
On Wed, Mar 01, 2006 at 09:52:22PM +0100, Dominik 'Rathann' Mierzejewski wrote:
On Wednesday, 01 March 2006 at 21:39, Rich Felker wrote:
On Wed, Mar 01, 2006 at 10:19:52AM +0100, Guillaume POIRIER wrote:
Hi,
On 2/26/06, Guillaume POIRIER <poirierg@gmail.com> wrote:
Hi, The attached patch adds threads support for XviD.
Applied a modified version featuring the fixes suggested by Diego.
Guillaume
-- Reinventing the wheel certainly is annoying, but as long as all other wheels are square...
Totally off-topic, but I love this .sig
Don't we all? I also love the one quoting a certain GCC developer. I think Guillaume has used it from time to time.
I think we need a new "best of MPlayer" page, in English this time.
Yes, definitely! Could we restore the hungarian one too while we're at it, and have them both together? Rich
On Wed, Mar 01, 2006 at 04:34:22PM -0500, Rich Felker wrote:
On Wed, Mar 01, 2006 at 09:52:22PM +0100, Dominik 'Rathann' Mierzejewski wrote:
On Wednesday, 01 March 2006 at 21:39, Rich Felker wrote:
On Wed, Mar 01, 2006 at 10:19:52AM +0100, Guillaume POIRIER wrote:
Guillaume
-- Reinventing the wheel certainly is annoying, but as long as all other wheels are square...
Totally off-topic, but I love this .sig
Don't we all? I also love the one quoting a certain GCC developer. I think Guillaume has used it from time to time.
I think we need a new "best of MPlayer" page, in English this time.
Yes, definitely! Could we restore the hungarian one too while we're at it, and have them both together?
If you fix the HTML I'm not against it. Diego
participants (7)
-
Diego Biurrun -
Dominik 'Rathann' Mierzejewski -
Guillaume POIRIER -
Guillaume Poirier -
Ivan Kalvachev -
Rich Felker -
Satan Cash