The attached patch enables audio stream switching in the mpg demuxer using the #-key. It is not complete yet, because manpage is not updated, but I wanted to get some opinions before doing the really hard work ;-) Michael
On Thu, Feb 24, 2005 at 07:01:14PM +0100, Michael Behrisch wrote:
The attached patch enables audio stream switching in the mpg demuxer using the #-key. It is not complete yet, because manpage is not updated, but I wanted to get some opinions before doing the really hard work ;-)
It seems like my patches need more advertising before even getting noticed. OK here we go. This patch lets you instantly switch from german to english on your favorite dvd to hear the original version of that four letter word. A single keypress instead of stopping, looking for the right aid and restarting and searching over and over again. (It works only if both audio streams have the same format, but it works.) And it can also walk your dog. Michael
On Sun, Feb 27, 2005 at 08:03:16PM +0100, Michael Behrisch wrote:
On Thu, Feb 24, 2005 at 07:01:14PM +0100, Michael Behrisch wrote:
The attached patch enables audio stream switching in the mpg demuxer using the #-key. It is not complete yet, because manpage is not updated, but I wanted to get some opinions before doing the really hard work ;-)
It seems like my patches need more advertising before even getting noticed.
No, it needs significant fixes before it has any chance of getting committed, though..
OK here we go. This patch lets you instantly switch from german to english on your favorite dvd to hear the original version of that four letter word.
A single keypress instead of stopping, looking for the right aid and restarting and searching over and over again. (It works only if both audio streams have the same format, but it works.) And it can also walk your dog.
A single keypress will make it horribly crash unless the new audio track has exactly the same codec and format as the old one. This is very bad. Consider DVDs that have some tracks as 2.0 AC3 and others as 5.1 AC3, or a mix of AC3, PCM, and DTS. Unless you work out all the mess to close down and reinitialize the audio layer for the newly selected audio track, a patch like this (which only works on a very limited number of files and crashes on all the rest) is not acceptable. I know it's very hard to do this right (that's why no one has done it yet..) but that's the way it is. Sorry.. Rich
On Sun, Feb 27, 2005 at 02:27:50PM -0500, D Richard Felker III wrote:
On Sun, Feb 27, 2005 at 08:03:16PM +0100, Michael Behrisch wrote:
On Thu, Feb 24, 2005 at 07:01:14PM +0100, Michael Behrisch wrote:
The attached patch enables audio stream switching in the mpg demuxer using the #-key. It is not complete yet, because manpage is not updated, but I wanted to get some opinions before doing the really hard work ;-)
OK here we go. This patch lets you instantly switch from german to english on your favorite dvd to hear the original version of that four letter word.
A single keypress instead of stopping, looking for the right aid and restarting and searching over and over again. (It works only if both audio streams have the same format, but it works.) And it can also walk your dog.
A single keypress will make it horribly crash unless the new audio track has exactly the same codec and format as the old one. This is very bad. Consider DVDs that have some tracks as 2.0 AC3 and others as 5.1 AC3, or a mix of AC3, PCM, and DTS. Unless you work out all the mess to close down and reinitialize the audio layer for the newly selected audio track, a patch like this (which only works on a very limited number of files and crashes on all the rest) is not acceptable. I know it's very hard to do this right (that's why no one has done it yet..) but that's the way it is. Sorry..
Well, the patch already knows about the difference between AC3, PCM and DTS and switches only between streams of the same format. Switching between 2.0 AC3 and 5.1 AC3 did not make problems here but please send me a sample where it does. Michael
On Mon, Feb 28, 2005 at 10:38:14AM +0100, Michael Behrisch wrote:
On Sun, Feb 27, 2005 at 02:27:50PM -0500, D Richard Felker III wrote:
On Sun, Feb 27, 2005 at 08:03:16PM +0100, Michael Behrisch wrote:
On Thu, Feb 24, 2005 at 07:01:14PM +0100, Michael Behrisch wrote:
The attached patch enables audio stream switching in the mpg demuxer using the #-key. It is not complete yet, because manpage is not updated, but I wanted to get some opinions before doing the really hard work ;-)
OK here we go. This patch lets you instantly switch from german to english on your favorite dvd to hear the original version of that four letter word.
A single keypress instead of stopping, looking for the right aid and restarting and searching over and over again. (It works only if both audio streams have the same format, but it works.) And it can also walk your dog.
A single keypress will make it horribly crash unless the new audio track has exactly the same codec and format as the old one. This is very bad. Consider DVDs that have some tracks as 2.0 AC3 and others as 5.1 AC3, or a mix of AC3, PCM, and DTS. Unless you work out all the mess to close down and reinitialize the audio layer for the newly selected audio track, a patch like this (which only works on a very limited number of files and crashes on all the rest) is not acceptable. I know it's very hard to do this right (that's why no one has done it yet..) but that's the way it is. Sorry..
Well, the patch already knows about the difference between AC3, PCM and DTS and switches only between streams of the same format. Switching between 2.0 AC3 and 5.1 AC3 did not make problems here but please send me a sample where it does.
do you have a 5.1 setup? if not, it will just decode both as 2.0 so no problem should arise...but i wonder what happens if you have 5.1 output available.. rich
On Mon, Feb 28, 2005 at 10:37:53AM -0500, D Richard Felker III wrote:
A single keypress will make it horribly crash unless the new audio track has exactly the same codec and format as the old one. This is very bad. Consider DVDs that have some tracks as 2.0 AC3 and others as 5.1 AC3, or a mix of AC3, PCM, and DTS. Unless you work out all the mess to close down and reinitialize the audio layer for the newly selected audio track, a patch like this (which only works on a very limited number of files and crashes on all the rest) is not acceptable. I know it's very hard to do this right (that's why no one has done it yet..) but that's the way it is. Sorry..
Well, the patch already knows about the difference between AC3, PCM and DTS and switches only between streams of the same format. Switching between 2.0 AC3 and 5.1 AC3 did not make problems here but please send me a sample where it does.
do you have a 5.1 setup? if not, it will just decode both as 2.0 so no problem should arise...but i wonder what happens if you have 5.1 output available..
Well, if it checks the format to ensure no crashing, I say it's a very good thing to have. What's the down side when compared to no switching at all? --Joey -- "I eat donuts for dying children." --Andrew
On Mon, Feb 28, 2005 at 12:31:13PM -0600, Joey Parrish wrote:
On Mon, Feb 28, 2005 at 10:37:53AM -0500, D Richard Felker III wrote:
A single keypress will make it horribly crash unless the new audio track has exactly the same codec and format as the old one. This is very bad. Consider DVDs that have some tracks as 2.0 AC3 and others as 5.1 AC3, or a mix of AC3, PCM, and DTS. Unless you work out all the mess to close down and reinitialize the audio layer for the newly selected audio track, a patch like this (which only works on a very limited number of files and crashes on all the rest) is not acceptable. I know it's very hard to do this right (that's why no one has done it yet..) but that's the way it is. Sorry..
Well, the patch already knows about the difference between AC3, PCM and DTS and switches only between streams of the same format. Switching between 2.0 AC3 and 5.1 AC3 did not make problems here but please send me a sample where it does.
do you have a 5.1 setup? if not, it will just decode both as 2.0 so no problem should arise...but i wonder what happens if you have 5.1 output available..
Well, if it checks the format to ensure no crashing, I say it's a very good thing to have. What's the down side when compared to no switching at all?
If it's safe, I agree, it's ok to add. But I'm still worried about cases that might seem safe but not be, e.g. switching between apparently-compatible vorbis streams when they actually have different dictionaries or whatever crap goes in the global header. Of course for this patch vorbis is irrelevant since it's MPEG-only, so we're probably safe. But if we want to do this kind of switching in more generality, it needs to do full reinit of the audio system, IMO. Rich
On Mon, Feb 28, 2005 at 02:12:56PM -0500, D Richard Felker III wrote:
On Mon, Feb 28, 2005 at 12:31:13PM -0600, Joey Parrish wrote:
On Mon, Feb 28, 2005 at 10:37:53AM -0500, D Richard Felker III wrote:
Well, the patch already knows about the difference between AC3, PCM and DTS and switches only between streams of the same format. Switching between 2.0 AC3 and 5.1 AC3 did not make problems here but please send me a sample where it does.
do you have a 5.1 setup? if not, it will just decode both as 2.0 so no problem should arise...but i wonder what happens if you have 5.1 output available..
Well, if it checks the format to ensure no crashing, I say it's a very good thing to have. What's the down side when compared to no switching at all?
If it's safe, I agree, it's ok to add.
I double-checked, AC3 and DTS work perfectly although I must admit that I have only one DVD with more than one DTS stream. Michael
On Wed, Mar 02, 2005 at 01:03:41PM +0100, Michael Behrisch wrote:
On Mon, Feb 28, 2005 at 02:12:56PM -0500, D Richard Felker III wrote:
On Mon, Feb 28, 2005 at 12:31:13PM -0600, Joey Parrish wrote:
On Mon, Feb 28, 2005 at 10:37:53AM -0500, D Richard Felker III wrote:
Well, the patch already knows about the difference between AC3, PCM and DTS and switches only between streams of the same format. Switching between 2.0 AC3 and 5.1 AC3 did not make problems here but please send me a sample where it does.
do you have a 5.1 setup? if not, it will just decode both as 2.0 so no problem should arise...but i wonder what happens if you have 5.1 output available..
Well, if it checks the format to ensure no crashing, I say it's a very good thing to have. What's the down side when compared to no switching at all?
If it's safe, I agree, it's ok to add.
I double-checked, AC3 and DTS work perfectly although I must admit that I have only one DVD with more than one DTS stream.
Did anyone have a real look at it? Someone who dares to commit? Michael
Well, if it checks the format to ensure no crashing, I say it's a very good thing to have. What's the down side when compared to no switching at all?
If it's safe, I agree, it's ok to add.
I double-checked, AC3 and DTS work perfectly although I must admit that I have only one DVD with more than one DTS stream.
Did anyone have a real look at it? Someone who dares to commit?
Two and a half weeks gone without an answer. Anyone out there looking at this? I remember mails saying they would kill for this feature. Where are those fans? Support me ;-) Old patch did not apply anymore, thus new one attached. Michael
Hi, Michael Behrisch a écrit :
Well, if it checks the format to ensure no crashing, I say it's a very good thing to have. What's the down side when compared to no switching at all?
If it's safe, I agree, it's ok to add.
I double-checked, AC3 and DTS work perfectly although I must admit that I have only one DVD with more than one DTS stream.
Did anyone have a real look at it? Someone who dares to commit?
Two and a half weeks gone without an answer. Anyone out there looking at this? I remember mails saying they would kill for this feature. Where are those fans? Support me ;-)
Old patch did not apply anymore, thus new one attached.
Your patch is indeed interesting, and by a quick glance at it, fairly small. My opinion about it, if it works, is that it could be integrated if marked as "BETA code" on the man page, just like the "-fixed-vo" switch, which is fairly useful too. Does you patch still has issues with switching between different codecs such as DTS, AC3, MP3, Ogg? Regards, Guillaume
On Thu, Mar 24, 2005 at 05:00:04PM +0100, Guillaume POIRIER wrote:
Hi,
Michael Behrisch a écrit :
Well, if it checks the format to ensure no crashing, I say it's a very good thing to have. What's the down side when compared to no switching at all?
If it's safe, I agree, it's ok to add.
I double-checked, AC3 and DTS work perfectly although I must admit that I have only one DVD with more than one DTS stream.
Did anyone have a real look at it? Someone who dares to commit?
Two and a half weeks gone without an answer. Anyone out there looking at this? I remember mails saying they would kill for this feature. Where are those fans? Support me ;-)
Old patch did not apply anymore, thus new one attached.
Your patch is indeed interesting, and by a quick glance at it, fairly small. My opinion about it, if it works, is that it could be integrated if marked as "BETA code" on the man page, just like the "-fixed-vo" switch, which is fairly useful too.
Does you patch still has issues with switching between different codecs such as DTS, AC3, MP3, Ogg?
It skips over all streams with different codec, so it might actually be safe... Rich
On Thu, Mar 24, 2005 at 12:55:18PM -0500, D Richard Felker III wrote:
On Thu, Mar 24, 2005 at 05:00:04PM +0100, Guillaume POIRIER wrote:
Hi,
Michael Behrisch a écrit :
>Well, if it checks the format to ensure no crashing, I say it's a very >good thing to have. What's the down side when compared to no switching >at all?
If it's safe, I agree, it's ok to add.
I double-checked, AC3 and DTS work perfectly although I must admit that I have only one DVD with more than one DTS stream.
Did anyone have a real look at it? Someone who dares to commit?
Two and a half weeks gone without an answer. Anyone out there looking at this? I remember mails saying they would kill for this feature. Where are those fans? Support me ;-)
Old patch did not apply anymore, thus new one attached.
Your patch is indeed interesting, and by a quick glance at it, fairly small. My opinion about it, if it works, is that it could be integrated if marked as "BETA code" on the man page, just like the "-fixed-vo" switch, which is fairly useful too.
Does you patch still has issues with switching between different codecs such as DTS, AC3, MP3, Ogg?
It skips over all streams with different codec, so it might actually be safe...
So one might actually commit ;-) Michael
Hi, On Tue, 29 Mar 2005 14:09:37 +0200, Michael Behrisch <behrisch@informatik.hu-berlin.de> wrote:
On Thu, Mar 24, 2005 at 12:55:18PM -0500, D Richard Felker III wrote:
It skips over all streams with different codec, so it might actually be safe...
So one might actually commit ;-)
I guess I should really consider to give it a try, as indeed, I find this feature really interesting. All the more important to add to MPlayer that xine (and vlc I think) allows that. Is there any reason you can't make your patch do the same with Matroska or OGM files? Regards, Guillaume
On Tue, Mar 29, 2005 at 03:33:51PM +0200, Guillaume Poirier wrote:
Hi,
On Tue, 29 Mar 2005 14:09:37 +0200, Michael Behrisch <behrisch@informatik.hu-berlin.de> wrote:
On Thu, Mar 24, 2005 at 12:55:18PM -0500, D Richard Felker III wrote:
It skips over all streams with different codec, so it might actually be safe...
So one might actually commit ;-)
I guess I should really consider to give it a try, as indeed, I find this feature really interesting. All the more important to add to MPlayer that xine (and vlc I think) allows that. Is there any reason you can't make your patch do the same with Matroska or OGM files?
Yes, that would be really nice, with idiotic groups putting dub audio first in anime files.. Of course I doubt this stream-switching is valid with vorbis, since the vorbis global header might be different for each stream... Rich
On Tue, 29 Mar 2005, D Richard Felker III wrote:
On Tue, Mar 29, 2005 at 03:33:51PM +0200, Guillaume Poirier wrote:
On Thu, Mar 24, 2005 at 12:55:18PM -0500, D Richard Felker III wrote:
It skips over all streams with different codec, so it might actually be safe...
I guess I should really consider to give it a try, as indeed, I find this feature really interesting. All the more important to add to MPlayer that xine (and vlc I think) allows that. Is there any reason you can't make your patch do the same with Matroska or OGM files?
Yes, that would be really nice, with idiotic groups putting dub audio first in anime files.. Of course I doubt this stream-switching is valid with vorbis, since the vorbis global header might be different for each stream...
Not strictly safe, but libvorbis at least creates global headers based entirely on the encoder settings, not the content. So it's quite possible for two audio streams in the same movie to be compatible. --Loren Merritt
On Tue, Mar 29, 2005 at 03:33:51PM +0200, Guillaume Poirier wrote:
Hi,
On Tue, 29 Mar 2005 14:09:37 +0200, Michael Behrisch <behrisch@informatik.hu-berlin.de> wrote:
On Thu, Mar 24, 2005 at 12:55:18PM -0500, D Richard Felker III wrote:
It skips over all streams with different codec, so it might actually be safe...
So one might actually commit ;-)
I guess I should really consider to give it a try, as indeed, I find this feature really interesting. All the more important to add to MPlayer that xine (and vlc I think) allows that. Is there any reason you can't make your patch do the same with Matroska or OGM files?
Actually that was the next thing I planned to do, but Rich's remarks did not encourage me too much. Nevertheless I will try as soon as this one is accepted. Michael
Hi, On Mar 30, 2005 10:47 PM, Michael Behrisch <behrisch@informatik.hu-berlin.de> wrote:
On Tue, Mar 29, 2005 at 03:33:51PM +0200, Guillaume Poirier wrote:
Hi,
On Tue, 29 Mar 2005 14:09:37 +0200, Michael Behrisch <behrisch@informatik.hu-berlin.de> wrote:
On Thu, Mar 24, 2005 at 12:55:18PM -0500, D Richard Felker III wrote:
It skips over all streams with different codec, so it might actually be safe...
So one might actually commit ;-)
I guess I should really consider to give it a try, as indeed, I find this feature really interesting. All the more important to add to MPlayer that xine (and vlc I think) allows that. Is there any reason you can't make your patch do the same with Matroska or OGM files?
Actually that was the next thing I planned to do, but Rich's remarks did not encourage me too much. Nevertheless I will try as soon as this one is accepted.
I finally had the time to test it. I works _really_ well. Rich, do you think it's okay to commit? Regards, Guillaume
On Sat, Apr 02, 2005 at 12:45:35PM +0200, Guillaume Poirier wrote:
Hi,
On Mar 30, 2005 10:47 PM, Michael Behrisch <behrisch@informatik.hu-berlin.de> wrote:
On Tue, Mar 29, 2005 at 03:33:51PM +0200, Guillaume Poirier wrote:
Hi,
On Tue, 29 Mar 2005 14:09:37 +0200, Michael Behrisch <behrisch@informatik.hu-berlin.de> wrote:
On Thu, Mar 24, 2005 at 12:55:18PM -0500, D Richard Felker III wrote:
It skips over all streams with different codec, so it might actually be safe...
So one might actually commit ;-)
I guess I should really consider to give it a try, as indeed, I find this feature really interesting. All the more important to add to MPlayer that xine (and vlc I think) allows that. Is there any reason you can't make your patch do the same with Matroska or OGM files?
Actually that was the next thing I planned to do, but Rich's remarks did not encourage me too much. Nevertheless I will try as soon as this one is accepted.
I finally had the time to test it. I works _really_ well. Rich, do you think it's okay to commit?
It sounds right, so I won't object. Rich
Hi, On Apr 2, 2005 6:27 PM, D Richard Felker III <dalias@aerifal.cx> wrote:
On Sat, Apr 02, 2005 at 12:45:35PM +0200, Guillaume Poirier wrote:
Hi,
On Mar 30, 2005 10:47 PM, Michael Behrisch <behrisch@informatik.hu-berlin.de> wrote:
On Tue, Mar 29, 2005 at 03:33:51PM +0200, Guillaume Poirier wrote:
I guess I should really consider to give it a try, as indeed, I find this feature really interesting. All the more important to add to MPlayer that xine (and vlc I think) allows that. Is there any reason you can't make your patch do the same with Matroska or OGM files?
Actually that was the next thing I planned to do, but Rich's remarks did not encourage me too much. Nevertheless I will try as soon as this one is accepted.
I finally had the time to test it. I works _really_ well. Rich, do you think it's okay to commit?
It sounds right, so I won't object.
Ok, I can commit it then? The problem that I see thought is that I don't trust myself enough to say that I take all the responsibilities whether it breaks something or not... I mean, if it needs further improvement, I'm not sure I'd be able to provide such support. May I rely on you and other devs if there's any problem? In other words, I'm ok to get the cola shipment, but where should I return the bottles? ;-) Regards, Guillaume
Hi, On Apr 3, 2005 4:21 AM, Guillaume Poirier <poirierg@gmail.com> wrote:
Hi,
On Apr 2, 2005 6:27 PM, D Richard Felker III <dalias@aerifal.cx> wrote:
It sounds right, so I won't object.
Ok, I can commit it then? The problem that I see thought is that I don't trust myself enough to say that I take all the responsibilities whether it breaks something or not... I mean, if it needs further improvement, I'm not sure I'd be able to provide such support. May I rely on you and other devs if there's any problem?
In other words, I'm ok to get the cola shipment, but where should I return the bottles? ;-)
Finally committed with Rich's blessing. Regards, Guillaume
Am Sonntag, 3. April 2005 16:11 schrieb Guillaume Poirier:
Finally committed with Rich's blessing.
Thanks, here is the Matroska-patch You asked for Yours, Michael
Hi, On Apr 5, 2005 10:33 PM, Michael Behrisch <list@behrisch.de> wrote:
Am Sonntag, 3. April 2005 16:11 schrieb Guillaume Poirier:
Finally committed with Rich's blessing.
Thanks, here is the Matroska-patch You asked for
I've tested with a Matroska file containing a vorbis 2-channel audio track and a 5.1 AC3 audio track. It doesn't switch between any of those tracks (which AFAIK is normal as it would require a full audio subsystem restart as they are incompatible in some way). I'll try with less exotic files and give it more testing. Regards, Guillaume
Hey, On Tuesday 05 April 2005 22:33, Michael Behrisch wrote:
here is the Matroska-patch You asked for
Please also test for stream parameters (channels, sample rate), not only the codec ID. I know guys that put two Vorbis tracks into the same file, and one of them is only mono or sth like that, and this patch would then cause problems. Thanks. Mosu -- If Darl McBride was in charge, he'd probably make marriage unconstitutional too, since clearly it de-emphasizes the commercial nature of normal human interaction, and probably is a major impediment to the commercial growth of prostitution. - Linus Torvalds
Am Mittwoch, 6. April 2005 08:16 schrieb Moritz Bunkus:
Hey,
On Tuesday 05 April 2005 22:33, Michael Behrisch wrote:
here is the Matroska-patch You asked for
Please also test for stream parameters (channels, sample rate), not only the codec ID. I know guys that put two Vorbis tracks into the same file, and one of them is only mono or sth like that, and this patch would then cause problems. Thanks.
Next try attached. Michael
Hi, On 4/6/05, Michael Behrisch <list@behrisch.de> wrote:
Am Mittwoch, 6. April 2005 08:16 schrieb Moritz Bunkus:
Hey,
On Tuesday 05 April 2005 22:33, Michael Behrisch wrote:
here is the Matroska-patch You asked for
Please also test for stream parameters (channels, sample rate), not only the codec ID. I know guys that put two Vorbis tracks into the same file, and one of them is only mono or sth like that, and this patch would then cause problems. Thanks.
Next try attached.
Tested, works fine when switching between same kind of codecs. Rich, do you think it's okay to commit? Guillaume
Hi, On 4/14/05, Guillaume Poirier <poirierg@gmail.com> wrote:
Hi,
On 4/6/05, Michael Behrisch <list@behrisch.de> wrote:
Am Mittwoch, 6. April 2005 08:16 schrieb Moritz Bunkus:
Hey,
On Tuesday 05 April 2005 22:33, Michael Behrisch wrote:
here is the Matroska-patch You asked for
Please also test for stream parameters (channels, sample rate), not only the codec ID. I know guys that put two Vorbis tracks into the same file, and one of them is only mono or sth like that, and this patch would then cause problems. Thanks.
Next try attached.
Tested, works fine when switching between same kind of codecs.
Rich, do you think it's okay to commit?
Committed with Rich's blessing. Thanks Michael! Guillaume
Hi, On 4/6/05, Michael Behrisch <list@behrisch.de> wrote:
Am Mittwoch, 6. April 2005 08:16 schrieb Moritz Bunkus:
Hey,
On Tuesday 05 April 2005 22:33, Michael Behrisch wrote:
here is the Matroska-patch You asked for
Please also test for stream parameters (channels, sample rate), not only the codec ID. I know guys that put two Vorbis tracks into the same file, and one of them is only mono or sth like that, and this patch would then cause problems. Thanks.
Next try attached.
Michael
ARG! I just found out that switching between 2 Vorbis audio tracks is horribly broken (in the sense that it produces nasty audio artifacts)! Michael, do you have idea how to fix that? Should we simply forbid switching between Vorbis audio tracks? Regards, Guillaume
Am Montag, 18. April 2005 10:58 schrieb Guillaume Poirier:
On 4/6/05, Michael Behrisch <list@behrisch.de> wrote:
On Tuesday 05 April 2005 22:33, Michael Behrisch wrote:
here is the Matroska-patch You asked for
ARG! I just found out that switching between 2 Vorbis audio tracks is horribly broken (in the sense that it produces nasty audio artifacts)! Michael, do you have idea how to fix that? Should we simply forbid switching between Vorbis audio tracks?
It works here. (At least for the 5 or 6 cases I tested.) Maybe You can just upload a non-working sample and we try to figure out what's wrong with it? Michael
Hi, On 4/22/05, Michael Behrisch <list@behrisch.de> wrote:
Am Montag, 18. April 2005 10:58 schrieb Guillaume Poirier:
On 4/6/05, Michael Behrisch <list@behrisch.de> wrote:
On Tuesday 05 April 2005 22:33, Michael Behrisch wrote:
here is the Matroska-patch You asked for
ARG! I just found out that switching between 2 Vorbis audio tracks is horribly broken (in the sense that it produces nasty audio artifacts)! Michael, do you have idea how to fix that? Should we simply forbid switching between Vorbis audio tracks?
It works here. (At least for the 5 or 6 cases I tested.) Maybe You can just upload a non-working sample and we try to figure out what's wrong with it?
I uploaded the smallest sample I could generate on MPlayer's FTP. When I switch back and forth between both tracks, the "original" one is always fine, and the "alternate" one is all funny, like if the audio encoding process had failed. It's in /MPlayer/incoming/Vorbis_Online_audio_stream_switching but in order to leach it, someone will have to move is somewhere where you can download it. Diego? Regards, Guillaume
On Sun, May 08, 2005 at 05:27:03PM +0200, Guillaume POIRIER wrote:
I uploaded the smallest sample I could generate on MPlayer's FTP.
When I switch back and forth between both tracks, the "original" one is always fine, and the "alternate" one is all funny, like if the audio encoding process had failed.
It's in /MPlayer/incoming/Vorbis_Online_audio_stream_switching but in order to leach it, someone will have to move is somewhere where you can download it.
Diego?
http://mplayerhq.hu/~diego/Vorbis_Online_audio_stream_switching/
Hi, On 5/8/05, Diego Biurrun <diego@biurrun.de> wrote:
On Sun, May 08, 2005 at 05:27:03PM +0200, Guillaume POIRIER wrote:
I uploaded the smallest sample I could generate on MPlayer's FTP.
When I switch back and forth between both tracks, the "original" one is always fine, and the "alternate" one is all funny, like if the audio encoding process had failed.
It's in /MPlayer/incoming/Vorbis_Online_audio_stream_switching but in order to leach it, someone will have to move is somewhere where you can download it.
Diego?
http://mplayerhq.hu/~diego/Vorbis_Online_audio_stream_switching/
Thanks. Did you check if you were able to reproduce my problem? Guillaume
Am Sonntag, 8. Mai 2005 17:27 schrieb Guillaume POIRIER:
When I switch back and forth between both tracks, the "original" one is always fine, and the "alternate" one is all funny, like if the audio encoding process had failed.
OK, Rich has warned me that this is going to happen. The vorbis streams have different headers which result in different decoding options needed for the streams. Nevertheless fix is attached, although the matroska people should say whether they consider calling mkv_open_audio for all vorbis streams (in case the initial stream is vorbis) a bad hack. Switching is now only possible if the codebook headers match (which was the case in all my examples because I choose the same encoding options for all audio streams, but not in yours) Michael
Hey, On Wednesday 11 May 2005 07:19, Michael Behrisch wrote:
OK, Rich has warned me that this is going to happen. The vorbis streams have different headers which result in different decoding options needed for the streams. Nevertheless fix is attached, although the matroska people should say whether they consider calling mkv_open_audio for all vorbis streams (in case the initial stream is vorbis) a bad hack.
It memleaks: new_sh_audio is called for each Vorbis track. It also will not work AT ALL at the moment because it sends the first three packets down the audio demuxer chain. If you have multiple Vorbis tracks then the headers of all will be sent downstream. You obviously "only" need the decoding of the codec private element. Unfortunately (or fortunately) this will be gone in a few days anyway because Nico is in the process of fixing demux_ogg, demux_mkv and ad_vorbis to use the extradata and not the first three packets. Therefore demux_mkv will probably not need to decode its codec private element anymore. BTW: Audio switching in the demuxer like this is a totally stupid hack in general. Just my 2c. Mosu -- If Darl McBride was in charge, he'd probably make marriage unconstitutional too, since clearly it de-emphasizes the commercial nature of normal human interaction, and probably is a major impediment to the commercial growth of prostitution. - Linus Torvalds
Am Mittwoch, 11. Mai 2005 09:21 schrieb Moritz Bunkus:
You obviously "only" need the decoding of the codec private element. Unfortunately (or fortunately) this will be gone in a few days anyway because Nico is in the process of fixing demux_ogg, demux_mkv and ad_vorbis to use the extradata and not the first three packets. Therefore demux_mkv will probably not need to decode its codec private element anymore.
Next try attached. Now only added comparison of the private data before switching. Michael
On Sábado 14 Mayo 2005 01:25, Michael Behrisch wrote:
Next try attached. Now only added comparison of the private data before switching.
It seems to me you are patching some old version of demux_mkv. The optional parameter patch got applied a couple of weeks back, so could you please cvs update and do a similar check when the parameter is given? -- kiriuja
Am Montag, 16. Mai 2005 11:02 schrieb kiriuja:
On Sábado 14 Mayo 2005 01:25, Michael Behrisch wrote:
Next try attached. Now only added comparison of the private data before switching.
It seems to me you are patching some old version of demux_mkv. The optional parameter patch got applied a couple of weeks back, so could you please cvs update and do a similar check when the parameter is given?
Here it is. Michael
Am Montag, 16. Mai 2005 12:21 schrieb Michael Behrisch:
It seems to me you are patching some old version of demux_mkv. The optional parameter patch got applied a couple of weeks back, so could you please cvs update and do a similar check when the parameter is given?
Here it is.
Could somebody have a look at it and apply if possible? Thanks, Michael
On Fri, May 20, 2005 at 06:29:27PM +0200, Michael Behrisch wrote:
Am Montag, 16. Mai 2005 12:21 schrieb Michael Behrisch:
It seems to me you are patching some old version of demux_mkv. The optional parameter patch got applied a couple of weeks back, so could you please cvs update and do a similar check when the parameter is given?
Here it is.
Could somebody have a look at it and apply if possible?
Moritz? Diego
Hey, applied, thanks. Mosu -- If Darl McBride was in charge, he'd probably make marriage unconstitutional too, since clearly it de-emphasizes the commercial nature of normal human interaction, and probably is a major impediment to the commercial growth of prostitution. - Linus Torvalds
participants (10)
-
D Richard Felker III -
Diego Biurrun -
Guillaume POIRIER -
Guillaume Poirier -
Joey Parrish -
kiriuja -
Loren Merritt -
Michael Behrisch -
Michael Behrisch -
Moritz Bunkus