Reading vobsub directly from a RAR archive
Here is a patch to make use of the UniquE RAR File Library. Just put the files urarlib.{c,h}¹ in MPlayer's source directory, then do the configure and make and it should work. Note that the unrarlib I have (v0.3.4) _can not_ read WinRAR v3 files. Should the urarlib files be commited to CVS? Should I apply? ¹ <URL:http://www.unrarlib.org/>, I can't seem to reach it now. Did anybody get the latest version?
On Wednesday 24 July 2002 19:15, Kim Minh Kaplan wrote:
Here is a patch to make use of the UniquE RAR File Library. nice, I'll check it asap.
Just put the files urarlib.{c,h}¹ in MPlayer's source directory, then do the configure and make and it should work. Note that the unrarlib I have (v0.3.4) _can not_ read WinRAR v3 files. Yes, and possibly it never wil as winrar 3 uses a completely new compression technique (AFAIK), this was also said on the urarlib forum.
Should the urarlib files be commited to CVS? Should I apply? I'll check it and we should also add the GPL note to the files before commiting them.
¹ <URL:http://www.unrarlib.org/>, I can't seem to reach it now. Did anybody get the latest version? Seems traffic is maxed out, but I doubt much has changed besides the license change recently.
-- Best Regards, Atmos ____________________________________________ - MPlayer Developer - http://mplayerhq.hu/ - ____________________________________________
On Thursday 25 July 2002 00:36, Felix Buenemann wrote:
On Wednesday 24 July 2002 19:15, Kim Minh Kaplan wrote:
Here is a patch to make use of the UniquE RAR File Library.
nice, I'll check it asap. hmm, your code doesn't work for me, there are some errors, but I couldn't yet fix all of them. You should start tracing from mpeg_run error.
One of your errors seems to be, that your rar_read returns the number of bytes read instead of the number of elements read, as expected from fread, which leads to that code failing (I have not fixed that in my patch). I attached my current changes including your patch against cvs. A sample vobsubrar (which I used for testing) is available at: http://mplayerhq.hu/~atmos4/swep1vobsub.rar (ignore that the first subpic looks strange, it's generated by an early version of mencoder's vobsub ripping code) Btw. my patch also includes changed/fixed versions of urarlib.[ch], that are adapted to mplayer's config scheme and license. I also (hopefully) fixed the assemblerbugs, so now it works with gcc 3.1 (before internal compiler error). -- Best Regards, Atmos ____________________________________________ - MPlayer Developer - http://mplayerhq.hu/ - ____________________________________________
Felix Buenemann writes:
hmm, your code doesn't work for me, there are some errors, but I couldn't yet fix all of them. You should start tracing from mpeg_run error.
One of your errors seems to be, that your rar_read returns the number of bytes read instead of the number of elements read
Right, and there were also some signedness issues. This fixes it. Should I commit? Kim Minh.
On Sunday 28 July 2002 18:38, Kim Minh Kaplan wrote:
Felix Buenemann writes:
hmm, your code doesn't work for me, there are some errors, but I couldn't yet fix all of them. You should start tracing from mpeg_run error.
One of your errors seems to be, that your rar_read returns the number of bytes read instead of the number of elements read
Right, and there were also some signedness issues. This fixes it. Should I commit? hmm, I'll check it and update to urarlib 0.4.0 (the GPL rel) or you already did?
Kim Minh.
-- Best Regards, Atmos ____________________________________________ - MPlayer Developer - http://mplayerhq.hu/ - ____________________________________________
Felix Buenemann writes:
hmm, I'll check it and update to urarlib 0.4.0 (the GPL rel) or you already did?
Yes, I compiled with 0.4.0 here (it works with GCC 3). Kim Minh.
Oops, I forgot the patch... Here it is. Kim Minh.
Felix Buenemann writes:
On Wednesday 24 July 2002 19:15, Kim Minh Kaplan wrote:
the unrarlib I have (v0.3.4) _can not_ read WinRAR v3 files.
Yes, and possibly it never wil
Well, then I guess there is not much point in continuing to develop using it... hmm I checked again, the website says, that support is not yet implemented, however the sources for the new compression algo (for textfiles) is available freely, a link can be found in the RAR changelog on www.rarlab.com, so maybe
On Saturday 27 July 2002 15:47, Kim Minh Kaplan wrote: there are chances. Another idea would be to use a system() call to unrar or rar, but personally I dislike that method.
Kim Minh.
-- Best Regards, Atmos ____________________________________________ - MPlayer Developer - http://mplayerhq.hu/ - ____________________________________________
Felix Buenemann writes:
Another idea would be to use a system() call to unrar or rar, but personally I dislike that method.
Yes, ugly. Kim Minh.
participants (2)
-
Felix Buenemann -
Kim Minh Kaplan