[PATCH] fix configure with --enable-x264
./configure --enable-x264 --with-x264libdir=/usr/lib/ does not add -lx264 to EXTRA_LIB (config.mak) Index: mplayer/configure =================================================================== --- mplayer/configure (.../svn://svn.mplayerhq.hu/mplayer/trunk) (revision 20778) +++ mplayer/configure (.../mplayer) (working copy) @@ -6461,7 +6461,6 @@ #endif int main(void) { x264_encoder_open((void*)0); return 0; } EOF - _ld_x264="$_ld_x264 -lx264 $_ld_pthread" _x264=no if cc_check $_ld_x264 $_ld_lm ; then _x264=yes @@ -6476,6 +6475,7 @@ _def_x264='#define HAVE_X264 1' _def_lavc_x264='#define CONFIG_X264 1' _codecmodules="x264 $_codecmodules" + _ld_x264="$_ld_x264 -lx264 $_ld_pthread" else _x264=no _ld_x264=''
On Wed, Nov 08, 2006 at 04:58:17PM +0300, Alexander Beregalov wrote:
./configure --enable-x264 --with-x264libdir=/usr/lib/ does not add -lx264 to EXTRA_LIB (config.mak)
Correct. You are overriding autodetection. And your patch breaks autodetection. Diego
On Wednesday 08 November 2006 17:51, Diego Biurrun wrote:
On Wed, Nov 08, 2006 at 04:58:17PM +0300, Alexander Beregalov wrote:
./configure --enable-x264 --with-x264libdir=/usr/lib/ does not add -lx264 to EXTRA_LIB (config.mak)
Correct. You are overriding autodetection. And your patch breaks autodetection.
That means you have to use --enable-x264 --with-extralibs="-lx264" ? I find it a bit complicated. "-lx264" is not something that is autodetected, it should be added anytime x264 is used. Btw, xvid libs are automatically added with --enable-xvid. Fixed patch attached.
On Wed, Nov 08, 2006 at 07:47:14PM +0300, Evgeniy Stepanov wrote:
On Wednesday 08 November 2006 17:51, Diego Biurrun wrote:
On Wed, Nov 08, 2006 at 04:58:17PM +0300, Alexander Beregalov wrote:
./configure --enable-x264 --with-x264libdir=/usr/lib/ does not add -lx264 to EXTRA_LIB (config.mak)
Correct. You are overriding autodetection. And your patch breaks autodetection.
That means you have to use --enable-x264 --with-extralibs="-lx264" ?
If you wish to override autodetection, then yes. This is exactly the meaning of the term "overriding autodetection".
I find it a bit complicated. "-lx264" is not something that is autodetected, it should be added anytime x264 is used. Btw, xvid libs are automatically added with --enable-xvid.
The XviD check is broken then. In fact I'm looking at it right now and it is also quite obfuscated and redundant.. I'll try to fix it up. Diego
On Wed, Nov 08, 2006 at 06:04:31PM +0100, Diego Biurrun wrote:
The XviD check is broken then. In fact I'm looking at it right now and it is also quite obfuscated and redundant..
I'll try to fix it up.
Done. Testing welcome, I have no XviD. Diego
On Wed, Nov 08, 2006 at 06:04:31PM +0100, Diego Biurrun wrote:
On Wed, Nov 08, 2006 at 07:47:14PM +0300, Evgeniy Stepanov wrote:
On Wednesday 08 November 2006 17:51, Diego Biurrun wrote:
On Wed, Nov 08, 2006 at 04:58:17PM +0300, Alexander Beregalov wrote:
./configure --enable-x264 --with-x264libdir=/usr/lib/ does not add -lx264 to EXTRA_LIB (config.mak)
Correct. You are overriding autodetection. And your patch breaks autodetection.
That means you have to use --enable-x264 --with-extralibs="-lx264" ?
If you wish to override autodetection, then yes. This is exactly the meaning of the term "overriding autodetection".
This is utter nonsense. You should not need --with-extralibs to use the library that was requested with --enable!! --with-extralibs is just to add library paths or extra library dependencies that aren't detected.
I find it a bit complicated. "-lx264" is not something that is autodetected, it should be added anytime x264 is used. Btw, xvid libs are automatically added with --enable-xvid.
The XviD check is broken then. In fact I'm looking at it right now and it is also quite obfuscated and redundant..
No, your idea of what --enable should do it broken! Can you give ANY good reason why the requested -l should be omitted??? Rich
On Wed, Nov 08, 2006 at 06:05:30PM -0500, Rich Felker wrote:
On Wed, Nov 08, 2006 at 06:04:31PM +0100, Diego Biurrun wrote:
On Wed, Nov 08, 2006 at 07:47:14PM +0300, Evgeniy Stepanov wrote:
On Wednesday 08 November 2006 17:51, Diego Biurrun wrote:
On Wed, Nov 08, 2006 at 04:58:17PM +0300, Alexander Beregalov wrote:
./configure --enable-x264 --with-x264libdir=/usr/lib/ does not add -lx264 to EXTRA_LIB (config.mak)
Correct. You are overriding autodetection. And your patch breaks autodetection.
That means you have to use --enable-x264 --with-extralibs="-lx264" ?
If you wish to override autodetection, then yes. This is exactly the meaning of the term "overriding autodetection".
This is utter nonsense. You should not need --with-extralibs to use the library that was requested with --enable!! --with-extralibs is just to add library paths or extra library dependencies that aren't detected.
Look around in configure. As usual, there is no general agreement as to what the tests should do or not do ... In any case I have a hunch that the dependency on pthread is incorrect. I don't use x264, though ... Diego
Hi, Diego Biurrun wrote:
On Wed, Nov 08, 2006 at 06:05:30PM -0500, Rich Felker wrote:
On Wed, Nov 08, 2006 at 06:04:31PM +0100, Diego Biurrun wrote:
On Wed, Nov 08, 2006 at 07:47:14PM +0300, Evgeniy Stepanov wrote:
On Wednesday 08 November 2006 17:51, Diego Biurrun wrote:
On Wed, Nov 08, 2006 at 04:58:17PM +0300, Alexander Beregalov wrote:
./configure --enable-x264 --with-x264libdir=/usr/lib/ does not add -lx264 to EXTRA_LIB (config.mak)
Correct. You are overriding autodetection. And your patch breaks autodetection.
That means you have to use --enable-x264 --with-extralibs="-lx264" ?
If you wish to override autodetection, then yes. This is exactly the meaning of the term "overriding autodetection".
This is utter nonsense. You should not need --with-extralibs to use the library that was requested with --enable!! --with-extralibs is just to add library paths or extra library dependencies that aren't detected.
Look around in configure. As usual, there is no general agreement as to what the tests should do or not do ...
In any case I have a hunch that the dependency on pthread is incorrect.
x264 has a multithreaded encoding mode that uses pthread on unix platforms... x264 can be compiled with or without multi-threaded support (so pthred isn't always needed). x264 supports pkg-config, so in theory we shouldn't have to worry about what are the dependencies of x264. Guillaume
Hello, On Thu, Nov 09, 2006 at 10:58:25AM +0100, Diego Biurrun wrote:
In any case I have a hunch that the dependency on pthread is incorrect. I don't use x264, though ...
It is only needed when x264 is compiled against pthread, which can be chosen while configuring x264. So always linking against it is at least overkill. Greetings, Reimar Döffinger
participants (6)
-
Alexander Beregalov -
Diego Biurrun -
Evgeniy Stepanov -
Guillaume Poirier -
Reimar Döffinger -
Rich Felker