FW: mplayer patch for DirectFB-0.9.13
Just forwarding patch... JS -----Original Message----- From: Sven Neumann [mailto:neo@bender.convergence.de] On Behalf Of Sven Neumann Sent: Friday, July 26, 2002 3:14 PM To: Jiri Svoboda Subject: mplayer patch for DirectFB-0.9.13 Hi Jiri, the DirectFB DisplayLayer API is still improving and the latest change breaks the build of mplayer. Here's a patch that makes it compile again. The checks for the video layer could be improved further by using the new DFBDisplayLayerType found in the DFBDisplayLayerDescription but I've choosen to keep the patch as small as possible. Salut, Sven
Just forwarding patch... JS
-----Original Message----- From: Sven Neumann [mailto:neo@bender.convergence.de] On Behalf Of Sven Neumann Sent: Friday, July 26, 2002 3:14 PM To: Jiri Svoboda Subject: mplayer patch for DirectFB-0.9.13
Hi Jiri,
the DirectFB DisplayLayer API is still improving and the latest change breaks the build of mplayer. Here's a patch that makes it compile again. The checks for the video layer could be improved further by using the new DFBDisplayLayerType found in the DFBDisplayLayerDescription but I've choosen to keep the patch as small as possible. Hmm, doesn't directfb declare a version string as some cpp macro in their
On Sunday 28 July 2002 19:24, Jiří Svoboda wrote: headers? IMHO adding a new configure check for each and every new directfb version is a bit ugly. -- Best Regards, Atmos ____________________________________________ - MPlayer Developer - http://mplayerhq.hu/ - ____________________________________________
Hi,
Hmm, doesn't directfb declare a version string as some cpp macro in their headers? IMHO adding a new configure check for each and every new directfb version is a bit ugly.
I think no, it's declared as extern const unsigned int ... But small app could return version string - could this be solution? JS
Hi,
Hmm, doesn't directfb declare a version string as some cpp macro in their headers? IMHO adding a new configure check for each and every new directfb version is a bit ugly.
I think no, it's declared as extern const unsigned int ...
But small app could return version string - could this be solution? yea, proably generate it on the fly from embedded sources in configure and
On Monday 29 July 2002 09:06, Jiri Svoboda wrote: then do something like #define DFB_VERSION 000913 or something like that into config.h.
JS
-- Best Regards, Atmos ____________________________________________ - MPlayer Developer - http://mplayerhq.hu/ - ____________________________________________
Could it be this way? JS
-----Original Message----- From: mplayer-dev-eng-admin@mplayerhq.hu [mailto:mplayer-dev-eng-admin@mplayerhq.hu] On Behalf Of Felix Buenemann Sent: Monday, July 29, 2002 2:21 PM To: mplayer-dev-eng@mplayerhq.hu Subject: Re: [MPlayer-dev-eng] FW: mplayer patch for DirectFB-0.9.13
Hi,
Hmm, doesn't directfb declare a version string as some cpp macro in their headers? IMHO adding a new configure check for each and every new directfb version is a bit ugly.
I think no, it's declared as extern const unsigned int ...
But small app could return version string - could this be solution? yea, proably generate it on the fly from embedded sources in configure and
On Monday 29 July 2002 09:06, Jiri Svoboda wrote: then do something like #define DFB_VERSION 000913 or something like that into config.h.
JS
-- Best Regards, Atmos ____________________________________________ - MPlayer Developer - http://mplayerhq.hu/ - ____________________________________________ _______________________________________________ MPlayer-dev-eng mailing list MPlayer-dev-eng@mplayerhq.hu http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng
On Tuesday 30 July 2002 19:53, Jiří Svoboda wrote:
> Could it be this way?
Looks nice, but I have some thoughts:
- Shouldn't it be major version *1000 instead of *100 in configure?
- It would IMHO be better to directly use #if DIRECTFBVERSION > n in the code
instead of doing this unneeded remapping to HAVE_DIRECTFBn
> JS
>
> > -----Original Message-----
> > From: mplayer-dev-eng-admin@mplayerhq.hu
> > [mailto:mplayer-dev-eng-admin@mplayerhq.hu] On Behalf Of
> > Felix Buenemann
> > Sent: Monday, July 29, 2002 2:21 PM
> > To: mplayer-dev-eng@mplayerhq.hu
> > Subject: Re: [MPlayer-dev-eng] FW: mplayer patch for DirectFB-0.9.13
> >
> > On Monday 29 July 2002 09:06, Jiri Svoboda wrote:
> > > Hi,
> > >
> > > > Hmm, doesn't directfb declare a version string as some
> >
> > cpp macro in
> >
> > > > their headers? IMHO adding a new configure check for each
> >
> > and every
> >
> > > > new directfb
> > > > version is a bit ugly.
> > >
> > > I think no, it's declared as extern const unsigned int ...
> > >
> > > But small app could return version string - could this be solution?
> >
> > yea, proably generate it on the fly from embedded sources in
> > configure and
> > then do something like #define DFB_VERSION 000913 or
> > something like that into
> > config.h.
> >
> > > JS
> >
> > --
> > Best Regards,
> > Atmos
--
Best Regards,
Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________
Hi, > -----Original Message----- > From: mplayer-dev-eng-admin@mplayerhq.hu > [mailto:mplayer-dev-eng-admin@mplayerhq.hu] On Behalf Of > Felix Buenemann > Sent: Thursday, August 01, 2002 6:21 PM > To: mplayer-dev-eng@mplayerhq.hu > Subject: Re: [MPlayer-dev-eng] FW: mplayer patch for DirectFB-0.9.13 > > > On Tuesday 30 July 2002 19:53, Jiří Svoboda wrote: > > Could it be this way? > Looks nice, but I have some thoughts: > - Shouldn't it be major version *1000 instead of *100 in configure? No - there are brackest -> major version *10000 > - It would IMHO be better to directly use #if > DIRECTFBVERSION > n in the code > instead of doing this unneeded remapping to HAVE_DIRECTFBn Yes. Hopefully this one is good :-) For configure use previous configure patch. I'm now developing new vo_directfb driver which should be used for dfb>=0.9.13. How should I this incorporate? It's completely new file. So there should be some file swap during configure... JS
Hi,
DIRECTFBVERSION > n in the code instead of doing this unneeded remapping to HAVE_DIRECTFBn
Yes. Hopefully this one is good :-) For configure use previous configure patch.
I'm now developing new vo_directfb driver which should be used for dfb>=0.9.13. How should I this incorporate? It's completely new file. So there should be some file swap during configure...
name it vo_directfb2.c or so, and let configure to put the right filename in libvo/config.mak depending on dfb version A'rpi / Astral & ESP-team -- Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
Hi,
- It would IMHO be better to directly use #if DIRECTFBVERSION > n in the code instead of doing this unneeded remapping to HAVE_DIRECTFBn
Yes. Hopefully this one is good :-)
should i include this patch in 0.90pre6 releasing tomorrow?
For configure use previous configure patch.
hmm? A'rpi / Astral & ESP-team -- Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
Hi,
Hi,
- It would IMHO be better to directly use #if DIRECTFBVERSION > n in the code instead of doing this unneeded remapping to HAVE_DIRECTFBn
Yes. Hopefully this one is good :-)
should i include this patch in 0.90pre6 releasing tomorrow?
Yes. Together with configure patch (attached).
For configure use previous configure patch.
hmm?
Look few days ago - older version of this patch was there - attached to this mail. JS
Hi,
Yes. Hopefully this one is good :-)
should i include this patch in 0.90pre6 releasing tomorrow?
Yes. Together with configure patch (attached).
applied, with changes, please test A'rpi / Astral & ESP-team -- Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
-----Original Message----- From: mplayer-dev-eng-admin@mplayerhq.hu [mailto:mplayer-dev-eng-admin@mplayerhq.hu] On Behalf Of Arpi Sent: Monday, August 05, 2002 1:43 PM To: mplayer-dev-eng@mplayerhq.hu Subject: Re: RE: RE: [MPlayer-dev-eng] FW: mplayer patch for DirectFB-0.9.13
Hi,
Yes. Hopefully this one is good :-)
should i include this patch in 0.90pre6 releasing tomorrow?
Yes. Together with configure patch (attached).
applied, with changes, please test
Looks OK for me. JS
participants (3)
-
Arpi -
Felix Buenemann -
Jiří Svoboda