[PATCH] OSD menu remove reentrant option 'auto-close' from cmdlist and filesel
Hello, In libmenu, module cmdlist and filesel support setting multiple commands, so the 'auto-close' option is reentrant for these two module. This patch remove the reentrant option. If there's no objection, I will apply this patch in 2 days. To use auto-close feature, just use the multiple commands feature and add 'menu cancel' or 'menu hide' into the main command ( for cmdlist, the main command set in 'ok' property, for filesel, set in 'file-action' and 'dir-action' property). -- Ulion
Hello, On Tue, Dec 25, 2007 at 05:17:50PM +0800, Ulion wrote:
In libmenu, module cmdlist and filesel support setting multiple commands, so the 'auto-close' option is reentrant for these two module. This patch remove the reentrant option. If there's no objection, I will apply this patch in 2 days.
I've been puzzling about this for some time... Do you mean "redundant" instead of "reentrant"?
To use auto-close feature, just use the multiple commands feature and add 'menu cancel' or 'menu hide' into the main command ( for cmdlist, the main command set in 'ok' property, for filesel, set in 'file-action' and 'dir-action' property).
Hmm... maybe there should be some examples for that? Sounds like non-trivial to for someone how knows nothing about the details of this system... Greetings, Reimar Döffinger
2007/12/25, Reimar Döffinger <Reimar.Doeffinger@stud.uni-karlsruhe.de>:
Hello, On Tue, Dec 25, 2007 at 05:17:50PM +0800, Ulion wrote:
In libmenu, module cmdlist and filesel support setting multiple commands, so the 'auto-close' option is reentrant for these two module. This patch remove the reentrant option. If there's no objection, I will apply this patch in 2 days.
I've been puzzling about this for some time... Do you mean "redundant" instead of "reentrant"?
Sorry, my mistake, I want to say 'redundant', that's what I meant.
To use auto-close feature, just use the multiple commands feature and add 'menu cancel' or 'menu hide' into the main command ( for cmdlist, the main command set in 'ok' property, for filesel, set in 'file-action' and 'dir-action' property).
Hmm... maybe there should be some examples for that? Sounds like non-trivial to for someone how knows nothing about the details of this system...
OK, for examples, original you have: <filesel ..... auto-close="yes"> now you probably want this: <filesel ..... file-action="loadfile '%p' menu cancel"> original you have: <cmdlist .... auto-close="yes"> ... <e name="XXX" ok="some action command"> now you can use: <cmdlist ....> ... <e name="XXX" ok="some action command menu hide"> -- Ulion
Hello, On Tue, Dec 25, 2007 at 09:13:22PM +0800, Ulion wrote: [...]
Hmm... maybe there should be some examples for that? Sounds like non-trivial to for someone how knows nothing about the details of this system...
OK, for examples,
I meant in the documentation, I don't care about it personally :-) Greetings, Reimar Döffinger
2007/12/25, Reimar Döffinger <Reimar.Doeffinger@stud.uni-karlsruhe.de>:
Hello, On Tue, Dec 25, 2007 at 09:13:22PM +0800, Ulion wrote: [...]
Hmm... maybe there should be some examples for that? Sounds like non-trivial to for someone how knows nothing about the details of this system...
OK, for examples,
I meant in the documentation, I don't care about it personally :-)
I don't think currently there's any document existed for any stuff in menu.conf, it's totally undocumented. So I choose to keep it undocumented until someday somebody send document patch for it. -- Ulion
2007/12/25, Ulion <ulion2002@gmail.com>:
Hello,
In libmenu, module cmdlist and filesel support setting multiple commands, so the 'auto-close' option is reentrant for these two module. This patch remove the reentrant option. If there's no objection, I will apply this patch in 2 days.
To use auto-close feature, just use the multiple commands feature and add 'menu cancel' or 'menu hide' into the main command ( for cmdlist, the main command set in 'ok' property, for filesel, set in 'file-action' and 'dir-action' property).
Applied. -- Ulion
participants (2)
-
Reimar Döffinger -
Ulion