[PATCH]Disable liba52 and libmp3 for icc
Hi! Currently, icc can't compile the internal libraries liba52 and libmp3 (with optimizations). Attached patch changes the default for both libraries from "enabled" to "autodetect" and disables the comilation for intel compilers. Ok to apply? Carl Eugen
On Wed, 2008-03-26 at 21:33 +0100, Carl Eugen Hoyos wrote:
Currently, icc can't compile the internal libraries liba52 and libmp3 (with optimizations). Attached patch changes the default for both libraries from "enabled" to "autodetect" and disables the comilation for intel compilers.
This is only because of linking failures due to optimized-out variables right? Better would be to fix the asm, removing MANGLE and using asm arguments instead. At least for liba52 that shouldn't be too much work. MANGLE is only used in two files, imdct.c and resample_mmx.c, and I already created a patch removing MANGLE from imdct.c earlier when testing that the technique works.
On Wed, Mar 26, 2008 at 11:09:34PM +0200, Uoti Urpala wrote:
On Wed, 2008-03-26 at 21:33 +0100, Carl Eugen Hoyos wrote:
Currently, icc can't compile the internal libraries liba52 and libmp3 (with optimizations). Attached patch changes the default for both libraries from "enabled" to "autodetect" and disables the comilation for intel compilers.
This is only because of linking failures due to optimized-out variables right? Better would be to fix the asm, removing MANGLE and using asm arguments instead. At least for liba52 that shouldn't be too much work. MANGLE is only used in two files, imdct.c and resample_mmx.c, and I already created a patch removing MANGLE from imdct.c earlier when testing that the technique works.
Carl, if you could make these changes and they are backwards-compatible then that is likely the best solution. Otherwise feel free to apply your patch. Diego
Hi!
Carl, if you could make these changes and they are backwards-compatible then that is likely the best solution.
I won't work on that because both ac3 and mp3 can be decoded by ffmpeg (mp2 - in dvb/ts - shows ugly warnings but works of course).
Otherwise feel free to apply your patch.
I will if and after I finish the patch for swscale. Carl Eugen
On Mon, Mar 31, 2008 at 10:53 PM, Carl Eugen Hoyos <cehoyos@ag.or.at> wrote:
Hi!
Carl, if you could make these changes and they are backwards-compatible then that is likely the best solution.
I won't work on that because both ac3 and mp3 can be decoded by ffmpeg (mp2 - in
They are also slower. People who compile stuff with icc would do it to get better optimizations and this means they care about speed. Please try to fix it first.
Hi! Carl Eugen Hoyos <cehoyos <at> rainbow.studorg.tuwien.ac.at> writes:
Currently, icc can't compile the internal libraries liba52 and libmp3 (with optimizations). Attached patch changes the default for both libraries from "enabled" to "autodetect" and disables the comilation for intel compilers.
Patch applied. Compilation with icc should be possible now out-of-the-box. Carl Eugen
participants (5)
-
Carl Eugen Hoyos -
Carl Eugen Hoyos -
Diego Biurrun -
Ivan Kalvachev -
Uoti Urpala