[PATCH] libavcodec deinterlace support
Hello, Here's a small patch that adds support for libavcodec's deinterlacing filter. It's basically copied out of the ffmpeg encoder source and pasted into libmpcodecs/ve_lavc.c:put_image(), the way ffmpeg does it. It adds the "deinterlace" config flag to the lavcopts codec options. I use it for encoding the (interlaced-looking) mpeg1video that fame outputs when grabbing realtime from my TV card (alas, I couldn't get mencoder to do that part) to libavcodec's mpeg4, and it makes the picture much prettier. On the downside, it does make the encoder about 20% slower. Of course, if you don't turn it on, nothing different happens :) I patched this against today's CVS snapshot from the download page -- I hope that's okay (it only modifies one file anyway). If not, tell me and I'll use cvs checkout. Also, I'm not very experienced in making patches, so tell me if this isn't formatted right. Please let me know if this works out. Joe Rabinoff
Hi On Tuesday 30 July 2002 06:32, Joe Rabinoff wrote:
Hello,
Here's a small patch that adds support for libavcodec's deinterlacing filter. It's basically copied out of the ffmpeg encoder source and pasted into libmpcodecs/ve_lavc.c:put_image(), the way ffmpeg does it. IMO this should be put in a video filter and not in an encoder, (its a filter, isnt it?) see libmpcodecs/vf* for some video filter examples
[...] Michael
On Tuesday 30 July 2002 09:41, Michael Niedermayer wrote:
Hi
On Tuesday 30 July 2002 06:32, Joe Rabinoff wrote:
Hello,
Here's a small patch that adds support for libavcodec's deinterlacing filter. It's basically copied out of the ffmpeg encoder source and pasted into libmpcodecs/ve_lavc.c:put_image(), the way ffmpeg does it.
IMO this should be put in a video filter and not in an encoder, (its a filter, isnt it?) see libmpcodecs/vf* for some video filter examples ???? Why not use -vop pp=0x20000 ?
Michael
-- Best Regards, Atmos ____________________________________________ - MPlayer Developer - http://mplayerhq.hu/ - ____________________________________________
Hi On Tuesday 30 July 2002 14:06, Felix Buenemann wrote:
On Tuesday 30 July 2002 09:41, Michael Niedermayer wrote:
Hi
On Tuesday 30 July 2002 06:32, Joe Rabinoff wrote:
Hello,
Here's a small patch that adds support for libavcodec's deinterlacing filter. It's basically copied out of the ffmpeg encoder source and pasted into libmpcodecs/ve_lavc.c:put_image(), the way ffmpeg does it.
IMO this should be put in a video filter and not in an encoder, (its a filter, isnt it?) see libmpcodecs/vf* for some video filter examples
???? Why not use -vop pp=0x20000 ? lavc uses a different algo to deinterlace, dunno which is better (i didnt compare them), but we should support both
[...] Michael
Hi,
Hi
On Tuesday 30 July 2002 06:32, Joe Rabinoff wrote:
Hello,
Here's a small patch that adds support for libavcodec's deinterlacing filter. It's basically copied out of the ffmpeg encoder source and pasted into libmpcodecs/ve_lavc.c:put_image(), the way ffmpeg does it. IMO this should be put in a video filter and not in an encoder, (its a filter, isnt it?) see libmpcodecs/vf* for some video filter examples
agree what about vf_lavcdeint.c compiled only fi libavcodec is enabled A'rpi / Astral & ESP-team -- Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
On Tue, 2002-07-30 at 03:41, Michael Niedermayer wrote:
IMO this should be put in a video filter and not in an encoder, (its a filter, isnt it?) see libmpcodecs/vf* for some video filter examples
Ok, I'll put it in vf_lavcdeint.c as A'rpi suggests and submit another patch later. I'm a bit overwhelmed by all of the image formats that MPlayer supports, and I'm not quite sure which IMGFMT_* corresponds to which of avcodec's PIX_FMT_* (the deinterlacer cares about this). Can someone tell me where I can find out what they all mean? Thanks, Joe Rabinoff
Hi On Wednesday 31 July 2002 00:08, Joe Rabinoff wrote:
On Tue, 2002-07-30 at 03:41, Michael Niedermayer wrote:
IMO this should be put in a video filter and not in an encoder, (its a filter, isnt it?) see libmpcodecs/vf* for some video filter examples
Ok, I'll put it in vf_lavcdeint.c as A'rpi suggests and submit another patch later.
I'm a bit overwhelmed by all of the image formats that MPlayer supports, and I'm not quite sure which IMGFMT_* corresponds to which of avcodec's PIX_FMT_* (the deinterlacer cares about this). Can someone tell me where I can find out what they all mean? DOCS/tech/colorspaces.txt
[...] Michael
participants (4)
-
Arpi -
Felix Buenemann -
Joe Rabinoff -
Michael Niedermayer