[PATCH] vf_expand - clear left and right side of the image if needed
Hi, I added the code to to the $subj. I'm not sure whether I did all I had to, but it works. Please review. Greets, -- .--------- Tomáš Janoušek a.k.a. Liskni_si ---------. : NOMI team, developer, http://tomi.nomi.cz/ tomi@nomi.cz : ' JID:liskni_si@jabber.cz, ICQ#161807083, tel:+420608876277 '
Hi, Tomas Janousek napsal(a):
I added the code to to the $subj. I'm not sure whether I did all I had to, but it works. Please review.
Anybody seen this? Anything wrong? -- .--------- Tomáš Janoušek a.k.a. Liskni_si ---------. : NOMI team, developer, http://tomi.nomi.cz/ tomi@nomi.cz : ' JID:liskni_si@jabber.cz, ICQ#161807083, tel:+420608876277 '
Hello, On Tue, Sep 12, 2006 at 02:10:55PM +0200, Tomas Janousek wrote:
I added the code to to the $subj. I'm not sure whether I did all I had to, but it works. Please review.
How do you know if clearing them is needed? I wasn't really able to find a check for that in this patch (and I have no idea how to check this). Greetings, Reimar Döffinger
Hi, Reimar Döffinger napsal(a):
How do you know if clearing them is needed? I wasn't really able to find a check for that in this patch (and I have no idea how to check this).
Well, I just copied the code which does it for the top and bottom and rewrote it. It worked for me, so I posted it, cos I thought no one had ever needed it and since I had needed it, I had written it. -- .--------- Tomáš Janoušek a.k.a. Liskni_si ---------. : NOMI team, developer, http://tomi.nomi.cz/ tomi@nomi.cz : ' JID:liskni_si@jabber.cz, ICQ#161807083, tel:+420608876277 '
Hello, On Sun, Oct 22, 2006 at 08:55:06PM +0200, Tomas Janousek wrote:
Reimar Döffinger napsal(a):
How do you know if clearing them is needed? I wasn't really able to find a check for that in this patch (and I have no idea how to check this).
Well, I just copied the code which does it for the top and bottom and rewrote it. It worked for me, so I posted it, cos I thought no one had ever needed it and since I had needed it, I had written it.
Oh, I think I completely misunderstood what the patch was supposed to do.. Will try to have a closer look later Greetings, Reimar Döffinger
Hi! On 22 Октябрь 2006 23:49 Reimar Döffinger wrote:
Hello,
On Sun, Oct 22, 2006 at 08:55:06PM +0200, Tomas Janousek wrote:
Reimar Döffinger napsal(a):
How do you know if clearing them is needed? I wasn't really able to find a check for that in this patch (and I have no idea how to check this).
Well, I just copied the code which does it for the top and bottom and rewrote it. It worked for me, so I posted it, cos I thought no one had ever needed it and since I had needed it, I had written it.
Oh, I think I completely misunderstood what the patch was supposed to do.. Will try to have a closer look later
Well, this behaviour (not patch) is really needed and I'll try to explain why. Suppose, you have a video wich doesn't fill all width of screen in the fullscreen mode, for examle, 700x600 video on the 4:3 monitor. Try to find such video or make it with mencoder and do the following: 1) go to full screen mode 2) switch to another application (using Atl+Tab in most desktops) 3) switch back to mplayer And you will see bands (probably a part of the current screen on desktop) on the left and right side of the movie. BUT, this patch doesn't fix this up! It must be reworked somehow... Secondary, this patch doesn't apply to current svn and must be implemented manually.
Hi, Andrew Savchenko napsal(a):
Suppose, you have a video wich doesn't fill all width of screen in the fullscreen mode, for examle, 700x600 video on the 4:3 monitor. Try to find such video or make it with mencoder and do the following: 1) go to full screen mode 2) switch to another application (using Atl+Tab in most desktops) 3) switch back to mplayer
And you will see bands (probably a part of the current screen on desktop) on the left and right side of the movie.
BUT, this patch doesn't fix this up! It must be reworked somehow... Secondary, this patch doesn't apply to current svn and must be implemented manually.
This is probably another issue. If you use the expand filter to expand it to the aspect of your screen and then use fullscreen, it should be probably ok. Second, I don't understand why it should not apply, because last modification of vf_expand.c is somewhen in April. -- .--------- Tomáš Janoušek a.k.a. Liskni_si ---------. : NOMI team, developer, http://tomi.nomi.cz/ tomi@nomi.cz : ' JID:liskni_si@jabber.cz, ICQ#161807083, tel:+420608876277 '
Ping? Reimar Döffinger napsal(a):
Hello, On Sun, Oct 22, 2006 at 08:55:06PM +0200, Tomas Janousek wrote:
Reimar Döffinger napsal(a):
How do you know if clearing them is needed? I wasn't really able to find a check for that in this patch (and I have no idea how to check this). Well, I just copied the code which does it for the top and bottom and rewrote it. It worked for me, so I posted it, cos I thought no one had ever needed it and since I had needed it, I had written it.
Oh, I think I completely misunderstood what the patch was supposed to do.. Will try to have a closer look later
-- Tomáš Janoušek, a.k.a. Liskni_si, http://work.lisk.in/
Hello, On Tue, Aug 28, 2007 at 01:40:06PM +0200, Tomas Janousek wrote:
Ping?
Sorry for forgetting about it. Applied with small modifications (the second hunk of the patch I think cleared more than necessary). Please test if it works for you.
Reimar Döffinger napsal(a):
On Sun, Oct 22, 2006 at 08:55:06PM +0200, Tomas Janousek wrote:
Reimar Döffinger napsal(a):
How do you know if clearing them is needed? I wasn't really able to find a check for that in this patch (and I have no idea how to check this). Well, I just copied the code which does it for the top and bottom and rewrote it. It worked for me, so I posted it, cos I thought no one had ever needed it and since I had needed it, I had written it.
Oh, I think I completely misunderstood what the patch was supposed to do.. Will try to have a closer look later
Greetings, Reimar Döffinger
On Tue, 28 Aug 2007 15:57:27 +0200, Reimar Döffinger scribed:
Hello, On Tue, Aug 28, 2007 at 01:40:06PM +0200, Tomas Janousek wrote:
Ping?
Sorry for forgetting about it. Applied with small modifications (the second hunk of the patch I think cleared more than necessary). Please test if it works for you.
this didnt fix the bug where the left/right expanded areas were not cleared when using 4/3 video: mplayer file.avi -vf expand=:::::16/9 it was reported here: http://bugzilla.mplayerhq.hu/show_bug.cgi?id=817 any chance one of you could take a look? -compn
participants (4)
-
Andrew Savchenko -
Compn -
Reimar Döffinger -
Tomas Janousek