[PATCH] nostatus-line option
Attila wanted it, I've been meaning to implement it for ages, here it is: A small option that turns off displaying of the status line. Useful if you wish to have full debug output but your terminal is slow or you wish to redirect output to a file without the status line crap. Comments welcome. If somebody has a better name, that is also welcome. Diego
On Fri, May 18, 2007 at 04:57:44PM +0200, Diego Biurrun wrote:
Attila wanted it, I've been meaning to implement it for ages, here it is: A small option that turns off displaying of the status line. Useful if you wish to have full debug output but your terminal is slow or you wish to redirect output to a file without the status line crap.
Comments welcome. If somebody has a better name, that is also welcome.
Uhh, -quiet behaves EXACTLY the same... Unless I'm missing something. Try it: mplayer -v -v -quiet Verbose output, no status line... Also, for finer tuning, '-msglevel avsync=0' etc.
@@ -2418,15 +2419,10 @@
/* Check codecs.conf. */ if(!codecs_file || !parse_codec_cfg(codecs_file)){ - if(!parse_codec_cfg(mem_ptr=get_path("codecs.conf"))){ - if(!parse_codec_cfg(MPLAYER_CONFDIR "/codecs.conf")){ if(!parse_codec_cfg(NULL)){ exit_player_with_rc(NULL, 0); } mp_msg(MSGT_CPLAYER,MSGL_V,MSGTR_BuiltinCodecsConf); - } - } - free( mem_ptr ); // release the buffer created by get_path()
Probably not supposed to be here... - ods15
On Fri, May 18, 2007 at 06:08:52PM +0300, Oded Shimon wrote:
On Fri, May 18, 2007 at 04:57:44PM +0200, Diego Biurrun wrote:
Attila wanted it, I've been meaning to implement it for ages, here it is: A small option that turns off displaying of the status line. Useful if you wish to have full debug output but your terminal is slow or you wish to redirect output to a file without the status line crap.
Comments welcome. If somebody has a better name, that is also welcome.
Uhh, -quiet behaves EXACTLY the same... Unless I'm missing something.
RTFS mplayer.c.
Also, for finer tuning, '-msglevel avsync=0' etc.
There are other messages with MSGT_AVSYNC.
@@ -2418,15 +2419,10 @@
/* Check codecs.conf. */ if(!codecs_file || !parse_codec_cfg(codecs_file)){ - if(!parse_codec_cfg(mem_ptr=get_path("codecs.conf"))){ - if(!parse_codec_cfg(MPLAYER_CONFDIR "/codecs.conf")){ if(!parse_codec_cfg(NULL)){ exit_player_with_rc(NULL, 0); } mp_msg(MSGT_CPLAYER,MSGL_V,MSGTR_BuiltinCodecsConf); - } - } - free( mem_ptr ); // release the buffer created by get_path()
Probably not supposed to be here...
Yes, stray change. Diego
2007/5/18, Diego Biurrun <diego@biurrun.de>:
Attila wanted it, I've been meaning to implement it for ages, here it is: A small option that turns off displaying of the status line. Useful if you wish to have full debug output but your terminal is slow or you wish to redirect output to a file without the status line crap.
Comments welcome. If somebody has a better name, that is also welcome.
My futile attempt to explain what Attila really wanted ends up in another bloatware option. You should've talked to him first. How is your new option different that "-msglevel avsync=4" (afaik status line is 5)
On Fri, May 18, 2007 at 06:13:59PM +0300, Ivan Kalvachev wrote:
2007/5/18, Diego Biurrun <diego@biurrun.de>:
Attila wanted it, I've been meaning to implement it for ages, here it is: A small option that turns off displaying of the status line. Useful if you wish to have full debug output but your terminal is slow or you wish to redirect output to a file without the status line crap.
Comments welcome. If somebody has a better name, that is also welcome.
My futile attempt to explain what Attila really wanted ends up in another bloatware option. You should've talked to him first.
I did. Are you going to tell me next that your English is better than mine?
How is your new option different that "-msglevel avsync=4" (afaik status line is 5)
It turns off the status line and nothing but the status line while leaving all the other avsync-related output untouched. Diego
2007/5/18, Diego Biurrun <diego@biurrun.de>:
On Fri, May 18, 2007 at 06:13:59PM +0300, Ivan Kalvachev wrote:
2007/5/18, Diego Biurrun <diego@biurrun.de>:
Attila wanted it, I've been meaning to implement it for ages, here it is: A small option that turns off displaying of the status line. Useful if you wish to have full debug output but your terminal is slow or you wish to redirect output to a file without the status line crap.
Comments welcome. If somebody has a better name, that is also welcome.
My futile attempt to explain what Attila really wanted ends up in another bloatware option. You should've talked to him first.
I did. Are you going to tell me next that your English is better than mine?
You just don't get it. Attila wanted logging _copy_ of the output to a file. But in a way so the log file does not contain the thousands status lines that indicate normal work. He does not wanted to change the normal screen output in any way. Your patch can not do that.
How is your new option different that "-msglevel avsync=4" (afaik status line is 5)
It turns off the status line and nothing but the status line while leaving all the other avsync-related output untouched.
The rest of avsync related output is 4 messages: 2 DBG2 messages and 2 other messages that would be still visible with the above command as they have lower levels. Attila patch was about creating new status message type (MSGT) only for the status line so the other avsync messages would still be visible. However it doesn't worth the effort, as if you want to see the avsync verbose debug info you'd definitely want to see the avsync info from the status line. After all that's the whole idea of having levels... If you still want clean way to suppress only the status lines, then I'd recommend you the Attila approach, as it just extends existing infrastructure, allows more flexibility and doesn't add new random global variables and options.
On Friday, 18 May 2007 at 16:57, Diego Biurrun wrote:
Attila wanted it, I've been meaning to implement it for ages, here it is: A small option that turns off displaying of the status line. Useful if you wish to have full debug output but your terminal is slow or you wish to redirect output to a file without the status line crap.
Comments welcome. If somebody has a better name, that is also welcome.
I'm against adding another unnecessary global option. Regards, R. -- MPlayer developer and RPMs maintainer: http://mplayerhq.hu http://rpm.livna.org There should be a science of discontent. People need hard times and oppression to develop psychic muscles. -- from "Collected Sayings of Muad'Dib" by the Princess Irulan
On Fri, May 18, 2007 at 04:57:44PM +0200, Diego Biurrun wrote:
Attila wanted it, I've been meaning to implement it for ages, here it is: A small option that turns off displaying of the status line. Useful if you wish to have full debug output but your terminal is slow or you wish to redirect output to a file without the status line crap.
Comments welcome. If somebody has a better name, that is also welcome.
Better patch using Attila's approach as recommended by Ivan. Diego
On Fri, May 18, 2007 at 10:06:04PM +0200, Diego Biurrun wrote:
On Fri, May 18, 2007 at 04:57:44PM +0200, Diego Biurrun wrote:
Attila wanted it, I've been meaning to implement it for ages, here it is: A small option that turns off displaying of the status line. Useful if you wish to have full debug output but your terminal is slow or you wish to redirect output to a file without the status line crap.
Comments welcome. If somebody has a better name, that is also welcome.
Better patch using Attila's approach as recommended by Ivan.
I'm ok with this, just...
Index: mp_msg.h =================================================================== --- mp_msg.h (revision 23339) +++ mp_msg.h (working copy) @@ -103,6 +103,8 @@
#define MSGT_LOADER 44 // dll loader messages
+#define MSGT_STATUSLINE 45 // playback/encoding status line + #define MSGT_MAX 64
Please also update the color mp_msg in mp_msg.c:193 - ods15
On Fri, May 18, 2007 at 11:36:05PM +0300, Oded Shimon wrote:
On Fri, May 18, 2007 at 10:06:04PM +0200, Diego Biurrun wrote:
On Fri, May 18, 2007 at 04:57:44PM +0200, Diego Biurrun wrote:
Attila wanted it, I've been meaning to implement it for ages, here it is: A small option that turns off displaying of the status line. Useful if you wish to have full debug output but your terminal is slow or you wish to redirect output to a file without the status line crap.
Comments welcome. If somebody has a better name, that is also welcome.
Better patch using Attila's approach as recommended by Ivan.
I'm ok with this, just...
--- mp_msg.h (revision 23339) +++ mp_msg.h (working copy) @@ -103,6 +103,8 @@
#define MSGT_LOADER 44 // dll loader messages
+#define MSGT_STATUSLINE 45 // playback/encoding status line + #define MSGT_MAX 64
Please also update the color mp_msg in mp_msg.c:193
Applied with the color update. Diego
On Fri, 18 May 2007 16:57:44 +0200 Diego Biurrun <diego@biurrun.de> wrote:
Attila wanted it, I've been meaning to implement it for ages, here it is: A small option that turns off displaying of the status line. Useful if you wish to have full debug output but your terminal is slow or you wish to redirect output to a file without the status line crap.
I'm against it ;-) As just explained on IRC, it's not about disabling the status line at all, but about being able to filter out the status line at the mp_msg() level. After a discussion with Uoti, we came to the conclusion that filtering on MSGT_AVSYNC + MSGL_STATUS should be enough to detect it. Yes, it's brittle, but should work. If you'd think it's a bad idea, then a new MGST_STAUSLINE should be created. And btw: -quiet does the same what you want, just better. Attila Kinali -- 心をこめて聞け心をこめて話せ
On Fri, May 18, 2007 at 10:14:08PM +0200, Attila Kinali wrote:
On Fri, 18 May 2007 16:57:44 +0200 Diego Biurrun <diego@biurrun.de> wrote:
Attila wanted it, I've been meaning to implement it for ages, here it is: A small option that turns off displaying of the status line. Useful if you wish to have full debug output but your terminal is slow or you wish to redirect output to a file without the status line crap.
I'm against it ;-)
As just explained on IRC, it's not about disabling the status line at all, but about being able to filter out the status line at the mp_msg() level. After a discussion with Uoti, we came to the conclusion that filtering on MSGT_AVSYNC + MSGL_STATUS should be enough to detect it. Yes, it's brittle, but should work. If you'd think it's a bad idea, then a new MGST_STAUSLINE should be created.
I don't much like that idea and I have wanted a way to disable the status line and nothing else for a long time.
And btw: -quiet does the same what you want, just better.
-quiet does more than that. Also, the semantics of that option are broken. MPlayer should output little or no messages with that option, there is no reason for -quiet to behave different than what you would expect from it. It is a hack that we have another option, -really-quiet, that works like -quiet should... Diego
participants (5)
-
Attila Kinali -
Diego Biurrun -
Dominik 'Rathann' Mierzejewski -
Ivan Kalvachev -
Oded Shimon