[PATCH] Improvement to help/help_diff.sh
A recent commit has revealed to me a small issue with help/help_diff.sh suppose one adds a line #define MSGTR_FOO "Sometext" to help/help_mp-en.h masterfile help_diff.sh is supposed to add this line to help_mp.h until someone syncs the translation, to make sure everything is defined properly. Unfortunatelly it fails to do so if the translation contains the line #define MSGTR_FOO2 "Sometekst" as it searches for '#define MSGTR_FOO' pattern and the second line matches this pattern. A small patch attached makes help_diff.sh match also space/tab terminating this pattern, fixing the issue. I'll apply in a few days if nobody objects. Torinthiel -- Waclaw "Torinthiel" Schiller GG#: 542916, 3073512 torinthiel(at)megapolis(dot)pl gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8 7346 2B6E 39F2 B069 01F1 "No classmates may be used during this examination"
Torinthiel writes:
A recent commit has revealed to me a small issue with help/help_diff.sh suppose one adds a line #define MSGTR_FOO "Sometext" to help/help_mp-en.h masterfile help_diff.sh is supposed to add this line to help_mp.h until someone syncs the translation, to make sure everything is defined properly. Unfortunatelly it fails to do so if the translation contains the line #define MSGTR_FOO2 "Sometekst" as it searches for '#define MSGTR_FOO' pattern and the second line matches this pattern. A small patch attached makes help_diff.sh match also space/tab terminating this pattern, fixing the issue.
Not to mention that it will fail to compile otherwise as it does currently with e.g. ./configure --language=de. Commit this! Diego
On Tue, Mar 01, 2005 at 06:38:06AM +0100, Diego Biurrun wrote:
Not to mention that it will fail to compile otherwise as it does currently with e.g. ./configure --language=de.
Or --language=pl. That's why I've noticed it ;)
Commit this! Done Torinthiel
-- Waclaw "Torinthiel" Schiller GG#: 542916, 3073512 torinthiel(at)megapolis(dot)pl gpg: B06901F1 fpr: FAA3 559F CAE9 34DE CDC8 7346 2B6E 39F2 B069 01F1 "No classmates may be used during this examination"
participants (2)
-
Diego Biurrun -
Torinthiel