[PATCH] standalone codec-cfg: remove mp_msg dependency
Hi, currently codec-cfg does not compile anymore on MinGW, because it uses mp_msg but does not link to libiconv. The attached patch removes the dependency to mp_msg.c, which I find the best solution. Okay to commit? Greetings, Reimar Döffinger
On Sat, Mar 11, 2006 at 10:10:23AM +0100, Reimar Döffinger wrote:
currently codec-cfg does not compile anymore on MinGW, because it uses mp_msg but does not link to libiconv. The attached patch removes the dependency to mp_msg.c, which I find the best solution. Okay to commit?
Why not simply link with iconv? Looks OK otherwise.. Diego
On 11-Mar-06, at 5:30 PM, Diego Biurrun wrote:
On Sat, Mar 11, 2006 at 10:10:23AM +0100, Reimar Döffinger wrote:
currently codec-cfg does not compile anymore on MinGW, because it uses mp_msg but does not link to libiconv. The attached patch removes the dependency to mp_msg.c, which I find the best solution. Okay to commit?
Why not simply link with iconv? Looks OK otherwise..
Same problem on osx. I just added $(ARCH_LIB) in Makefile to codec-cfg. ==== Nicolas Plourde <nicolas.plourde@gmail.com>
On Sat, Mar 11, 2006 at 08:56:57PM -0500, Nicolas Plourde wrote:
On 11-Mar-06, at 5:30 PM, Diego Biurrun wrote:
On Sat, Mar 11, 2006 at 10:10:23AM +0100, Reimar Döffinger wrote:
currently codec-cfg does not compile anymore on MinGW, because it uses mp_msg but does not link to libiconv. The attached patch removes the dependency to mp_msg.c, which I find the best solution. Okay to commit?
Why not simply link with iconv? Looks OK otherwise..
Same problem on osx. I just added $(ARCH_LIB) in Makefile to codec-cfg.
It seams the best solution, as side effect codec-cfg gets libpthread dep on linux, but who cares, codec-cfg it's only used in the building process. Also I suggest to add #include <string.h> to mp_msg.c since it could cause 64bit issues (like strftime if time.h is not included). Bye -- Gianluigi Tiesi <sherpya@netfarm.it> EDP Project Leader Netfarm S.r.l. - http://www.netfarm.it/ Free Software: http://oss.netfarm.it/
Hi, On Sat, Mar 11, 2006 at 11:30:54PM +0100, Diego Biurrun wrote:
On Sat, Mar 11, 2006 at 10:10:23AM +0100, Reimar Döffinger wrote:
currently codec-cfg does not compile anymore on MinGW, because it uses mp_msg but does not link to libiconv. The attached patch removes the dependency to mp_msg.c, which I find the best solution. Okay to commit?
Why not simply link with iconv? Looks OK otherwise..
Well, I think it might cause problems when cross-compiling and it will break each time mp_msg gets a new dependency. Greetings, Reimar Döffinger
Hi, On Sun, Mar 12, 2006 at 11:36:23AM +0100, Reimar D?ffinger wrote:
On Sat, Mar 11, 2006 at 11:30:54PM +0100, Diego Biurrun wrote:
On Sat, Mar 11, 2006 at 10:10:23AM +0100, Reimar Döffinger wrote:
currently codec-cfg does not compile anymore on MinGW, because it uses mp_msg but does not link to libiconv. The attached patch removes the dependency to mp_msg.c, which I find the best solution. Okay to commit?
Why not simply link with iconv? Looks OK otherwise..
Well, I think it might cause problems when cross-compiling and it will break each time mp_msg gets a new dependency.
Applied. Greetings, Reimar Döffinger
participants (4)
-
Diego Biurrun -
Gianluigi Tiesi -
Nicolas Plourde -
Reimar Döffinger