[PATCH] configure fontconfig fix
Hi, The attached patch makes fontconfig support available also on darwin/mac os x; the problem is that xft/fontconfig is available but there is no fontconfig.pc in /usr/lib/pkgconfig, so xft-config has to be used. It also adds the '--silence-errors' option to the pkg-config invocation, which avoids annoying text when there is no fontconfig.pc.
On Friday, 06 January 2006 at 17:34, Emanuele Giaquinta wrote:
Hi,
The attached patch makes fontconfig support available also on darwin/mac os x; the problem is that xft/fontconfig is available but there is no fontconfig.pc in /usr/lib/pkgconfig, so xft-config has to be used. It also adds the '--silence-errors' option to the pkg-config invocation, which avoids annoying text when there is no fontconfig.pc.
Looks good, but the --silence-errors part is cosmetic and unrelated, so please send the functional change separately and when it's applied, send the cosmetic one. Regards, R. -- MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/ "I am Grey. I stand between the candle and the star. We are Grey. We stand between the darkness ... and the light." -- Delenn in Grey Council in Babylon 5:"Babylon Squared"
Looks good, but the --silence-errors part is cosmetic and unrelated, so please send the functional change separately and when it's applied, send the cosmetic one.
Ok, here it is.
A better patch; the previous one had the side effect of linking to Xft. Diego, anyone?
On Sun, Jan 08, 2006 at 05:45:09PM +0100, Emanuele Giaquinta wrote:
A better patch; the previous one had the side effect of linking to Xft. Diego, anyone?
Hmmm...
--- configure 3 Jan 2006 16:03:17 -0000 1.1117 +++ configure 8 Jan 2006 16:43:19 -0000 @@ -5239,6 +5239,8 @@ _fontconfig=yes if cc_check -lfontconfig ; then _ld_fontconfig="-lfontconfig" + elif cc_check $_inc_x11 $_ld_x11 -lfontconfig ; then + _ld_fontconfig="-lfontconfig"
Why not simply add $_inc_x11 $_ld_x11 to the check above? Diego
On 1/8/06, Diego Biurrun <diego@biurrun.de> wrote:
Why not simply add $_inc_x11 $_ld_x11 to the check above?
I added another test to retain precedence on /usr{,local}/lib; anyway I don't like this either cause it doesn't work with '--disable-x11', since _inc_x11 and _ld_x11 are zeroed if _x11 is no. I have also found that fontconfig.pc exists in /usr/X11R6/lib/pkgconfig, so in the end the user has to install pkg-config and set PKG_CONFIG_PATH accordingly to be able to use fontconfig. Maybe I could add a note to the docs?
Stumbled over a really old patch .. On Mon, Jan 09, 2006 at 11:46:03AM +0100, Emanuele Giaquinta wrote:
On 1/8/06, Diego Biurrun <diego@biurrun.de> wrote:
Why not simply add $_inc_x11 $_ld_x11 to the check above?
I added another test to retain precedence on /usr{,local}/lib; anyway I don't like this either cause it doesn't work with '--disable-x11', since _inc_x11 and _ld_x11 are zeroed if _x11 is no. I have also found that fontconfig.pc exists in /usr/X11R6/lib/pkgconfig, so in the end the user has to install pkg-config and set PKG_CONFIG_PATH accordingly to be able to use fontconfig. Maybe I could add a note to the docs?
Yes, please do that. Diego
participants (3)
-
Diego Biurrun -
Dominik 'Rathann' Mierzejewski -
Emanuele Giaquinta