Re: [MPlayer-dev-eng] [PATCH] select audio/sub tracks based on 'default' attribute
Hi Evgeniy. I have problem with this patch, because it makes merged to mkv subtitles enabled by default. So, if one want watch video with external subtitles or without any at all, he must do additional work (by pressing some key). It is not problem, if there is opportunity to disable internal mkv subtitles completely, or set priority for subtitles (ext->int->none; none->ext->int) in configuration file. But it's impossible, thus I think – selection of internal subtitles must be disabled by default.
On Wednesday 30 April 2008 12:45:05 Sergey Malkovsky wrote:
Hi Evgeniy.
I have problem with this patch, because it makes merged to mkv subtitles enabled by default. So, if one want watch video with external subtitles or without any at all, he must do additional work (by pressing some key). It is not problem, if there is opportunity to disable internal mkv subtitles completely, or set priority for subtitles (ext->int->none; none->ext->int) in configuration file. But it's impossible, thus I think – selection of internal subtitles must be disabled by default.
I think the problem is not with 'default' tracks, but with subtitle selection method as a whole. For example, an -slang option will also select internal subs if there is no language info for external ones. And it is a kind of options that is usually present in config file. Having priorities would be good, there is even no need for an option, the following seems ok for most uses: external -> internal -> auto-external. It surely makes sense to display the subtitles user specified with -sub first. Alternatively, you could be able to select external subtitles with -sid, but it has been broken for a long time.
I think the problem is not with 'default' tracks, but with subtitle selection method as a whole.
Agreed.
Having priorities would be good, there is even no need for an option, the following seems ok for most uses: external -> internal -> auto-external. It surely makes sense to display the subtitles user specified with -sub first.
IMHO, highest priority must be set for external subtitles (chosen by -sub options). If there is no such option, player must show us auto-external subs (if there are any). And only after that player must check -slang option. If it presents and mkv file have subtitles with chosen language id, player must show chosen subtitles. Internal subtitles that have "default" mark must be at the least. In the current version of player "default" internal mkv subtitles have highest priority. I think - if user provides no any language id, or internal sub track language id is not equal to provided, player shouldn't show any "default" internal sub (or option to disable mkv subs at all must be added first).
On Wednesday 30 April 2008 16:52:47 Sergey Malkovsky wrote:
I think the problem is not with 'default' tracks, but with subtitle selection method as a whole.
Agreed.
Having priorities would be good, there is even no need for an option, the following seems ok for most uses: external -> internal -> auto-external. It surely makes sense to display the subtitles user specified with -sub first.
IMHO, highest priority must be set for external subtitles (chosen by -sub options). If there is no such option, player must show us auto-external subs (if there are any). And only after that player must check -slang option.
Sounds good. All external subtitles should probably go before internal ones, because it is usually user's decision to put them there (for auto- subs) or to add -sub option; while internal subtitles are a decision of some other, remote person and can not be easily removed.
If it presents and mkv file have subtitles with chosen language id, player must show chosen subtitles. Internal subtitles that have "default" mark must be at the least.
In the current version of player "default" internal mkv subtitles have highest priority.
I think - if user provides no any language id, or internal sub track language id is not equal to provided, player shouldn't show any "default" internal sub (or option to disable mkv subs at all must be added first).
Why? That's exactly what default track attribute is for: to select a track if no other criterion could be applied. Of course, it should be given minimal priority. To completely disable all subtitles one can use -nosub option.
Why? That's exactly what default track attribute is for: to select a track if no other criterion could be applied. Of course, it should be given minimal priority. To completely disable all subtitles one can use -nosub option.
Correct. But there is problem still: now default track has highest priority (after -slang and -sid options) and player selects it even if user provides -sub option, or some auto-found subs exist.
I've made patch that resolves problem, I've wrote earlier. It sets the lowest priority for default subtitle track. I'd like it to be committed.
On Friday 02 May 2008 10:09:04 Sergey Malkovsky wrote:
I've made patch that resolves problem, I've wrote earlier. It sets the lowest priority for default subtitle track. I'd like it to be committed.
Seems ok. I'll commit in a few days if nobody objects.
On Friday 02 May 2008 10:09:04 Sergey Malkovsky wrote:
I've made patch that resolves problem, I've wrote earlier. It sets the lowest priority for default subtitle track. I'd like it to be committed.
There was a minor problem with the patch, it could leave mpctx->global_sub_pos uninitialized if the (dvdsub_id>=0) condition fails. I've changed it to move also -slang to the end of subtitle selection order. It is now committed. Sorry that it took so long, I just forgot about it. :)
There was a minor problem with the patch, it could leave mpctx->global_sub_pos uninitialized if the (dvdsub_id>=0) condition fails. I've changed it to move also -slang to the end of subtitle selection order. It is now committed. Sorry that it took so long, I just forgot about it. :)
Never mind, it seems all is fine now. :)
participants (2)
-
Evgeniy Stepanov -
Sergey Malkovsky