Hi This is a small patch (quick hack) agains cvs. It makes posible to use -vo fbdev:vidix. Works at least for me. Could someone check it please Jacek
Hi,
+ if(zoom > 1 || fs) { aspect_save_orig(width,height); aspect_save_prescale(d_width,d_height); aspect_save_screenres(fb_xres,fb_yres); aspect(&image_width,&image_height,A_ZOOM); }
ok it was bad, and is still bad, i've fixed it will commit soon please someone test it... ok, now the reason of this mail... :) i've looked at Atmos' aspect() code, and found that its parameter xoom (A_ZOOM or A_NOZOOM) is a bit confusing - or at least i'm confused :) if i understood that code right, A_ZOOM means fullscreen and A_NOZOOM means d_width/d_height size. so, NOZOOM also zooms, but to the requested size instead of fullscreen... this way it should be named A_ZOOM and A_FULLSCREEN or so... right?
+#ifdef CONFIG_VIDIX + if(vidix_name) + return (vidix_query_fourcc(format)); +#endif
looks like a 10l bug :) A'rpi / Astral & ESP-team -- Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
On Tue, Jul 30, 2002 at 08:47:30PM +0200, Arpi wrote:
please someone test it...
i've checked it, works better ( -xy 2 -zoom does what it should now :) ) althought it seems like _only_ with -vo fbdev:vidix thanks Jacek
On Tuesday 30 July 2002 20:47, Arpi wrote:
+ if(zoom > 1 || fs) { aspect_save_orig(width,height); aspect_save_prescale(d_width,d_height); aspect_save_screenres(fb_xres,fb_yres); aspect(&image_width,&image_height,A_ZOOM); }
ok it was bad, and is still bad, i've fixed it will commit soon please someone test it...
ok, now the reason of this mail... :)
i've looked at Atmos' aspect() code, and found that its parameter xoom (A_ZOOM or A_NOZOOM) is a bit confusing - or at least i'm confused :)
if i understood that code right, A_ZOOM means fullscreen and A_NOZOOM means d_width/d_height size. so, NOZOOM also zooms, but to the requested size instead of fullscreen... this way it should be named A_ZOOM and A_FULLSCREEN or so... right? A_ZOOM means zoom to fullscreen while aspect correcting, A_NOZOOM means only aspect correct, but do not zoom to full screen area, eg. when displaying a movie on a 16:9 screen (-monitoraspect 16:9), A_NOZOOM would only scale the movie to still be 4:3, but A_ZOOM would additionally zoom it to full screen width or height (depending on what fits better). -- Best Regards, Atmos
- MPlayer Developer - http://mplayerhq.hu/ - ____________________________________________
participants (3)
-
Arpi -
Felix Buenemann -
Jacek Rembisz