[PATCH] [BUG] make install is broken for mplayer with non-english manual
Hello, r26355 brokes make install for mplayer manual if it is not in DOCS/en/, because of renaming $$i shell variable to $$lang only in the loop declaration. r26383 is an only partial fix for that: it does not replace *all* $$i to $$lang inside a loop (take a look at svn diff Makefile -r 26382:26383, I don't post it here). So make install failes on non-english manuals. The following patch fixes this:
A Friday 18 April 2008 00:25:41, Andrew Savchenko escreveu:
Hello,
r26355 brokes make install for mplayer manual if it is not in DOCS/en/, because of renaming $$i shell variable to $$lang only in the loop declaration.
r26383 is an only partial fix for that: it does not replace *all* $$i to $$lang inside a loop (take a look at svn diff Makefile -r 26382:26383, I don't post it here).
So make install failes on non-english manuals. The following patch fixes this:
I did reported this problem and did send 2 days ago the patch fixing that, dont know why wasnt commited so far but this was in user mailing list
On Fri, Apr 18, 2008 at 03:25:41AM +0400, Andrew Savchenko wrote:
r26355 brokes make install for mplayer manual if it is not in DOCS/en/, because of renaming $$i shell variable to $$lang only in the loop declaration.
r26383 is an only partial fix for that: it does not replace *all* $$i to $$lang inside a loop (take a look at svn diff Makefile -r 26382:26383, I don't post it here).
Yes, that one cost me a record amount of Cola...
So make install failes on non-english manuals. The following patch fixes this:
Patch applied, thanks. Diego
participants (3)
-
Andrew Savchenko -
Diego Biurrun -
Zé