[PATCH] Correct translation of filename
Currently, filenames like "Nice.Film.avi" get incorrectly translated to "Nice" instead of "Nice.Film".
On Tue, Dec 21, 2010 at 12:46:01AM +0100, Ingo Brueckl wrote:
Currently, filenames like "Nice.Film.avi" get incorrectly translated to "Nice" instead of "Nice.Film".
The idea of the code is to only cut 3 or 4 letter extensions, your change would e.g. cut This.IsSomething to This. Maybe not a big loss, but the more direct solution is to just add a "else" in front of the second if...
On Tue, Dec 21, 2010 at 09:10:57AM +0100, Reimar Döffinger wrote:
On Tue, Dec 21, 2010 at 12:46:01AM +0100, Ingo Brueckl wrote:
Currently, filenames like "Nice.Film.avi" get incorrectly translated to "Nice" instead of "Nice.Film".
The idea of the code is to only cut 3 or 4 letter extensions, your change would e.g. cut This.IsSomething to This. Maybe not a big loss, but the more direct solution is to just add a "else" in front of the second if...
I have to note that the current code does not correctly check the length and for short strings will access outside the array, so it might be better to go with you suggestion anyway. Either way, gmplayer is currently not maintained and we have been suggesting to everyone to use smplayer. On the other hand you seem quite motivated, if you are genuinly interested in improving the mess that the Gui code is, I'd be in favour of giving you commit access and relatively free reign over everything in gui/. If that suits you, read DOCS/tech/svn-howto.txt and ask Diego for username/password (since we might soonish switch to git and Diego is quite busy it might take some time for it all to work out and you might have to send a public key for use with git to someone else instead)...
Reimar Döffinger wrote on Tue, 21 Dec 2010 09:10:57 and 09:26:23 +0100:
The idea of the code is to only cut 3 or 4 letter extensions, your change would e.g. cut This.IsSomething to This.
Yeah, but what about files like something.au, something.ra or (possibly?) 5 letter extensions? I don't mind the current approach either, but as you noticed ...
I have to note that the current code does not correctly check the length and for short strings will access outside the array,
... there has to be a length check. (Alternative patch attached.)
we have been suggesting to everyone to use smplayer.
The problem with the GUIs mentioned on the web page is their depedencies. I'm currently using vlc and want to get rid of Qt (which is only installed for vlc). There is no small and simple but sufficient GUI which only needs gtk and nothing else - besides gmplayer, and I like it for that reason.
On the other hand you seem quite motivated, if you are genuinly interested in improving the mess that the Gui code is,
Yes, I'd like to fix a few things in it. For example, the fullscreen options reacts strangely and I'd like an option to quit it after playing. So there are patches to come.
I'd be in favour of giving you commit access and relatively free reign over everything in gui/. If that suits you, read DOCS/tech/svn-howto.txt and ask Diego for username/password (since we might soonish switch to git
It would, but I'd like to wait until git access is available, because I'm using git (public key available) and haven't used svn so far. (BTW, how will be the ok-to-commit procedure then?) Ingo
If nobody minds, I will commit my gui patches Correct translation of filename Allow gmplayer the use of non-UTF-8 filename encoding Allow double quote to be defined in font file Ingo
On Mon, Jan 17, 2011 at 01:32:12PM +0100, Ingo Brückl wrote:
If nobody minds, I will commit my gui patches
Correct translation of filename Allow gmplayer the use of non-UTF-8 filename encoding Allow double quote to be defined in font file
I don't specially care about the state of current GUI state, but could you share with us what are your objectives about it? I think most people would like to know if you plane to improve the slave mode and make a new or use an existing front-end; what's your conclusion about gnome-mplayer? I remember there were some discussions about dbus recently. Regards, (BTW, if you want review for your patches, you should attach them) -- Clément B.
Clément Boesch wrote on Mon, 17 Jan 2011 13:47:13 +0100:
I don't specially care about the state of current GUI state, but could you share with us what are your objectives about it?
I thought I already did in my previous postings (please see compn on Fri, 24 Dec 2010 17:41:13 -0500 as well): I'd like to fix a few things in it. For example, the fullscreen option reacts strangely and I'd like an option to quit it after playing. [...] I wouldn't mind gmplayer not being part of mplayer, but I'd like to preserve a simple but powerful gtk-only based gui like this. [...] For the time being, d. (keep gui - mostly as is) would be easiest, but b. plus c. (either gmplayer part of mplayer or a stand-alone gui) sounds good, [...] My first goal is to entirely understand how gmplayer works with / is integrated into MPlayer and to improve it a little bit by doing this.
I think most people would like to know if you plane to improve the slave mode
My plan is to remove (but not to throw away) gmplayer by improving the slave mode so that the removed gmplayer and other GUIs as well will have the same power as gmplayer now. This, of course, only after I have understood the relationship between MPlayer and gmplayer good enough.
and make a new or use an existing front-end;
For the moment, I go with skins which suit sufficiently.
what's your conclusion about gnome-mplayer?
Seems to be quite a good GUI but can't it get run and don't have the time to investigate as I'm happy with skins for my purposes.
(BTW, if you want review for your patches, you should attach them)
I already posted them. The respective last posting of each patch is going to be committed. (These are the ones where discussions and suggestions ended, so I think they should be ok.) Ingo
On Mon, Jan 17, 2011 at 03:30:51PM +0100, Ingo Brückl wrote:
Clément Boesch wrote on Mon, 17 Jan 2011 13:47:13 +0100:
I don't specially care about the state of current GUI state, but could you share with us what are your objectives about it?
I thought I already did in my previous postings (please see compn on Fri, 24 Dec 2010 17:41:13 -0500 as well):
I'd like to fix a few things in it. For example, the fullscreen option reacts strangely and I'd like an option to quit it after playing. [...] I wouldn't mind gmplayer not being part of mplayer, but I'd like to preserve a simple but powerful gtk-only based gui like this. [...] For the time being, d. (keep gui - mostly as is) would be easiest, but b. plus c. (either gmplayer part of mplayer or a stand-alone gui) sounds good, [...] My first goal is to entirely understand how gmplayer works with / is integrated into MPlayer and to improve it a little bit by doing this.
I think most people would like to know if you plane to improve the slave mode
My plan is to remove (but not to throw away) gmplayer by improving the slave mode so that the removed gmplayer and other GUIs as well will have the same power as gmplayer now. This, of course, only after I have understood the relationship between MPlayer and gmplayer good enough.
and make a new or use an existing front-end;
For the moment, I go with skins which suit sufficiently.
what's your conclusion about gnome-mplayer?
Seems to be quite a good GUI but can't it get run and don't have the time to investigate as I'm happy with skins for my purposes.
(BTW, if you want review for your patches, you should attach them)
I already posted them. The respective last posting of each patch is going to be committed. (These are the ones where discussions and suggestions ended, so I think they should be ok.)
OK, thanks for the summary, I indeed missed a few mails (or forget them). -- Clément B.
participants (4)
-
Clément Bœsch -
Ingo Brueckl -
Ingo Brückl
-
Reimar Döffinger