On Tue, Nov 18, 2008 at 05:41:04PM +0200, Georgi Petrov wrote:

Ok, I'll include them.

No, that's not how it works. You are the maintainer, so I won't make "significant" changes without asking you. There are three "basic" choices you have: 1) Say "no, that patch is not acceptable", optionally "but if you change this and that it is ok". 2) Say "ok, go ahead and apply it" 3) Say "I'll take care of it and send a patch for that issue I like better" Particularly "including" sounds like you would like to combine it with other patches - that is not okay, one patch should only "fix" one issue (yes, what exactly constitues one issue is never completely clear, but there is no way it would be okay to apply this patch e.g. together with one that fixes panscan - if this is not clear to you please re-read patches.txt and svn-howto.txt and tell us what is unnclear in them). Greetings, Reimar Döffinger

On Wed, Nov 19, 2008 at 02:34:40PM +0200, Georgi Petrov wrote:

Thanks Reimar, I'm sorry you have to teach me such basics. I commit myself to learn fast. I'll try to apply different features/changes as different patches as well!

While there are some hints about it in the tech docs I did not expect you to know the process, helping teach it was another of the reasons for sending this patch. And we were all new here once, even if we have forgotten about it by now ;-)

So, my reply for "[PATCH] vo_direct3d: simplify several conditions" is "ok, go ahead and apply it" :)

Good, patch applied. Greetings, Reimar Döffinger