I just cleaned up mp_msg a little, just about only modified it so it uses 2 parameters instead of 1, and still use a tiny little less ram than the previous implementation (umm, was that the reason for the original very bizarre implementation? its the only reason i could think of.). - ods15
On Sat, Oct 30, 2004 at 08:33:09PM +0200, Oded Shimon wrote:
I just cleaned up mp_msg a little, just about only modified it so it uses 2 parameters instead of 1, and still use a tiny little less ram than the previous implementation (umm, was that the reason for the original very bizarre implementation? its the only reason i could think of.).
no, there was no good reason. and having args of type other than int is bad (slower, declaration issues) so make them int. rich
On Sunday 31 October 2004 00:13, D Richard Felker III wrote:
On Sat, Oct 30, 2004 at 08:33:09PM +0200, Oded Shimon wrote:
I just cleaned up mp_msg a little, just about only modified it so it uses 2 parameters instead of 1, and still use a tiny little less ram than the previous implementation (umm, was that the reason for the original very bizarre implementation? its the only reason i could think of.).
no, there was no good reason. and having args of type other than int is bad (slower, declaration issues) so make them int.
done. - ods15
On Sun, 31 Oct 2004 00:18:44 +0200, Oded Shimon <ods15@ods15.dyndns.org> wrote:
On Sunday 31 October 2004 00:13, D Richard Felker III wrote:
On Sat, Oct 30, 2004 at 08:33:09PM +0200, Oded Shimon wrote:
I just cleaned up mp_msg a little, just about only modified it so it uses 2 parameters instead of 1, and still use a tiny little less ram than the previous implementation (umm, was that the reason for the original very bizarre implementation? its the only reason i could think of.).
no, there was no good reason. and having args of type other than int is bad (slower, declaration issues) so make them int.
done.
Ok, you clean up, I clean up :) just saw that it was still some double typings, one for that, and one for thot.
On Sun, Oct 31, 2004 at 01:49:08AM +0200, Carl F?rstenberg wrote:
Ok, you clean up, I clean up :) just saw that it was still some double typings, one for that, and one for thot.
What about this patch? It still applies, with some offsets. Torinthiel -- Waclaw "Torinthiel" Schiller GG#: 542916, 3073512 torinthiel(at)megapolis(dot)pl gpg: 0906A2CE fpr: EE3E DFB4 C4D6 E22E 8999 D714 7CEB CDDC 0906 A2CE "No classmates may be used during this examination"
On Fri, Jul 22, 2005 at 09:25:09PM +0200, Torinthiel wrote:
On Sun, Oct 31, 2004 at 01:49:08AM +0200, Carl F?rstenberg wrote:
Ok, you clean up, I clean up :) just saw that it was still some double typings, one for that, and one for thot.
What about this patch? It still applies, with some offsets.
Rich, you commented on it, can you review it? Oded, you could do that, too, it's your patch originally, just get Rich to check it on IRC. Diego
participants (5)
-
Carl Fûrstenberg -
D Richard Felker III -
Diego Biurrun -
Oded Shimon -
Torinthiel