Re: [MPlayer-dev-eng] [PATCH] frameno file
On Thursday, 03 March 2005 at 00:37, Olivier Rolland wrote:
Hey,
This patch adds a -framenofile option to mencoder to specify the audio only input file (frameno) for the 2nd and 3rd pass in 3-passes encoding mode. It also disables the default frameno.avi file.
Rejected, because: - indentation changes are strictly forbidden - default behaviour changes have to be well-motivated and gradual - calling it three-pass is confusing in light of vpass=3 R. -- MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/ "I am Grey. I stand between the candle and the star. We are Grey. We stand between the darkness ... and the light." -- Delenn in Grey Council in Babylon 5:"Babylon Squared"
On Thu, Mar 03, 2005 at 02:05:27AM +0100, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 03 March 2005 at 00:37, Olivier Rolland wrote:
Hey,
This patch adds a -framenofile option to mencoder to specify the audio only input file (frameno) for the 2nd and 3rd pass in 3-passes encoding mode. It also disables the default frameno.avi file.
Rejected, because: - indentation changes are strictly forbidden - default behaviour changes have to be well-motivated and gradual - calling it three-pass is confusing in light of vpass=3
R.
I agree with reasons 1 and 3, but not reason 2. The existing behavior is very stupid (if you happen to have a frameno.avi file around it will screw up mencoder like crazy), and this frameno pre-pass stuff should be phased out anyway. It's already been removed or marked deprecated in the docs, iirc, so it's totally acceptable to change how it works, or even remove it altogether imo.. Rich
On Thursday, 03 March 2005 at 02:19, D Richard Felker III wrote:
On Thu, Mar 03, 2005 at 02:05:27AM +0100, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 03 March 2005 at 00:37, Olivier Rolland wrote:
Hey,
This patch adds a -framenofile option to mencoder to specify the audio only input file (frameno) for the 2nd and 3rd pass in 3-passes encoding mode. It also disables the default frameno.avi file.
Rejected, because: - indentation changes are strictly forbidden - default behaviour changes have to be well-motivated and gradual - calling it three-pass is confusing in light of vpass=3
R.
I agree with reasons 1 and 3, but not reason 2. The existing behavior is very stupid (if you happen to have a frameno.avi file around it will screw up mencoder like crazy), and this frameno pre-pass stuff should be phased out anyway.
Stupid or not, this has been the behaviour of mencoder for ages, but...
It's already been removed or marked deprecated in the docs, iirc, so it's totally acceptable to change how it works, or even remove it altogether imo..
... as you say, it's been removed from the docs, so - essentially - I agree. R. -- MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/ "I am Grey. I stand between the candle and the star. We are Grey. We stand between the darkness ... and the light." -- Delenn in Grey Council in Babylon 5:"Babylon Squared"
Hey,
Stupid or not, this has been the behaviour of mencoder for ages, but...
LOL! As if THAT had been a reason in the last couple of weeks... Like the '-aofile' removal. Which breaks most frontends that use mplayer for audio extraction. Mosu -- If Darl McBride was in charge, he'd probably make marriage unconstitutional too, since clearly it de-emphasizes the commercial nature of normal human interaction, and probably is a major impediment to the commercial growth of prostitution. - Linus Torvalds
On Thursday 03 March 2005 03:19, D Richard Felker III wrote:
I agree with reasons 1 and 3, but not reason 2. The existing behavior is very stupid (if you happen to have a frameno.avi file around it will screw up mencoder like crazy), and this frameno pre-pass stuff should be phased out anyway. It's already been removed or marked deprecated in the docs, iirc, so it's totally acceptable to change how it works, or even remove it altogether imo..
I agree too... Till a while ago I really had no clue what that frameno.avi is for (it's completely undocumented, I figured it out from foriegn language docs)... I thought it was a default input file or something... And even now that I see what it's for, I find it kinda silly, because you can still use -audio-file or something like that, I don't see the need for this frameno.avi (not to mention, I'm not sure how it works out with my multiple file.. I didn't test it because I don't understand it...) - ods15
On Thu, Mar 03, 2005 at 01:42:37PM +0200, Oded Shimon wrote:
On Thursday 03 March 2005 03:19, D Richard Felker III wrote:
I agree with reasons 1 and 3, but not reason 2. The existing behavior is very stupid (if you happen to have a frameno.avi file around it will screw up mencoder like crazy), and this frameno pre-pass stuff should be phased out anyway. It's already been removed or marked deprecated in the docs, iirc, so it's totally acceptable to change how it works, or even remove it altogether imo..
I agree too... Till a while ago I really had no clue what that frameno.avi is for (it's completely undocumented, I figured it out from foriegn language docs)... I thought it was a default input file or something... And even now that I see what it's for, I find it kinda silly, because you can still use -audio-file or something like that, I don't see the need for this frameno.avi (not to mention, I'm not sure how it works out with my multiple file.. I didn't test it because I don't understand it...)
No, frameno is totally different from -audiofile. The way it works is you generate an avi file with audio and frame skip/dup control during a prepass, then encode the video in two following passes once you know the audio size and a/v sync. The problem is that this prepass doesn't even decode video, so it can't possibly know the correct skipping or duplication to do!! If you use no filters it's normally mostly right (but there are still some exceptional cases where it can be wrong), but lots of users just used it to encode audio first so they'd know how many bits were left for video, and then of course they generated broken files when they tried to use inverse telecine, etc. Rich
On Thu, Mar 03, 2005 at 02:05:27AM +0100, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 03 March 2005 at 00:37, Olivier Rolland wrote:
This patch adds a -framenofile option to mencoder to specify the audio only input file (frameno) for the 2nd and 3rd pass in 3-passes encoding mode. It also disables the default frameno.avi file.
Rejected, because: - indentation changes are strictly forbidden
Where do you see indentation changes in that patch? Diego
On Thursday, 03 March 2005 at 05:36, Diego Biurrun wrote:
On Thu, Mar 03, 2005 at 02:05:27AM +0100, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 03 March 2005 at 00:37, Olivier Rolland wrote:
This patch adds a -framenofile option to mencoder to specify the audio only input file (frameno) for the 2nd and 3rd pass in 3-passes encoding mode. It also disables the default frameno.avi file.
Rejected, because: - indentation changes are strictly forbidden
Where do you see indentation changes in that patch?
mencoder.c, the hunk starting with @@ -449,14 +449,6 @@. R. -- MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/ "I am Grey. I stand between the candle and the star. We are Grey. We stand between the darkness ... and the light." -- Delenn in Grey Council in Babylon 5:"Babylon Squared"
Le 03.03.2005 14:56:50, Dominik 'Rathann' Mierzejewski a écrit :
On Thursday, 03 March 2005 at 05:36, Diego Biurrun wrote:
mencoder.c, the hunk starting with @@ -449,14 +449,6 @@.
You should have missed the + if(framenofile){ + ... + } which is not in the original file. Greetings, Olivier
Hi, On Thu, Mar 03, 2005 at 02:56:50PM +0100, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 03 March 2005 at 05:36, Diego Biurrun wrote:
Where do you see indentation changes in that patch?
mencoder.c, the hunk starting with @@ -449,14 +449,6 @@.
This part will always appear in the diff, whether indentation is changed or not, so at least I don't mind it... Greetings, Reimar Döffinger
On Friday, 04 March 2005 at 12:17, Reimar Döffinger wrote:
Hi, On Thu, Mar 03, 2005 at 02:56:50PM +0100, Dominik 'Rathann' Mierzejewski wrote:
On Thursday, 03 March 2005 at 05:36, Diego Biurrun wrote:
Where do you see indentation changes in that patch?
mencoder.c, the hunk starting with @@ -449,14 +449,6 @@.
This part will always appear in the diff, whether indentation is changed or not, so at least I don't mind it...
Indeed, I haven't noticed that block was actually being moved. R. -- MPlayer RPMs maintainer: http://rpm.greysector.net/mplayer/ "I am Grey. I stand between the candle and the star. We are Grey. We stand between the darkness ... and the light." -- Delenn in Grey Council in Babylon 5:"Babylon Squared"
participants (7)
-
D Richard Felker III -
Diego Biurrun -
Dominik 'Rathann' Mierzejewski -
Moritz Bunkus -
Oded Shimon -
Olivier Rolland -
Reimar Döffinger