On Mon, Mar 20, 2006 at 06:50:29PM +0100, Diego Biurrun wrote:
On Mon, Mar 20, 2006 at 01:08:41PM +0100, Emanuele Giaquinta wrote:
On 3/20/06, Diego Biurrun <diego@biurrun.de> wrote:
You have removed some of the modification notices from the file headers. This is wrong, please update your patch.
Can't I just add, with a patch on top of the former two and only to the files modified in libdvdread_changes.diff, the header below?
* Modified for use with MPlayer, changes contained in libdvdread_changes.diff. * detailed CVS changelog at http://www.mplayerhq.hu/cgi-bin/cvsweb.cgi/main/
I don't see why you need to remove it in the first place. Let's try to keep diff pollution to a minimum.
Small nit about the patch: You forgot to bump the libdvdread version number in FILES.
I think we should try to benchmark this. I'm not sure what the best way to benchmark a demuxer is, though. Will something like mplayer -benchmark -vo null -ao pcm:file=/dev/null do the trick? Diego