On Sunday, 23 January 2005 at 18:06, D Richard Felker III wrote:
On Sun, Jan 23, 2005 at 05:33:57PM +0100, Csillag Kristof wrote: [...]
Basically, the problem is that aspect ratio is not passed to the OSD level by the VO drivers; every function call exported from the OSD level only takes two parameters, width and height, and because the VO drivers can do rescaling (like Xv), we can not calculate the aspect from this.
* * *
If we want to render OSD elements (both text subtitles and VOBsub subtitles) with correct aspect rate, we must get the necessary information from the VO drivers.
So, we have to opinions:
1. To modify every OSD call in every VO driver, to include this one extra parameter besides the width and the height. (~70 lines.) [...] I vote for option 1. MPlayer already has too many bad hacks with global vars.
Does this mean that after that, we can have a working -vf autoexpand=aspect=4/3 that will add black borders to fit the movie within the specified AR without the VO rescaling it to whatever it sees fit? R. -- MPlayer RPMs maintainer: http://greysector.rangers.eu.org/mplayer/ "I am Grey. I stand between the candle and the star. We are Grey. We stand between the darkness ... and the light." -- Delenn in Grey Council in Babylon 5:"Babylon Squared"