Hi, On 5/10/05, Reimar Döffinger <Reimar.Doeffinger@stud.uni-karlsruhe.de> wrote:
Hi, On Wed, Mar 02, 2005 at 12:07:11PM +0100, Reimar D?ffinger wrote:
Another update - unfortunately there still is an naming clash between the random_int functions in libfaad2 and libmusepack - so MPlayer won't compile with gcc 3.3.x when you use both - with gcc 3.4.x it compiles but crashes when you use libfaad2 :-(
The naming clash seems to be fixed in the latest version of the lib. The attached patch uses it. Even though seeking is still completely broken, I would like to apply it soon (since I don't intend to fix it any time soon, like this others can improve on it more easily). Is that okay with you? Aynthing you dislike about this patch?
As I don't quite see how I may comment on your code given my limited skills, I'd like to test it on both AMD-64 and i386 and report "evident" problems, like segfaults and horrible things like that. Is your patch "only" supposed to support _decoding_ of Musepack audio files and Musepack-in-AVI ? (meaning that MEncoder won't generate a proper AVI movie file if I use an external Musepack file as the audio track). Is the decoding of Matroska movie files also supposed to work with a Musepack audio track? Anyway, even though I never used Musepack, I'm happy to see that MPlayer will feature some kind of support for it, as our users have been looking forward to it. Regards, Guillaume