On Tue, Dec 21, 2010 at 09:10:57AM +0100, Reimar Döffinger wrote:
On Tue, Dec 21, 2010 at 12:46:01AM +0100, Ingo Brueckl wrote:
Currently, filenames like "Nice.Film.avi" get incorrectly translated to "Nice" instead of "Nice.Film".
The idea of the code is to only cut 3 or 4 letter extensions, your change would e.g. cut This.IsSomething to This. Maybe not a big loss, but the more direct solution is to just add a "else" in front of the second if...
I have to note that the current code does not correctly check the length and for short strings will access outside the array, so it might be better to go with you suggestion anyway. Either way, gmplayer is currently not maintained and we have been suggesting to everyone to use smplayer. On the other hand you seem quite motivated, if you are genuinly interested in improving the mess that the Gui code is, I'd be in favour of giving you commit access and relatively free reign over everything in gui/. If that suits you, read DOCS/tech/svn-howto.txt and ask Diego for username/password (since we might soonish switch to git and Diego is quite busy it might take some time for it all to work out and you might have to send a public key for use with git to someone else instead)...