On Thu, Apr 27, 2006 at 06:20:51PM +0200, Reimar Doeffinger wrote:
On Thu, Apr 27, 2006 at 05:30:18PM +0200, Piotr Kaczuba wrote:
Below the forth revision of my patch. I've made the following changes:
1. Make HAVE_DBUS_GLIB actually appear in config.h 2. Move gnome_screensaver.o rule from config.mak to Makefile 3. Run autodetection in configure only if _dbus_glib = auto 4. Replace g_print/g_printerr with mp_msg in gnome_screensaver.c
I personally would very much like to see is either: 1) a really good explanation why this is _necessary_, and why this shouldn't be fixed by the gnome people instead or: 2) at least 50% reduction in code size.
IMHO, this is necessary, because as it is now, the screensaver *will* kick in, unless the user disables it *and* the power management each time, before running mplayer to watch a full time movie and after that reenables both. This isn't acceptable. Of course, you can wait one month, half a year or longer until the gnome people implement e.g. the X screensaver extension. But then again, why does mplayer has Xscreensaver and KDE screensaver support? Gnome_screensaver.c consists of two functions, which both basically call another three functions. How is this too much code? How would you reduce it by 50%? Piotr