Hello, On Sat, Jan 13, 2007 at 01:06:27PM +0100, Diego Biurrun wrote:
On Sat, Jan 13, 2007 at 12:41:13PM +0100, Diego Biurrun wrote:
On Sat, Jan 13, 2007 at 11:56:21AM +0100, Reimar Döffinger wrote:
On Sat, Jan 13, 2007 at 10:38:20AM +0100, Diego Biurrun wrote:
On Sat, Jan 13, 2007 at 10:32:08AM +0100, Reimar Döffinger wrote:
Since this code needs an overhaul anyway, I'm for applying my patch first.
If you are willing to clean it up and merge this patch I'll be delighted, but if you just want to commit some cleanup and not merge this patch I'd be unhappy. This adds support for many unsupported files that otherwise crash MPlayer ...
Since the code IMO is not okay for inclusion as it is I don't see much difference if my patch is applied or not. Also if there are crashes, esp. if we do not know where and why they should be fixed before adding loads of features.
Here are two files that crash:
http://samples.mplayerhq.hu/GIF/2c-button_green_blue2.gif http://samples.mplayerhq.hu/GIF/2c_button-yellow_red.gif
The crashes are gone, thanks a bundle.
Here are some examples of files that currently play incorrectly but work fine with John's patch:
http://samples.mplayerhq.hu/GIF/3d_book2.gif http://samples.mplayerhq.hu/GIF/3D.gif http://samples.mplayerhq.hu/GIF/7up.gif http://samples.mplayerhq.hu/GIF/artists.gif
I just downloaded the whole directory before starting anyway. They all look okay to me, though I think there are no files that use what I called "refmode" 2. Also many seem to have transparency set without actually making use of it, what a waste... Greetings, Reimar Döffinger