D Richard Felker III wrote:
I still have two doubts. 1) at the moment telecining is applied to frames in decoding order: to me it seems natural to apply it to frames in display order, or is it wrong?
Yes...this is a major problem, dammit. I've said it 1000 times it feels like, but I'll say once again: I FUCKING HATE B FRAMES!!!!!!!
Whoever came up with such idiocy should be tied to heavy rocks and thrown into a huge vat of cola!!
should be fixed in cvs, as long as there are no more than 4 consecutive b-frames. Unfortunately it's not always possible to determine a wrap-around, because some idiot decoded that the gop header (0x18b) is optional, so there is a hack in the video parser. I removed telecine2 and left only telecine that sets progressive frame and unsets progressive sequence
2) actually timestamps are not modified after telecining, but wouldn't the player get momentarily out of sync in the course of a second (although the user might not nitice)? Should I recalculate frame duration and pts after telecining?
Perhaps. MPEG pts handling is really broken and I don't understand it, so I'll leave it up to you or someone else to figure it out. If you can find an easy way to do it, it probably should be done.
Rich
to make things perfect pts shall be recalculated. This is next step