On Sat, 1 Apr 2006 02:09:32 +0400 "Evgeniy Stepanov" <eugeni.stepanov@gmail.com> wrote:
Here is an attempt to add ASS rendering capability to mplayer. It is designed as a filter and supports a large part of ASS so-called specification. Reads both external subtitles and the ones embedded in matroska.
The patch also adds attachment support to matroska demuxer, as it was needed to extract fonts that usually come with subtitles.
Usage is -vf ass for mkv subs and -vf ass=<filename> for external.
I just had a short look at it and a few things came to my mind: 1) would it be possible to make this more general to handle other subtitles too? Then we could get rid of the current subtitle mess. 2) The filter can just handle YV12, which is bad, it should at least be able to handle the most comon YUV formats. 3) i'd put the subtitle code into its own directory than poluting libmpcodecs which already has too many files. 4) Had you have a look at vf_expand.c ? it does partially the same as you do. 5) would you be willing to take over the maintenance of the subtitle code?
I tried to change as little as possible in the surrounding code, but still had to add some bad looking lines to mplayer.c and mencoder.c to pass current time and subtitle track to the filter. If there is better way to do it, i'd be glad to hear about it :)
Bug Rich, either here on the ML or on IRC. He can explain you all the quirks of the vf system and how time is passed trough mplayer. Attila Kinali -- 心をこめて聞け心をこめて話せ