September 2024 - MPlayer-dev-eng

[PATCH] update the MIME type list in desktop file
by Lorenzo 19 Nov '24

19 Nov '24

Hello, Debian ships a desktop file with an updated list of MIME types; the list was derived from VLC but I cross check it against the list of SMplayer and they are roughly equivalent. Please consider to apply upstream, patch is attached Thanks, Lorenzo

2 1

[PATCH] Secure IPC perms
by Wladmis 19 Nov '24

19 Nov '24

From: "Vladimir D. Seleznev" <vseleznv(a)altlinux.org> shmget(2) is not subject of umask(2), so it's better to use more proper perms for it. --- MPlayer/gui/wm/ws.c | 2 +- MPlayer/libvo/vo_x11.c | 2 +- MPlayer/libvo/vo_xv.c | 2 +- MPlayer/libvo/vo_xvmc.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MPlayer/gui/wm/ws.c b/MPlayer/gui/wm/ws.c index b211db5959..474154fc3c 100644 --- a/MPlayer/gui/wm/ws.c +++ b/MPlayer/gui/wm/ws.c @@ -1357,7 +1357,7 @@ void wsImageCreate(wsWindow *win, int w, int h) mplayer(MPLAYER_EXIT_GUI, EXIT_ERROR, 0); } - win->Shminfo.shmid = shmget(IPC_PRIVATE, win->xImage->bytes_per_line * win->xImage->height, IPC_CREAT | 0777); + win->Shminfo.shmid = shmget(IPC_PRIVATE, win->xImage->bytes_per_line * win->xImage->height, IPC_CREAT | 0600); if (win->Shminfo.shmid < 0) { XDestroyImage(win->xImage); diff --git a/MPlayer/libvo/vo_x11.c b/MPlayer/libvo/vo_x11.c index 58e1762de7..6b81980023 100644 --- a/MPlayer/libvo/vo_x11.c +++ b/MPlayer/libvo/vo_x11.c @@ -150,7 +150,7 @@ static void getMyXImage(void) } Shminfo[0].shmid = shmget(IPC_PRIVATE, myximage->bytes_per_line * - myximage->height, IPC_CREAT | 0777); + myximage->height, IPC_CREAT | 0600); if (Shminfo[0].shmid < 0) { XDestroyImage(myximage); diff --git a/MPlayer/libvo/vo_xv.c b/MPlayer/libvo/vo_xv.c index ebc1dbb23d..a3ec393e16 100644 --- a/MPlayer/libvo/vo_xv.c +++ b/MPlayer/libvo/vo_xv.c @@ -279,7 +279,7 @@ static void allocate_xvimage(int foo) &Shminfo[foo]); Shminfo[foo].shmid = - shmget(IPC_PRIVATE, xvimage[foo]->data_size, IPC_CREAT | 0777); + shmget(IPC_PRIVATE, xvimage[foo]->data_size, IPC_CREAT | 0600); Shminfo[foo].shmaddr = (char *) shmat(Shminfo[foo].shmid, 0, 0); Shminfo[foo].readOnly = False; diff --git a/MPlayer/libvo/vo_xvmc.c b/MPlayer/libvo/vo_xvmc.c index 48f3ede440..31104f4dd4 100644 --- a/MPlayer/libvo/vo_xvmc.c +++ b/MPlayer/libvo/vo_xvmc.c @@ -203,7 +203,7 @@ static int allocate_xvimage(int xvimage_width,int xvimage_height,int xv_format) if (!xvimage->data_size) goto shmgetfail; - Shminfo.shmid = shmget(IPC_PRIVATE, xvimage->data_size, IPC_CREAT | 0777); + Shminfo.shmid = shmget(IPC_PRIVATE, xvimage->data_size, IPC_CREAT | 0600); if (Shminfo.shmid == -1) goto shmgetfail; Shminfo.shmaddr = (char *) shmat(Shminfo.shmid, 0, 0); -- 2.33.7

3 2

[OS/2] ao fixes due to switch from AVFifoBuffer to AVFifi
by Dave Yeo 01 Oct '24

01 Oct '24

Hi, this diff is needed to fix compilation on OS/2. Based on the changes to ao_sdl, http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/2024-April/047665.html The other problem I'm not sure how to fix is that the configure check for extern_prefix fails to find the _ prefix due to nm not understanding LX executables. Ideas besides hacking the script? Dave

4 12

[PATCH] Adapts to -std=c11 on OS/2
by KO Myung-Hun 01 Oct '24

01 Oct '24

-std=c11 disables many extensions of OS/2 kLIBC. And this causes many compilation errors such as implicit functions. To enable extensions of OS/2 kLIBC, define _EMX_SOURCE before including any headers. --- libao2/ao_dart.c | 3 +++ libao2/ao_kai.c | 3 +++ libvo/vo_kva.c | 3 +++ stream/cache2.c | 6 ++++++ 4 files changed, 15 insertions(+) diff --git a/libao2/ao_dart.c b/libao2/ao_dart.c index e1df7d32f..bd8ae6cf9 100644 --- a/libao2/ao_dart.c +++ b/libao2/ao_dart.c @@ -20,6 +20,9 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ +// Define to enable extensions of OS/2 kLIBC such as _control87() stuffs. +#define _EMX_SOURCE + #define INCL_DOS #define INCL_DOSERRORS #include <os2.h> diff --git a/libao2/ao_kai.c b/libao2/ao_kai.c index 3cf84b77e..2a3eff5b0 100644 --- a/libao2/ao_kai.c +++ b/libao2/ao_kai.c @@ -20,6 +20,9 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ +// Define to enable extensions of OS/2 kLIBC such as _control87() stuffs. +#define _EMX_SOURCE + #define INCL_DOS #define INCL_DOSERRORS #include <os2.h> diff --git a/libvo/vo_kva.c b/libvo/vo_kva.c index 42b273dd7..8d327fd88 100644 --- a/libvo/vo_kva.c +++ b/libvo/vo_kva.c @@ -20,6 +20,9 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ +// Define to enable extensions of OS/2 kLIBC such as _control87() stuffs. +#define _EMX_SOURCE + #define INCL_WIN #define INCL_GPI #define INCL_DOS diff --git a/stream/cache2.c b/stream/cache2.c index 3ec2732a7..60cc2653a 100644 --- a/stream/cache2.c +++ b/stream/cache2.c @@ -16,6 +16,12 @@ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. */ +#ifdef __OS2__ +// Define to enable extensions of OS/2 kLIBC such as _beginthread() and +// _endthread(). +#define _EMX_SOURCE +#endif + #include "config.h" // Initial draft of my new cache system... -- 2.42.0

3 5

[PATCH] osdep/mmap.h: define MAP_FAILED if necessary
by KO Myung-Hun 30 Sep '24

30 Sep '24

If sys/mman.h defines MAP_FAILED, config.h will not define MAP_FAILED. In this case, MAP_FAILED is not defined at all and compilation errors occur. --- osdep/mmap.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/osdep/mmap.h b/osdep/mmap.h index db7c136a9..9bd1b9e4b 100644 --- a/osdep/mmap.h +++ b/osdep/mmap.h @@ -46,7 +46,9 @@ */ #define MAP_ANON 0x1000 /* allocated from memory, swap space */ -/* MAP_FAILED is defined in config.h */ +#ifndef MAP_FAILED +#define MAP_FAILED ((void *) -1) +#endif #ifndef _MMAP_DECLARED #define _MMAP_DECLARED -- 2.42.0

2 1

[PATCH] Try to adapt to recent compilers such as GCC 14
by KO Myung-Hun 28 Sep '24

28 Sep '24

Recent compilers such as GCC 14 generate errors for implicit casts. --- libmpcodecs/vd_qtvideo.c | 2 +- libvo/vo_kva.c | 4 ++-- loader/afl.c | 2 +- loader/dshow/DS_Filter.c | 4 ++-- loader/dshow/DS_VideoDecoder.c | 4 ++-- loader/dshow/graph.c | 16 ++++++++-------- loader/ext.c | 2 +- loader/module.c | 4 ++-- loader/win32.c | 21 +++++++++++---------- mp_msg.c | 4 ++-- stream/asf_mmst_streaming.c | 2 +- sub/font_load_ft.c | 2 +- sub/subreader.c | 2 +- 13 files changed, 35 insertions(+), 34 deletions(-) diff --git a/libmpcodecs/vd_qtvideo.c b/libmpcodecs/vd_qtvideo.c index d3dbeacc4..5e37ca456 100644 --- a/libmpcodecs/vd_qtvideo.c +++ b/libmpcodecs/vd_qtvideo.c @@ -129,7 +129,7 @@ static int init(sh_video_t *sh){ DecompressSequenceFrameS = (OSErr (*)(ImageSequence,Ptr,long,CodecFlags,CodecFlags*,ICMCompletionProcRecordPtr))GetProcAddress(handler, "DecompressSequenceFrameS"); GetGWorldPixMap = (PixMapHandle (*)(GWorldPtr))GetProcAddress(handler, "GetGWorldPixMap"); QTNewGWorldFromPtr = (OSErr(*)(GWorldPtr *,OSType,const Rect *,CTabHandle,void*,GWorldFlags,void *,long))GetProcAddress(handler, "QTNewGWorldFromPtr"); - NewHandleClear = (OSErr(*)(Size))GetProcAddress(handler, "NewHandleClear"); + NewHandleClear = (Handle(*)(Size))GetProcAddress(handler, "NewHandleClear"); DisposeHandle = (void (*)(Handle))GetProcAddress(handler, "DisposeHandle"); DisposeGWorld = (void (*)(GWorldPtr))GetProcAddress(handler, "DisposeGWorld"); CDSequenceEnd = (OSErr (*)(ImageSequence))GetProcAddress(handler, "CDSequenceEnd"); diff --git a/libvo/vo_kva.c b/libvo/vo_kva.c index 8d327fd88..340ddf69e 100644 --- a/libvo/vo_kva.c +++ b/libvo/vo_kva.c @@ -322,8 +322,8 @@ static void imgDisplay(void) dstStride[2], m_int.stride[2]); } } else { - sws_scale(m_int.sws, m_int.planes, m_int.stride, 0, SRC_HEIGHT, - dst, dstStride); + sws_scale(m_int.sws, (const uint8_t * const *)m_int.planes, + m_int.stride, 0, SRC_HEIGHT, dst, dstStride); } kvaUnlockBuffer(); diff --git a/loader/afl.c b/loader/afl.c index 337cbcd55..b29471cdc 100644 --- a/loader/afl.c +++ b/loader/afl.c @@ -227,7 +227,7 @@ MMRESULT WINAPI acmDriverOpen(PHACMDRIVER phad, HACMDRIVERID hadid, DWORD fdwOpe return MMSYSERR_ERROR; } - pad->pfnDriverProc = GetProcAddress(pad->hDrvr, "DriverProc"); + pad->pfnDriverProc = (DRIVERPROC)GetProcAddress(pad->hDrvr, "DriverProc"); /* insert new pad at beg of list */ pad->pNextACMDriver = padid->pACMDriverList; diff --git a/loader/dshow/DS_Filter.c b/loader/dshow/DS_Filter.c index 693d59c25..170b49537 100644 --- a/loader/dshow/DS_Filter.c +++ b/loader/dshow/DS_Filter.c @@ -216,7 +216,7 @@ DS_Filter* DS_FilterCreate(const char* dllname, const GUID* id, enum_pins->vt->Reset(enum_pins); result = enum_pins->vt->Next(enum_pins, (ULONG)256, (IPin**)array, &fetched); - enum_pins->vt->Release(enum_pins); + enum_pins->vt->Release((IUnknown *)enum_pins); Debug printf("Pins enumeration returned %ld pins, error is %x\n", fetched, (int)result); for (i = 0; i < fetched; i++) @@ -306,7 +306,7 @@ DS_Filter* DS_FilterCreate(const char* dllname, const GUID* id, init++; break; } - tempAll->vt->Release(tempAll); + tempAll->vt->Release((IUnknown *)tempAll); if (!init) { diff --git a/loader/dshow/DS_VideoDecoder.c b/loader/dshow/DS_VideoDecoder.c index dd0396f4f..46dfde426 100644 --- a/loader/dshow/DS_VideoDecoder.c +++ b/loader/dshow/DS_VideoDecoder.c @@ -601,8 +601,8 @@ int DS_VideoDecoder_SetDestFmt(DS_VideoDecoder *this, int bits, unsigned int csp } if(this->m_pDS_Filter->m_pAll) - this->m_pDS_Filter->m_pAll->vt->Release(this->m_pDS_Filter->m_pAll); - this->m_pDS_Filter->m_pAll=MemAllocatorCreate(); + this->m_pDS_Filter->m_pAll->vt->Release((IUnknown *)this->m_pDS_Filter->m_pAll); + this->m_pDS_Filter->m_pAll=(IMemAllocator *)MemAllocatorCreate(); if (!this->m_pDS_Filter->m_pAll) { printf("Call to MemAllocatorCreate failed\n"); diff --git a/loader/dshow/graph.c b/loader/dshow/graph.c index 01bf6c725..dc82dc93c 100644 --- a/loader/dshow/graph.c +++ b/loader/dshow/graph.c @@ -141,14 +141,14 @@ FilterGraph* FilterGraphCreate() This->vt->AddRef = FilterGraph_AddRef; This->vt->Release = FilterGraph_Release; - This->vt->AddFilter = FilterGraph_AddFilter; - This->vt->RemoveFilter = FilterGraph_RemoveFilter; - This->vt->EnumFilters = FilterGraph_EnumFilters; - This->vt->FindFilterByName = FilterGraph_FindFilterByName; - This->vt->ConnectDirect = FilterGraph_ConnectDirect; - This->vt->Reconnect = FilterGraph_Reconnect; - This->vt->Disconnect = FilterGraph_Disconnect; - This->vt->SetDefaultSyncSource = FilterGraph_SetDefaultSyncSource; + This->vt->AddFilter = (void *)FilterGraph_AddFilter; + This->vt->RemoveFilter = (void *)FilterGraph_RemoveFilter; + This->vt->EnumFilters = (void *)FilterGraph_EnumFilters; + This->vt->FindFilterByName = (void *)FilterGraph_FindFilterByName; + This->vt->ConnectDirect = (void *)FilterGraph_ConnectDirect; + This->vt->Reconnect = (void *)FilterGraph_Reconnect; + This->vt->Disconnect = (void *)FilterGraph_Disconnect; + This->vt->SetDefaultSyncSource = (void *)FilterGraph_SetDefaultSyncSource; This->interfaces[0] = IID_IUnknown; This->interfaces[1] = IID_IFilterGraph; diff --git a/loader/ext.c b/loader/ext.c index 5483a0b7e..cfdce1258 100644 --- a/loader/ext.c +++ b/loader/ext.c @@ -444,7 +444,7 @@ LPVOID WINAPI VirtualAlloc(LPVOID address, DWORD size, DWORD type, DWORD protec if (type&MEM_RESERVE && (unsigned)address&0xffff) { size += (unsigned)address&0xffff; - address = (unsigned)address&~0xffff; + address = (LPVOID)((unsigned)address&~0xffff); } pgsz = sysconf(_SC_PAGESIZE); if (type&MEM_COMMIT && (unsigned)address%pgsz) { diff --git a/loader/module.c b/loader/module.c index 1a45efce6..df679beaa 100644 --- a/loader/module.c +++ b/loader/module.c @@ -844,7 +844,7 @@ static int report_func(void *stack_base, int stack_size, reg386_t *reg, uint32_t // memory management: case 0x150011: //NewPtrClear case 0x150012: //NewPtrSysClear - reg->eax = malloc(((uint32_t *)stack_base)[1]); + reg->eax = (uintptr_t)malloc(((uint32_t *)stack_base)[1]); memset((void *)reg->eax,0,((uint32_t *)stack_base)[1]); #ifdef DEBUG_QTX_API printf("%*sLEAVE(%d): EMULATED! 0x%X\n",ret_i*2,"",ret_i, reg->eax); @@ -852,7 +852,7 @@ static int report_func(void *stack_base, int stack_size, reg386_t *reg, uint32_t return 1; case 0x15000F: //NewPtr case 0x150010: //NewPtrSys - reg->eax = malloc(((uint32_t *)stack_base)[1]); + reg->eax = (uintptr_t)malloc(((uint32_t *)stack_base)[1]); #ifdef DEBUG_QTX_API printf("%*sLEAVE(%d): EMULATED! 0x%X\n",ret_i*2,"",ret_i, reg->eax); #endif diff --git a/loader/win32.c b/loader/win32.c index 6d559a7e7..0c5bcca93 100644 --- a/loader/win32.c +++ b/loader/win32.c @@ -603,7 +603,7 @@ static HMODULE WINAPI expGetModuleHandleW(const uint16_t* name) int pos = 0; while (*name) { if (*name > 256 || pos >= sizeof(aname) - 1) - return NULL; + return (HMODULE)NULL; aname[pos++] = *name++; } aname[pos] = 0; @@ -1504,7 +1504,7 @@ static void WINAPI expDeleteCriticalSection(CRITICAL_SECTION *c) static int WINAPI expGetCurrentThreadId(void) { dbgprintf("GetCurrentThreadId() => %d\n", pthread_self()); - return pthread_self(); + return (int)pthread_self(); } static int WINAPI expGetCurrentProcess(void) { @@ -2019,15 +2019,16 @@ static DWORD WINAPI expSignalObjectAndWait(HANDLE hObjectToSignal, expSetEvent(mlist); break; case 1: // Semaphore - expReleaseSemaphore(mlist, 1, NULL); + expReleaseSemaphore((intptr_t)mlist, 1, NULL); break; case 2: // Mutex - expReleaseMutex(mlist); + expReleaseMutex((HANDLE)mlist); break; default: dbgprintf("Signalling unknown object type %d!\n", hObjectToSignal); } - return expWaitForSingleObject(hObjectToWaitOn, dwMilliseconds); + return (DWORD)expWaitForSingleObject((void *)hObjectToWaitOn, + dwMilliseconds); } static long WINAPI expRegOpenKeyExA(long key, const char* subkey, long reserved, long access, int* newkey) @@ -2751,7 +2752,7 @@ static int WINAPI expEnumDisplayMonitors(void *dc, RECT *r, { dbgprintf("EnumDisplayMonitors(0x%x, 0x%x, 0x%x, 0x%x) => ?\n", dc, r, callback_proc, callback_param); - return callback_proc(0, dc, r, callback_param); + return callback_proc(0, (HDC)dc, r, (LPARAM)callback_param); } #if 0 @@ -2851,14 +2852,14 @@ static int WINAPI expEnumWindows(int (*callback_func)(HWND, LPARAM), void *callb { int i, i2; dbgprintf("EnumWindows(0x%x, 0x%x) => 1\n", callback_func, callback_param); - i = callback_func(0, callback_param); - i2 = callback_func(1, callback_param); + i = callback_func(0, (LPARAM)callback_param); + i2 = callback_func(1, (LPARAM)callback_param); return i && i2; } static int WINAPI expGetWindowThreadProcessId(HWND win, int *pid_data) { - int tid = pthread_self(); + int tid = (int)pthread_self(); dbgprintf("GetWindowThreadProcessId(0x%x, 0x%x) => %d\n", win, pid_data, tid); if (pid_data) @@ -4940,7 +4941,7 @@ static HPALETTE WINAPI expCreatePalette(CONST LOGPALETTE *lpgpl) dbgprintf("CreatePalette(%x) => NULL\n", lpgpl); i = sizeof(LOGPALETTE)+((lpgpl->palNumEntries-1)*sizeof(PALETTEENTRY)); - test = malloc(i); + test = (HPALETTE)malloc(i); memcpy((void *)test, lpgpl, i); return test; diff --git a/mp_msg.c b/mp_msg.c index 3b059801a..4408aed73 100644 --- a/mp_msg.c +++ b/mp_msg.c @@ -70,7 +70,7 @@ const char* filename_recode(const char* filename) filename_len = strlen(filename); max_path = MSGSIZE_MAX - 4; precoded = recoded_filename; - if (iconv(inv_msgiconv, (char **)&filename, &filename_len, + if (iconv(inv_msgiconv, (const char **)&filename, &filename_len, &precoded, &max_path) == (size_t)(-1) && errno == E2BIG) { precoded[0] = precoded[1] = precoded[2] = '.'; precoded += 3; @@ -233,7 +233,7 @@ void mp_msg_va(int mod, int lev, const char *format, va_list va){ ,MSG_CHARSET,mp_msg_charset); }else{ memset(tmp2, 0, MSGSIZE_MAX); - while (iconv(msgiconv, &in, &inlen, &out, &outlen) == -1) { + while (iconv(msgiconv, (const char **)&in, &inlen, &out, &outlen) == -1) { if (!inlen || !outlen) break; *out++ = *in++; diff --git a/stream/asf_mmst_streaming.c b/stream/asf_mmst_streaming.c index 6b7b6efc0..8853647a2 100644 --- a/stream/asf_mmst_streaming.c +++ b/stream/asf_mmst_streaming.c @@ -150,7 +150,7 @@ static void string_utf16(char *dest, char *src, int len) { len1 = len; len2 = 1000; ip = src; op = dest; - iconv(url_conv, &ip, &len1, &op, &len2); + iconv(url_conv, (const char **)&ip, &len1, &op, &len2); } else { diff --git a/sub/font_load_ft.c b/sub/font_load_ft.c index bd3e1c1de..eb2f77fb5 100644 --- a/sub/font_load_ft.c +++ b/sub/font_load_ft.c @@ -743,7 +743,7 @@ static FT_ULong decode_char(iconv_t *cd, char c) { size_t inbytesleft = 1; size_t outbytesleft = sizeof(FT_ULong); - iconv(*cd, &inbuf, &inbytesleft, &outbuf, &outbytesleft); + iconv(*cd, (const char **)&inbuf, &inbytesleft, &outbuf, &outbytesleft); /* convert unicode BigEndian -> MachineEndian */ o = be2me_32(o); diff --git a/sub/subreader.c b/sub/subreader.c index 3c815d132..a079af65c 100644 --- a/sub/subreader.c +++ b/sub/subreader.c @@ -1271,7 +1271,7 @@ void subcp_recode (subtitle *sub) continue; } op = ot; - if (iconv(icdsc, &ip, &ileft, + if (iconv(icdsc, (const char **)&ip, &ileft, &op, &oleft) == (size_t)(-1)) { mp_msg(MSGT_SUBREADER,MSGL_WARN,"SUB: error recoding line.\n"); free(ot); -- 2.42.0

1 0

Unbreak build
by Nicolas George 26 Sep '24

26 Sep '24

Hi. I should pull my weight around here. The attached patch series fixes build with recent ffmpeg and Debian testing: - ffmpeg requires a few changes in the configure script; - gcc 14 has started considering incompatible implicit pointer casts as fatal errors; - the fast-math change was reported by multiple persons. I have only tested building most changes, not running, I think it is enough to apply. Regards, -- Nicolas George

2 4

Delay at start of video playback
by The Wanderer 22 Sep '24

22 Sep '24

With my just-built copy of MPlayer with current FFmpeg, when I play a file that has a video stream (all the ones I've tried so far, at least), it hangs for an extended period - with heavy CPU utilization - before it brings up the video window. So far as I've measured, the total delay appears to be on the order of 20 seconds. Once the video window appears, things seem to work normally; CPU utilization goes down, playback is normal, and I can seek around in the file without apparent issues. With one such file, I appended '-v -v -v -v -v -v' to the command line, and got in part the following output: ========8<======== [mov,mp4,m4a,3gp,3g2,mj2 @ 0x55b746d80620]All info found mp_seek(0x55b77974d5b0, 0, 65536) mp_seek(0x55b77974d5b0, 0, 65536) mp_seek(0x55b77974d5b0, 0, 65536) [mov,mp4,m4a,3gp,3g2,mj2 @ 0x55b746d80620]stream 0: start_time: duration: 348.222875 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x55b746d80620]stream 1: start_time: duration: 348.29932 [mov,mp4,m4a,3gp,3g2,mj2 @ 0x55b746d80620]format: start_time: duration: 348.29932 (estimate from stream) bitrate=398 kb/s [mov,mp4,m4a,3gp,3g2,mj2 @ 0x55b746d80620]After avformat_find_stream_info() pos: 117417 bytes read:134623 seeks:0 frames:12 ==> Found video stream: 0 ========8<======== When the hang occurs, the final visible message is that third mp_seek. The following three messages appear one at a time, seconds apart, over the delay period; the ones after that appear to come at a more normal rate, without visible delays. Those three appear to come from ffmpeg/libavformat/demux.c:estimate_timings(); that suggests that the issue may be in that function, or possibly in a callsite for the same, but the recent changes to that file (per 'git log' in the internal FFmpeg checkout) do not seem to show anything that looks suspicious to me. I am not currently sure how to start investigating further, aside from possibly trying to bisect (which I could do, but don't have the time for this afternoon). This is fairly significantly impairing to convenient use of MPlayer, but does not block me from using it entirely. -- The Wanderer The reasonable man adapts himself to the world; the unreasonable one persists in trying to adapt the world to himself. Therefore all progress depends on the unreasonable man. -- George Bernard Shaw

5 8

Current FFmpeg needs DOVI_RPUENC
by The Wanderer 01 Sep '24

01 Sep '24

I needed to recompile MPlayer today, and once I got around the problems resulting from my distribution's default compiler having switched to GCC 14 (a variant on Alexander's RFC patch from April worked fine for that), ran into linker errors. I eventually figured out that with current FFmpeg, it's no longer enough to unconditionally set CONFIG_DOVI_RPUDEC (and CONFIG_DOVI_RPU, which may or may not be needed at all anymore). I added 'CONFIG_DOVI_RPUENC=yes' to configure, immediately after the existing RPUDEC entry, and with that change the build completed and linked without issues. (That was with GCC 13, just to narrow down the variables, but I'm confident it would have worked with GCC 14 as well.) If a patch is needed I can create one, but it's trivial to do by hand. -- The Wanderer The reasonable man adapts himself to the world; the unreasonable one persists in trying to adapt the world to himself. Therefore all progress depends on the unreasonable man. -- George Bernard Shaw

1 0