August 2024 - MPlayer-dev-eng - lists.mplayerhq.hu

[PATCH] update the MIME type list in desktop file
by Lorenzo 19 Nov '24

19 Nov '24

Hello, Debian ships a desktop file with an updated list of MIME types; the list was derived from VLC but I cross check it against the list of SMplayer and they are roughly equivalent. Please consider to apply upstream, patch is attached Thanks, Lorenzo

2 1

[PATCH] Secure IPC perms
by Wladmis 19 Nov '24

19 Nov '24

From: "Vladimir D. Seleznev" <vseleznv(a)altlinux.org> shmget(2) is not subject of umask(2), so it's better to use more proper perms for it. --- MPlayer/gui/wm/ws.c | 2 +- MPlayer/libvo/vo_x11.c | 2 +- MPlayer/libvo/vo_xv.c | 2 +- MPlayer/libvo/vo_xvmc.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/MPlayer/gui/wm/ws.c b/MPlayer/gui/wm/ws.c index b211db5959..474154fc3c 100644 --- a/MPlayer/gui/wm/ws.c +++ b/MPlayer/gui/wm/ws.c @@ -1357,7 +1357,7 @@ void wsImageCreate(wsWindow *win, int w, int h) mplayer(MPLAYER_EXIT_GUI, EXIT_ERROR, 0); } - win->Shminfo.shmid = shmget(IPC_PRIVATE, win->xImage->bytes_per_line * win->xImage->height, IPC_CREAT | 0777); + win->Shminfo.shmid = shmget(IPC_PRIVATE, win->xImage->bytes_per_line * win->xImage->height, IPC_CREAT | 0600); if (win->Shminfo.shmid < 0) { XDestroyImage(win->xImage); diff --git a/MPlayer/libvo/vo_x11.c b/MPlayer/libvo/vo_x11.c index 58e1762de7..6b81980023 100644 --- a/MPlayer/libvo/vo_x11.c +++ b/MPlayer/libvo/vo_x11.c @@ -150,7 +150,7 @@ static void getMyXImage(void) } Shminfo[0].shmid = shmget(IPC_PRIVATE, myximage->bytes_per_line * - myximage->height, IPC_CREAT | 0777); + myximage->height, IPC_CREAT | 0600); if (Shminfo[0].shmid < 0) { XDestroyImage(myximage); diff --git a/MPlayer/libvo/vo_xv.c b/MPlayer/libvo/vo_xv.c index ebc1dbb23d..a3ec393e16 100644 --- a/MPlayer/libvo/vo_xv.c +++ b/MPlayer/libvo/vo_xv.c @@ -279,7 +279,7 @@ static void allocate_xvimage(int foo) &Shminfo[foo]); Shminfo[foo].shmid = - shmget(IPC_PRIVATE, xvimage[foo]->data_size, IPC_CREAT | 0777); + shmget(IPC_PRIVATE, xvimage[foo]->data_size, IPC_CREAT | 0600); Shminfo[foo].shmaddr = (char *) shmat(Shminfo[foo].shmid, 0, 0); Shminfo[foo].readOnly = False; diff --git a/MPlayer/libvo/vo_xvmc.c b/MPlayer/libvo/vo_xvmc.c index 48f3ede440..31104f4dd4 100644 --- a/MPlayer/libvo/vo_xvmc.c +++ b/MPlayer/libvo/vo_xvmc.c @@ -203,7 +203,7 @@ static int allocate_xvimage(int xvimage_width,int xvimage_height,int xv_format) if (!xvimage->data_size) goto shmgetfail; - Shminfo.shmid = shmget(IPC_PRIVATE, xvimage->data_size, IPC_CREAT | 0777); + Shminfo.shmid = shmget(IPC_PRIVATE, xvimage->data_size, IPC_CREAT | 0600); if (Shminfo.shmid == -1) goto shmgetfail; Shminfo.shmaddr = (char *) shmat(Shminfo.shmid, 0, 0); -- 2.33.7

3 2

[PATCH] remove -ffast-math from CFLAGS and LDFLAGS in configure script
by Mike Lieman 17 Aug '24

17 Aug '24

The ticket "Video files suddenly take 100s before playback starts" ( https://trac.mplayerhq.hu/ticket/2425 ) describes long startup times with some files between 10 and 100 seconds. It began after a change to ffmpeg which uses negative infinity, and the fast-math library had been optimizing it in a way that spent an inordinate amount of time in the subsequent loops. Many people consider the fast-math library dangerous, and we see an example of why that is so right here. But simply doing floating point math correctly, the issue is resolved. This patch removes the fast-math library. Index: configure =================================================================== --- configure (revision 38637) +++ configure (working copy) @@ -2969,10 +2969,10 @@ elif test "$cc_vendor" != "gnu" ; then CFLAGS="-O2 $_march $_mcpu $_pipe" else - CFLAGS="-O4 $_march $_mcpu $_pipe -ffast-math -fomit-frame-pointer" + CFLAGS="-O4 $_march $_mcpu $_pipe -fomit-frame-pointer" WARNFLAGS="-Wall -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls -Werror=format-security" WARN_CFLAGS="-Werror-implicit-function-declaration" - extra_ldflags="$extra_ldflags -ffast-math" + extra_ldflags="$extra_ldflags" fi if test "$_profile" != "" || test "$_debug" != ""; then

1 0

Long startup times.
by Mike Lieman 04 Aug '24

04 Aug '24

I do a svn update, and mplayer pulls in ffmpeg, so I think I'm running the most current code. I've observed that when starting up, it's spending a noticeable amount of time in dmux_open. (On the order of 10 - 30 seconds), which I don't believe I've seen before. Any ideas or suggestions on how to further drill down on this to maybe fix it? Thank you, Mike

1 0