March 2023 - MPlayer-dev-eng - lists.mplayerhq.hu

lavcac3enc broken?
by eatdirt 08 Apr '23

08 Apr '23

Hi there, I am a long term user of mplayer, and my "custom" usage is to reencode audio streams to ac3 to feed my "old" amplifier. Since version 1.5, it seems that the audio chain having: -af lavcac3enc 1:x:y is broken as soon as the stream is not ac3 (it used to work with any stream pre-version 1.5). Here the errors popping out, for instance from an eac3 audio channel: [ac3_fixed @ 0x7f72fd553760]Specified sample format s16p is invalid or not supported Couldn't open codec ac3, br=448000. [libaf] Reinitialization did not work, audio filter 'lavcac3enc' returned error code -2 Error at audio filter chain pre-init! Same error reading from an audio channel in aac: [ac3_fixed @ 0x7fd154b53760]Specified sample format s16p is invalid or not supported Couldn't open codec ac3, br=448000. [libaf] Reinitialization did not work, audio filter 'lavcac3enc' returned error code -2 Error at audio filter chain pre-init! I am happy to give more information or test patches. PS: tested mpv (which also has the lavac3enc filter, and it works fine for those very same audio streams). Cheers, chris.

2 7

[PATCH] Fix a sndio crash when exiting in muted state
by Brad Smith 08 Apr '23

08 Apr '23

Patch from Theo Buehler <tb(a)openbsd.org> CVSROOT: /cvs Module name: ports Changes by: tb(a)cvs.openbsd.org 2023/03/14 04:08:13 Modified files: x11/mplayer : Makefile x11/mplayer/patches: patch-libao2_ao_sndio_c Log message: mplayer: fix a crash when exiting in muted state Muting mplayer with 'm', then hitting '<enter>' segfaults mplayer since it tries to unmute itself after uninitializing the sndio backend. Clear the havevol flag on uninit() to block subsequent AOCONTROL_{GET,SET}_VOLUME operations. Fix suggested by and ok ratchov Index: libao2/ao_sndio.c =================================================================== --- libao2/ao_sndio.c (revision 38412) +++ libao2/ao_sndio.c (working copy) @@ -159,6 +159,7 @@ pfds = NULL; sio_close(hdl); hdl = NULL; + havevol = 0; return 0; } @@ -172,6 +173,7 @@ hdl = NULL; free(pfds); pfds = NULL; + havevol = 0; } /*

3 9

trac optimization
by Michael Niedermayer 05 Mar '23

05 Mar '23

Hi due to continuing performance issues (and complaints) about trac speed ive switched the database to WAL mode. This should make th db signifciantly faster but iam not sure the database was the limiting factor. Now reading and writing can proceed concurrently, before writes would block everything. One might think "but there wasnt that much changed/writen" this is logic but not true. The database stores every recent spammer access and everything that could be a spammer, every session cookie (we have 129379 temporary sessions in teh ffmpeg trac databse for example). This is bad design arguably of course .... If you notice any new issue, please report it here. Ive made a backup from trac before this and we have daily trac backups if this causes a major issue i intend to rollback to a previous backup and disable it again. But i expect no major issue, its likely either faster or not. thx -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Old school: Use the lowest level language in which you can solve the problem conveniently. New school: Use the highest level language in which the latest supercomputer can solve the problem without the user falling asleep waiting.

1 0