August 2014 - MPlayer-dev-eng - lists.mplayerhq.hu

Homepage skin download issue
by Ingo Brückl 09 Sep '15

09 Sep '15

Yesterday, I updated hwswskin to 1.3, but it still isn't downloadable. Is the generation of the skin download tarballs working? Ingo

3 8

[PATCH] mencoder slang vobsub fix
by Edward Batutis 09 Sep '14

09 Sep '14

Hi, This is my very first patch for mplayer/mencoder. This patch allows mencoder -slang <lang> <some video file> -vobsub <some sub/idx path> ... to select a language from a SUB/IDX combination. For example: mencoder -slang en /movie/my.avi -vobsub /movie ... where /movie contains a my.sub and my.idx. This will select language 'en' from the idx/sub. Without this patch you always get subtitle zero, whatever it may be. Why this wasn't fixed long ago - who knows. Mplayer does the right thing. Not mencoder. =Ed

2 4

[PATCH] Fix key_down_event SEGFALT
by spunit262 . 04 Sep '14

04 Sep '14

I discovered by messing around that using key_down_event with a large random value (ex SPACE | MP_NO_REPEAT_KEY) can cause a segfalt. I found the problem to be that isprint is only defined for values in the range of an unsigned char and the value EOF. The patch adds a simple check before isprint in mp_input_get_key_name to make sure the value is in isprint's range.

2 1

[PATCH] spudec: fix heap overflow in pal2gray_alpha()
by Matthijs van Otterdijk 04 Sep '14

04 Sep '14

sub/spudec.c:spudec_packet_fill() optionally draws rectangles with an x and y offset, which is used by sub/av_sub.c:avsub_to_spudec() in case of multiple rects. The way this is done now causes a heap overflow in spudec.c:pal2gray_alpha(). spudec_packet_fill() offsets img and aimg by x before calling pal2gray_alpha(). pal2gray_alpha() writes dst_stride pixels for each line in the rect. In case the bottom rectangle (and therefore the rectangle situated at the end of the packet buffer) has an x offset, this will cause x 0s to be written past the end of the packet buffer. The attached patch fixes this by making pal2gray_alpha() handle the x offset, rather than spudec_packet_fill(). - Matthijs

2 1

[Trac] Changed behaviour of "View Tickets" of the main navigation bar
by Alexander Strasser 19 Aug '14

19 Aug '14

Hello all, I tuned the config of our issue tracker a bit concerning the behaviour when one clicks on the "View Tickets" item of the navigation bar. It now skips the report selection and goes straight to the query view which is initialized with a default query that says show me all but closed tickets sorted by the date of modification in descending order. You can try it here https://trac.mplayerhq.hu/ to compare to the old behaviour have a look at FFmpeg's Trac https://trac.ffmpeg.org/ Please tell me how you like it or if you want me to revert. Alexander

3 4

gui: subtitle menu is not populated when playing from mpg file
by Lode Leroy 17 Aug '14

17 Aug '14

please consider the following fix for mplayer -gui... mpctx_get_global_sub_size(guiInfo.mpcontext); is not returning the number of subtitles, because void update_global_sub_size(MPContext *mpctx) was not called to update it. ps: the indentation is not optimal to keep the patch size minimal Index: gui/dialog/menu.c =================================================================== --- gui/dialog/menu.c (revision 37244) +++ gui/dialog/menu.c (working copy) @@ -733,9 +733,17 @@ } /* cheap subtitle switching for non-DVD streams */ - if ( global_sub_size && guiInfo.StreamType != STREAMTYPE_DVD ) + if ( guiInfo.StreamType != STREAMTYPE_DVD ) { - int pos, i, j, subs0 = guiInfo.mpcontext->sub_counts[SUB_SOURCE_SUBS], subs1 = guiInfo.mpcontext->sub_counts[SUB_SOURCE_VOBSUB]; + int pos, i, j, subs0, subs1, subs2; + subs0 = guiInfo.mpcontext->sub_counts[SUB_SOURCE_SUBS]; + subs1 = guiInfo.mpcontext->sub_counts[SUB_SOURCE_VOBSUB]; + subs2 = 0; //guiInfo.mpcontext->sub_counts[SUB_SOURCE_DEMUX]; // may be out-of-date! + for (i = 0; i < MAX_S_STREAMS; i++) + if (guiInfo.mpcontext->demuxer->s_streams[i]) + subs2++; + global_sub_size = subs0 + subs1 + subs2; + if ( global_sub_size) { pos = mpctx_get_global_sub_pos(guiInfo.mpcontext); SubMenu=AddSubMenu( window1, (const char*)subtitle_xpm, Menu, MSGTR_GUI_Subtitles ); AddMenuCheckItem( window1, (const char*)empty1px_xpm, SubMenu, MSGTR_GUI__none_, pos == -1, (-1 << 16) + ivSetSubtitle ); @@ -784,6 +792,7 @@ else snprintf( tmp, sizeof(tmp), MSGTR_GUI_TrackN, i ); AddMenuCheckItem( window1,(const char*)empty1px_xpm,SubMenu,tmp,pos == i,( i << 16 ) + ivSetSubtitle ); } + } } AddSeparator( Menu );

4 10

Danish translation ought to be renamed
by Ingo Brückl 14 Aug '14

14 Aug '14

Does anyone mind me renaming the Danish translation from help_mp-dk.h to help_mp-da.h and protocolling this in the Changelog? (AFAICS, there are no dependencies to be considered.) There is no ISO 639-1 language code "dk", Danish is "da". Ingo

2 2

[PATCH 1/3] bugreports: Replace old Bugzilla references
by Alexander Strasser 12 Aug '14

12 Aug '14

We use Trac since a while now. Signed-off-by: Alexander Strasser <eclipse7(a)gmx.net> --- DOCS/xml/en/bugreports.xml | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/DOCS/xml/en/bugreports.xml b/DOCS/xml/en/bugreports.xml index 85ab614..970425f 100644 --- a/DOCS/xml/en/bugreports.xml +++ b/DOCS/xml/en/bugreports.xml @@ -129,8 +129,8 @@ This will allow you to easily find the exact patch that did it. <para> If you find the patch that is the cause of the problem, you have almost won; -report about it to the -<ulink url="http://bugzilla.mplayerhq.hu/">MPlayer Bugzilla</ulink> or +report about it on +<ulink url="https://trac.mplayerhq.hu/">MPlayer's issue tracker</ulink> or subscribe to <ulink url="http://lists.mplayerhq.hu/mailman/listinfo/mplayer-users">MPlayer-users</ulink> and post it there. @@ -209,8 +209,8 @@ and send your bug report to </para> <para> -If you prefer, you can use our -<ulink url="http://bugzilla.mplayerhq.hu/">Bugzilla</ulink> instead. +If you prefer, you can report it on our +<ulink url="https://trac.mplayerhq.hu/">issue tracker</ulink> instead. </para> <para> --

2 3