April 2014 - MPlayer-dev-eng - lists.mplayerhq.hu

Homepage skin download issue
by Ingo Brückl 09 Sep '15

09 Sep '15

Yesterday, I updated hwswskin to 1.3, but it still isn't downloadable. Is the generation of the skin download tarballs working? Ingo

3 8

[PATCH] mencoder slang vobsub fix
by Edward Batutis 09 Sep '14

09 Sep '14

Hi, This is my very first patch for mplayer/mencoder. This patch allows mencoder -slang <lang> <some video file> -vobsub <some sub/idx path> ... to select a language from a SUB/IDX combination. For example: mencoder -slang en /movie/my.avi -vobsub /movie ... where /movie contains a my.sub and my.idx. This will select language 'en' from the idx/sub. Without this patch you always get subtitle zero, whatever it may be. Why this wasn't fixed long ago - who knows. Mplayer does the right thing. Not mencoder. =Ed

2 4

[PATCH] Fix key_down_event SEGFALT
by spunit262 . 04 Sep '14

04 Sep '14

I discovered by messing around that using key_down_event with a large random value (ex SPACE | MP_NO_REPEAT_KEY) can cause a segfalt. I found the problem to be that isprint is only defined for values in the range of an unsigned char and the value EOF. The patch adds a simple check before isprint in mp_input_get_key_name to make sure the value is in isprint's range.

2 1

Danish translation ought to be renamed
by Ingo Brückl 14 Aug '14

14 Aug '14

Does anyone mind me renaming the Danish translation from help_mp-dk.h to help_mp-da.h and protocolling this in the Changelog? (AFAICS, there are no dependencies to be considered.) There is no ISO 639-1 language code "dk", Danish is "da". Ingo

2 2

[PATCH] use correct type of timestamps when recording from v4l2, fix #2176
by Jarek Czekalski 10 Jun '14

10 Jun '14

Mencoder should detect whether timestamps used by v4l2 come from monotonic or realtime clock. This is important for Linux kernels >=3.10. Details in bug report #2176 [1] Patch for stream/tvi_v4l2.c against r36970 attached. [1] https://trac.mplayerhq.hu/ticket/2176

2 2

[patch] RT subtitle timestamp parsing buggy
by hhaamu＠gmail.com 27 May '14

27 May '14

Hi The subtitle parser for .rt subtitles fails on hh:mm:ss and hh:mm:ss.ff type of timestamps and generally thinks they should all be displayed on the 0-second mark. This only happens when there is no 'end' attribute for the subtitles. For example, the following lines <time begin="01:39.40"/><clear/> It's different now. <time begin="00:02:14.7"/><clear/> Look... parse to [1]: 01:01:39.04 01:01:41.01 {~} It's different now. 00:00:02.00 00:00:08.00 {~} Look... The code is a long chain of sscanf() functions. There are two issues at play here: 1) sscanf sets a1, a2 etc even when the whole line does not match. The lines that try to parse begin/end tags will partially match and set those variables, leading to faulty timestamps. The variables should be reset to zero after each match attempt. 2) The line that tries matching for mm:ss timestamps actually matches more than it is supposed to. The mm:ss.ff and hh:mm:ss.ff lines are never run. Attached is a minimal patch that fixes these two issues. (It moves the problematic match downwards and resets the variables as necessary.) Other concerns relating to the surrounding code: 1) the 'len' variable sits completely unused and can be removed. 2) the timestamp calculation lines (a1*360000+a2*6000+a3*100+a4/10) assume that the fourth value parsed (a4) is in milliseconds. This assumption does not hold: the subtitle files I have are marked in tenths of a second. I'm not sure it can be fixed without rewriting the parsing code. [1] Incidentally, the -dumpjacosub option creates a dumpsub.jss file rather than the dumpsub.js file promised on the man page.

3 5

[PATCH] Expunge printf from vidix/
by Arne Bochem 17 May '14

17 May '14

While tracking down a case of "-really-quiet isn't really quiet" in #mplayer yesterday, I noticed that most vidix related code uses printf instead of mp_msg. The attached patch gets rid of printf in favour of mp_msg. It also adds proper module attribution to a few messages in vidix/ that were missing it (e.g. in vidix/drivers.c). Caveats: Most messages are MSGL_STATUS. This could use some more thought, but it should be an improvement anyway. Also, I can't really test the vidix code, but it compiles and I don't really see how this could have broken anything. Regards, Arne Bochem

3 4

[PATCH] mencoder: detect end of audio stream while encoded data still buffered
by Kieran Clancy 10 May '14

10 May '14

Changes to mencoder introduced by r36905 (2014-02-24; mencoder: Finish encoding only when audio and video reached EOF.) introduced a regression when using mp3lame and possibly other audio encoders. This was first reported by Alexander Roalter on mplayer-users: https://lists.mplayerhq.hu/pipermail/mplayer-users/2014-March/087288.html $ mencoder -msglevel all=6 -o out.avi -oac mp3lame -ovc lavc input ... (works normally until the end of the audio stream, but after the end of the video stream, an endless loop of messages begins:) ... ds_fill_buffer: EOF reached (stream: audio) ds_fill_buffer: EOF reached (stream: video) ds_fill_buffer: EOF reached (stream: audio) ds_fill_buffer: EOF reached (stream: video) ... After running a debugger, I found that the new code introduced by r36905 assumes that mux_a->buffer_len == 0 on end-of-stream, but it is often not the case for mp3lame (and probably other codecs). Due to technicalities in the way LAME works, it may generate a partial audio frame before the input stream ends, and mencoder lacks the architecture to request that audio codecs in this situation complete their partial frames on end-of-stream. I suspect other audio codecs have the same issue. In any case, the fix turned out to be very simple; there is no need to assume that mux_a->buffer_len is zero on end-of-stream. Even if there is outstanding data in mux_a->buffer, end-of-stream means it will never be muxed into the output because dec_audio() will not provide any more data for aencoder->encode(). Kieran Clancy --- mencoder.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

3 20

Fix libmpcodecs inline asm on ICL
by Matt Oliver 03 May '14

03 May '14

This is a patch to enable intel compiler on Windows to compile the libmpcodec inline asm functions. It is based of similar work previously done in FFmpeg (and in fact was initially posted there) and extends some previous patches that were applied to libmpcodecs a few months ago. This is required to compile ffmpeg under icl with asm and was previously posted (probably incorrectly) on the ffmpeg mailing list but im now posting it here in the correct location. Matt

2 5

Problems with flicker in AVIs using Intel Indeo (RT21) codec
by Mats Peterson 30 Apr '14

30 Apr '14

Hello. I have noticed that MPlayer causes heavy flicker when playing AVIs encoded with the Indeo (RT21) codec. A sample file is available at http://alicja.homelinux.com/~mats/stuff/INDEO2.AVI. Mats -- Mats Peterson http://alicja.homelinux.com/~mats/

1 1

Homepage DOCS needs update
by Ingo Brückl 24 Apr '14

24 Apr '14

If it's already on the to-do list ignore, but the documentation on the homepage doesn't get updated. Ingo

3 12

Changing video filters while playing?
by Ingo Brückl 23 Apr '14

23 Apr '14

Is it possible to change video filters while a movie is playing without restarting it? It seems I can do so by calling reinit_video_chain() after the changes, but the video is showing artefacts for a while then. The only usage of reinit_video_chain() I've found is for command "switch_video" which probably does a restart anyway. Ingo

1 0

OpenSSL Heartbeat bug
by Alexander Strasser 18 Apr '14

18 Apr '14

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Our server hosting the Trac issue tracker was vulnerable to the attack against OpenSSL known as "heartbleed". The OpenSSL software library was updated on 7th of April, shortly after the vulnerability was publicly disclosed. We have changed the private keys (and certificates) for all MPlayer servers. The new SHA1 fingerprints are: mplayerhq.hu: d0 4c 1f d0 08 f6 e0 24 f0 2c 31 de 4d 01 45 04 32 2e 36 29 trac.mplayerhq.hu: 2a 1c d7 a5 7e 39 6a bc c3 55 22 88 ba 2a cd e0 1f c1 9f 6e We encourage you to read up on "OpenSSL heartbleed"[1]. It is possible that login data for the issue tracker was exposed to people exploiting this security hole. You might want to change your password in the tracker and everywhere else you used that same password. [1] For example here: https://www.schneier.com/blog/archives/2014/04/heartbleed.html -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlNRakEACgkQp9ile6h25Y80OACfV/nUA0XE7MCGTgV9A29cMT1Y vWYAnjff6mon5Fu2Fk9IgB5H2EFxZngL =lFJq -----END PGP SIGNATURE-----

3 2

Copy audio broken in MEncoder
by Grozdan 14 Apr '14

14 Apr '14

Copying audio with -oac copy is broken in MEncoder. It duplicates frames like crazy and the result is a desync between the video and audio. Can this be fixed, please? (yes, I know MEncoder is not actively developed but I suspect it needs just a minor fix) Thanks -- Yours truly

3 8

[PATCH] Improve potmeter reaction to mouse clicks
by Ingo Brückl 13 Apr '14

13 Apr '14

Set the potmeter values already when the mouse button is pressed instead of waiting for it to be released. This gives a more intuitive behaviour on clicking and dragging. As mentioned in an earlier discussion, due to v/hpotmeter button jumps on grabbing I'm not endorsing it. I'm just posting for trialling. Ingo

2 1

[PATCH] GUI: Implement a true rotary potmeter
by Hans-Dieter Kosch 12 Apr '14

12 Apr '14

The 'potmeter' currently responds only to horizontal mouse coordinates. This is especially confusing when the pot does not rotate in the expected direction depending on the quadrants of pot and mouse positions. Attached patch implements a true rotary pot. You can click on an angular position and rotate by circular mouse movement. And it has stop points like its mechanical counterpart. Tested with the volume pot of default skin 'Blue'. The patch is quite big due to the code redundancy in the files. Perhaps outsourcing and reusing common code? Hans-Dieter

3 49

[PATCH 1/2] mixer: do not unmute to volume 0, instead unmute to max.
by Reimar Döffinger 08 Apr '14

08 Apr '14

It's not very useful for unmute to still result in volume 0. Plus it makes it easier to enable sound for devices that were on mute at startup. --- mixer.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mixer.c b/mixer.c index 8b290d5..d2d6e18 100644 --- a/mixer.c +++ b/mixer.c @@ -129,7 +129,12 @@ void mixer_getbothvolume(mixer_t *mixer, float *b) void mixer_mute(mixer_t *mixer) { - if (mixer->muted) mixer_setvolume(mixer, mixer->last_l, mixer->last_r); + if (mixer->muted) { + // unmuting to volume 0 makes no sense + if (mixer->last_l == 0) mixer->last_l = 100; + if (mixer->last_r == 0) mixer->last_r = 100; + mixer_setvolume(mixer, mixer->last_l, mixer->last_r); + } else { mixer_getvolume(mixer, &mixer->last_l, &mixer->last_r); -- 1.9.1

4 10

[PATCH] add support for synopsys design-ware ARC processors
by Wayne Ren 06 Apr '14

06 Apr '14

Hi This patch is used to add support for synopsys design-ware ARC processors. With this patch mplayer is compiled and linked successfully with arc-linux-uclibc toolchain in buildroot. The mplayer is tested in arc linux and on the hardware board of arc770 processors. Best wishes!

3 2

[PATCH] check if a same sub was already selected
by KO Myung-Hun 06 Apr '14

06 Apr '14

Hi/2. By this, we can avoid a sub stream is reset even if a same sub was already selected. In practice, this fixes the problem that a white box is shown with -sid 0 even if it has a sub track whose id is 0. -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.28 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr

2 2

★ Mplayer Dev Eng, Simon Vargblom har lämnat ett meddelande till dig
by Simon Vargblom 06 Apr '14

06 Apr '14

Simon Vargblom har lämnat ett meddelande till dig Innehållet och dess avsändare kommer endast att visas för dig och kan raderas när som helst. Du kan svara direkt genom vårt meddelandesystem. Följ denna länk för att se meddelandet: http://eu1.badoo.com/0379123686/in/tlXr7dzYA1g/?lang_id=70&g=57-0-4&m=21&mi… Fungerar inte länken? Testa att kopiera och klistra in länken i din webbläsare. Detta e-mail är en del av vår leveransprocess av meddelandet som skickats från Simon Vargblom. Om du felaktigt mottagit detta e-mail, vänligen ignorera det. Inom kort kommer förfrågan att raderas från systemet. Ha det så kul! The Badoo Team Du har mottagit detta e-mail från Badoo Trading Limited (adress nedan). Om du inte vill ha fler mail från Badoo, klicka här: https://eu1.badoo.com/impersonation.phtml?lang_id=70&email=mplayer-dev-eng%…. Badoo Trading Limited är ett aktiebolag registrerat i England och Wales under CRN 7540255, med kontor på Media Village, 131 - 151 Great Titchfield Street, London, W1W 5BB.

1 0

[PATCH] GUI: Potmeter button corrections
by Hans-Dieter Kosch 01 Apr '14

01 Apr '14

Hi Ingo, while coding the rpotmeter, I came across the following: 1) When rendering the [hv]potmeter, the button width/height is regarded, so that the button doesn't exceed the potmeter edges. However, the counterpart in the mouse handling doesn't do the exact inverse calculation. The button is drifting under the mouse pointer from its one edge to its other when moving it from one end of the potmeter to the other. Only in the middle of the pot, the button is centered under the mouse. The attached 'potmeter_button_adjust.patch' corrects the mouse calculations to keep the button always centered under the mouse (like one might expect). The coming rpotmeter button will have the same behaviour (inherent by design). 2) The WIN32 GUI checks that the rendered potmeter button doesn't exceed the bounds. This seems not necessary as the item value is already limited. The GTK GUI doesn't do this check neither. The attached 'potmeter_button_cleanup.patch' removes those checks, simplifying the code. Hans-Dieter

2 13

GUI: Test skin for rpotmeter
by Hans-Dieter Kosch 01 Apr '14

01 Apr '14

Hi Ingo, attached a patch to create a test skin for rpotmeter: Take the old 'default' skin, apply 'skin.diff' and add 'volbtn.png'. Then, the volume poti is a rpotmeter with a new tri-state button plus the already existing phase image. Hans-Dieter

2 2