February 2014 - MPlayer-dev-eng - lists.mplayerhq.hu

Homepage skin download issue
by Ingo Brückl 09 Sep '15

09 Sep '15

Yesterday, I updated hwswskin to 1.3, but it still isn't downloadable. Is the generation of the skin download tarballs working? Ingo

3 8

Danish translation ought to be renamed
by Ingo Brückl 14 Aug '14

14 Aug '14

Does anyone mind me renaming the Danish translation from help_mp-dk.h to help_mp-da.h and protocolling this in the Changelog? (AFAICS, there are no dependencies to be considered.) There is no ISO 639-1 language code "dk", Danish is "da". Ingo

2 2

Homepage DOCS needs update
by Ingo Brückl 24 Apr '14

24 Apr '14

If it's already on the to-do list ignore, but the documentation on the homepage doesn't get updated. Ingo

3 12

[PATCH] GUI: Implement a true rotary potmeter
by Hans-Dieter Kosch 12 Apr '14

12 Apr '14

The 'potmeter' currently responds only to horizontal mouse coordinates. This is especially confusing when the pot does not rotate in the expected direction depending on the quadrants of pot and mouse positions. Attached patch implements a true rotary pot. You can click on an angular position and rotate by circular mouse movement. And it has stop points like its mechanical counterpart. Tested with the volume pot of default skin 'Blue'. The patch is quite big due to the code redundancy in the files. Perhaps outsourcing and reusing common code? Hans-Dieter

3 49

[PATCH] Fix playback of 24-bit audio when sndio ao is used
by Brad Smith 12 Mar '14

12 Mar '14

Here is a diff from Alexandre Ratchov to fix 24-bit audio with the sndio backend. Without the diff playing 24-bit audio results in white noise. $ mplayer test_s24be.aiff MPlayer SVN-r36952 (C) 2000-2014 MPlayer Team Playing test_s24be.aiff. libavformat version 54.63.104 (external) libavformat file format detected. [aiff @ 0x1215ca4ed860]max_analyze_duration 5000000 reached at 5010612 microseconds [lavf] stream 0: audio (pcm_s24be), -aid 0 Load subtitles in ./ ========================================================================== Opening audio decoder: [pcm] Uncompressed PCM audio decoder AUDIO: 44100 Hz, 2 ch, s24be, 2116.8 kbit/100.00% (ratio: 264600->264600) Selected audio codec: [pcm] afm: pcm (Uncompressed PCM) ========================================================================== AO: [sndio] 44100Hz 2ch s24be (3 bytes per sample) Video: no video Starting playback... Exiting... (End of file) $ mplayer test_s24le.wav MPlayer SVN-r36952 (C) 2000-2014 MPlayer Team Playing test_s24le.wav. libavformat version 54.63.104 (external) Audio only file format detected. Load subtitles in ./ ========================================================================== Opening audio decoder: [pcm] Uncompressed PCM audio decoder AUDIO: 44100 Hz, 2 ch, s24le, 2116.8 kbit/100.00% (ratio: 264600->264600) Selected audio codec: [pcm] afm: pcm (Uncompressed PCM) ========================================================================== AO: [sndio] 44100Hz 2ch s24le (3 bytes per sample) Video: no video Starting playback... Exiting... (End of file) --- libao2/ao_sndio.c.orig Mon Jan 6 23:02:58 2014 +++ libao2/ao_sndio.c Tue Feb 18 14:31:47 2014 @@ -103,6 +103,8 @@ static int init(int rate, int channels, int format, in } sio_initpar(&par); par.bits = af_fmt2bits(format); + par.bps = (par.bits + 7) >> 3; + par.msb = 1; par.sig = (format & AF_FORMAT_SIGN_MASK) == AF_FORMAT_SI; if (par.bits > 8) par.le = (format & AF_FORMAT_END_MASK) == AF_FORMAT_LE; @@ -118,7 +120,7 @@ static int init(int rate, int channels, int format, in mp_msg(MSGT_AO, MSGL_ERR, "ao2: couldn't get params\n"); goto err_out; } - if (par.bps != SIO_BPS(par.bits)) { + if (par.bits < 8 * par.bps && !par.msb) { mp_msg(MSGT_AO, MSGL_ERR, "ao2: unsupported format\n"); goto err_out; } -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

3 13

Strange behavior with audio delayed video files
by Ingo Brückl 02 Mar '14

02 Mar '14

When I use FFmpeg (ffmpeg -i file.mkv -itsoffset 60 -i file.mkv -codec copy -map 0:v -map 1:a sync.mkv) to adjust an audio delay (60 seconds in this example) I'm experiencing a strange behavior with MPlayer playback. The audio firstly starts at the very beginning as if no delay had been set. When I jump back to the beginning, it runs silent until 60 seconds have been played, and every seeking is OK, i.e. the audio is in sync now. So, is the first playback with immediate audio a MPlayer bug? Also, there is a short-time video hang-up where the audio starts (after 60 seconds). MPlayer or FFmpeg issue? Ingo

4 11

[PATCH] support -mouse-movements on OS/2
by KO Myung-Hun 02 Mar '14

02 Mar '14

Hi/2. This patch add -mouse-movements support to OS/2. -- KO Myung-Hun Using Mozilla SeaMonkey 2.7.2 Under OS/2 Warp 4 for Korean with FixPak #15 In VirtualBox v4.1.28 on Intel Core i7-3615QM 2.30GHz with 8GB RAM Korean OS/2 User Community : http://www.ecomstation.co.kr

2 12

[PATCH] GUI: Activate potmeter
by Hans-Dieter Kosch 01 Mar '14

01 Mar '14

The 'pressed' state of a 'potmeter' item is not initialised. By default it's 0 ('btnDisabled'), and the item is inactive. Attached patch to fix. Tested with the volume pot of default skin 'Blue'. Hans-Dieter

2 11

[PATCH] GCC: Do not warn about unused paramters (was Re: [MPlayer-cvslog] r36944 - in trunk/gui/win32: interface.c) playlist.c playlist.h
by Alexander Strasser 28 Feb '14

28 Feb '14

Hi Ingo, On 2014-02-25 23:53 +0100, Ingo Brückl wrote: > Reimar Döffinger wrote on Tue, 25 Feb 2014 23:23:04 +0100: > > > On 25.02.2014, at 23:14, Ingo Brückl <ib(a)wupperonline.de> wrote: > >> Reimar Döffinger wrote on Tue, 25 Feb 2014 22:44:55 +0100: > >> > >>> On 25.02.2014, at 22:29, Ingo Brückl <ib(a)wupperonline.de> wrote: > >>>> Reimar Döffinger wrote on Tue, 25 Feb 2014 20:43:51 +0100: > >>>> > >>>>> On Tue, Feb 25, 2014 at 07:39:10PM +0100, Ingo Brückl wrote: > >>>>>> Reimar Döffinger wrote on Tue, 25 Feb 2014 19:01:27 +0100: > >>>>>> > >>>>>>>> @@ -501,6 +501,8 @@ static unsigned __stdcall GuiThread(void > >>>>>>>> { > >>>>>>>> MSG msg; > >>>>>>>> > >>>>>>>> + (void) param; > >>>>>> > >>>>>>> This is a bit ugly and might not work in all compilers. > >>>>>> > >>>>>> I'd say it'll work on most (all?) compilers. Yes, it's ugly. > >>>>>> > >>>>>>> I think using av_unused on the parameter would be nicer, > >>>>>> > >>>>>> I don't mind using it, but it would be nice if gcc would warn if such a > >>>>>> parameter *will* be used later. (This is the only thing I dislike about the > >>>>>> (void) solution. It'll look strange if you forget to remove it later. With > >>>>>> av_unused it'll even look stranger.) > >>>> > >>>>> I don't think gcc warns, in part because it is sometimes used for > >>>>> variables that will only be used under some #ifdef. > >>>>> But I never actually checked... > >>>> > >>>> Do we have a chance to change the definition of av_unused to something like > >>>> > >>>> #define av_unused(v) __attribute__((unused)) v##_unused > >>>> > >>>> or should we define a mp_unused like this? > >> > >>> Couldn't you just rename the variable itself when you add the av_unused? > >>> Doesn't seem to me like there's that much benefit in having it hidden in > >>> a macro. > >> > >> The idea behind it is to only add or remove a mp_unused() without changing > >> any identifiers (and to automatically disable the usage of those marked > >> mp_unused()). > > > My point is: what is the big advantage of a diff from > > int somevar; > > to > > int mp_unused(somevar); > > instead of > > int av_unused somevar_unused; > > Not much difference in a diff I have to admit, but I think the first one > looks nicer and if you are going to mark a variable unused you don't have to > remember to rename the variable as well (or you won't notice if it may be > still used). The mp_unused() is a bit more "fail-safe" and easier to use, > IMO. IMHO just keep things in the spirit of the GCC attribute documentation: unused This attribute, attached to a variable, means that the variable is meant to be possibly unused. GCC does not produce a warning for this variable. BTW @ all: Why don't we have -Wno-unused-parameter in CFLAGS? I can hardly even think of a case where an unused parameter warning would be relevant. Also I cannot remember a single occasion where it mattered in practice. Adding the above mentioned flag eliminates 2000+ unused parameter warnings here if I did not mess up my measurements. Patch attached. Alexander

5 10

VOCTRL_GUI_NOWINDOW
by Ingo Brückl 27 Feb '14

27 Feb '14

VOCTRL_GUI_NOWINDOW seems superfluous and I would like to remove it. It is only used by vo_dxr3, a hardware which (if I get it right) can be used as both a TV card and an X11 overlay to display video. What I don't get: If someone would use it as TV card (no overlay), but try to start a video, what would MPlayer do? Would it know that there is no video out? And where in the source code would it recognize? If there will be no mpctx->sh_video in this case this would be fine with the GUI as well. Ingo

1 0