January 2014 - MPlayer-dev-eng - lists.mplayerhq.hu

Homepage skin download issue
by Ingo Brückl 09 Sep '15

09 Sep '15

Yesterday, I updated hwswskin to 1.3, but it still isn't downloadable. Is the generation of the skin download tarballs working? Ingo

3 8

Homepage DOCS needs update
by Ingo Brückl 24 Apr '14

24 Apr '14

If it's already on the to-do list ignore, but the documentation on the homepage doesn't get updated. Ingo

3 12

[PATCH] Add support for default of multiple video tracks
by Ingo Brückl 01 Feb '14

01 Feb '14

Works with the lavf demuxer and matroska video. Ingo

3 16

Taking a cleaning pass to stream/tvi_bsdbt848.c
by Brad Smith 31 Jan '14

31 Jan '14

Hi, I was going to submit a patch to MPlayer for sndio input support and part of it touches stream/tvi_bsdbt848.c. I wanted to ask if a developer could take one or more cleaning passes to stream/tvi_bsdbt848.c before I submit the diff. The code as is looks somewhat ugly and I don't want your eyes to bleed looking at the diff with it touching that file ;) -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

2 1

[PATCH] mencoder: support cinepak encoding via -ovc lavc
by u-2w2r＠aetey.se 27 Jan '14

27 Jan '14

Hello, Reflecting the addition of cinepak encoder to ffmpeg here follows the corresponding change for mencoder: ---- --- libmpcodecs/ve_lavc.c.ori 2014-01-25 22:47:58.861287479 +0100 +++ libmpcodecs/ve_lavc.c 2014-01-26 19:42:50.891709449 +0100 @@ -975,6 +977,8 @@ mux_v->bih->biCompression = mmioFOURCC('d', 'r', 'a', 'c'); else if (!strcasecmp(lavc_param_vcodec, "libvpx")) mux_v->bih->biCompression = mmioFOURCC('V', 'P', '8', '0'); + else if (!strcasecmp(lavc_param_vcodec, "cinepak")) + mux_v->bih->biCompression = mmioFOURCC('c', 'v', 'i', 'd'); else mux_v->bih->biCompression = mmioFOURCC(lavc_param_vcodec[0], lavc_param_vcodec[1], lavc_param_vcodec[2], lavc_param_vcodec[3]); /* FIXME!!! */ --- DOCS/man/en/mplayer.1.ori 2014-01-26 20:39:51.215795665 +0100 +++ DOCS/man/en/mplayer.1 2014-01-26 20:40:28.596233764 +0100 @@ -9647,6 +9647,8 @@ for lossless JPEG, ffv1 and svq1 .IPs "BGR32" for lossless JPEG and ffv1 +.IPs "RGB24" +for cinepak .RE .PD 1 . ---- Regards, Rl

3 3

[PATCH] mplayer: minor fix for cinepak decoding
by u-2w2r＠aetey.se 27 Jan '14

27 Jan '14

Hello, Cinepak does not support YV12 (which was earlier used as a kind of approximation of the actual internal Cinepak color space). Instead, the codec is interfacing now in RGB in accordance with its design. Thus, the reference to YV12 in etc/codecs.conf is erroneous and misleading. ---- --- etc/codecs.conf.ori 2014-01-26 20:22:34.111641284 +0100 +++ etc/codecs.conf 2014-01-26 20:22:04.591296247 +0100 @@ -1009,7 +1009,7 @@ fourcc cvid,CVID driver ffmpeg dll "cinepak" - out RGB24,YV12,BGR8 query + out RGB24,BGR8 query videocodec cvidvfw info "Cinepak Video" ---- Regards, Rl

2 2

[PATCH] configure: disable internal libmpeg2 by default.
by Reimar Döffinger 27 Jan '14

27 Jan '14

While the last tests showed that it can be slightly faster in some cases, the difference should not be relevant to the majority of users. In addition, the code is of not particularly high quality, so I consider it better/safer to have it disabled by default. I also welcome opinions on whether we should remove it completely (some time after the next release, whenever that might be). --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 2eba2c0..207a566 100755 --- a/configure +++ b/configure @@ -437,7 +437,7 @@ Codecs: --enable-libdca enable libdca support [autodetect] --disable-liba52 disable liba52 [autodetect] --disable-libmpeg2 disable libmpeg2 [autodetect] - --disable-libmpeg2-internal disable builtin libmpeg2 [autodetect] + --enable-libmpeg2-internal enable builtin libmpeg2 [disabled] --enable-musepack enable libmpcdec support (deprecated in favour of libavcodec) [disabled] --disable-libopencore_amrnb disable libopencore_amr narrowband [autodetect] --disable-libopencore_amrwb disable libopencore_amr wideband [autodetect] @@ -726,7 +726,7 @@ _mpg123=auto _liba52=auto _libdca=auto _libmpeg2=auto -_libmpeg2_internal=auto +_libmpeg2_internal=no _faad=auto _faac=auto _faac_lavc=auto -- 1.8.5.3

3 3

[PATCH] Fix bug with unicode font loading for font.desc files
by Ingo Brückl 26 Jan '14

26 Jan '14

It doesn't load unicode glyphs even if they are requested and available. Fix it by checking the font encoding rather than the subtitles encoding when loading the font. Ingo

1 0

[PATCH] Do not use non-literal arguments for mp_msg format string
by Alexander Strasser 26 Jan '14

26 Jan '14

Make the code easier to review and more robust against future changes. Fix ticket #2173 Signed-off-by: Alexander Strasser <eclipse7(a)gmx.net> --- The occurrence in gui/interface.c could actually be security relevant. I didn't investigate deeply and only had a quick look at the invocation of gmp_msg, where I think there is at least one that accepts user-controlled data. That could be used to craft something that gets interpreted by implementation of the function that is evaluating the strings as a format string which means possibilities depend on the exact implementation used. gui/interface.c | 2 +- stream/stream_radio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gui/interface.c b/gui/interface.c index 6e2387e..fdd6db4 100644 --- a/gui/interface.c +++ b/gui/interface.c @@ -1183,7 +1183,7 @@ void gmp_msg(int mod, int lev, const char *format, ...) vsnprintf(msg, sizeof(msg), format, va); va_end(va); - mp_msg(mod, lev, msg); + mp_msg(mod, lev, "%s", msg); if (mp_msg_test(mod, lev)) gtkMessageBox(MSGBOX_FATAL, msg); diff --git a/stream/stream_radio.c b/stream/stream_radio.c index afbea43..a91c051 100644 --- a/stream/stream_radio.c +++ b/stream/stream_radio.c @@ -1138,7 +1138,7 @@ static int open_s(stream_t *stream,int mode, void* opts, int* file_format) { mp_msg(MSGT_RADIO,MSGL_V,"\n"); if(priv->driver) - mp_msg(MSGT_RADIO, MSGL_INFO, priv->driver->info); + mp_msg(MSGT_RADIO, MSGL_INFO, "%s", priv->driver->info); else{ mp_msg(MSGT_RADIO, MSGL_INFO, MSGTR_RADIO_DriverUnknownStr,priv->radio_param->driver); close_s(stream); --

2 3

[PATCH] Fix bug with option '-fontconfig' and ass subtitles
by Ingo Brückl 24 Jan '14

24 Jan '14

The condition for using fontconfig is font_fontconfig >= 0 throughout all source files. Option '-nofontconfig' didn't have an effect so far. Ingo

2 5