August 2013 - MPlayer-dev-eng - lists.mplayerhq.hu

Homepage skin download issue
by Ingo Brückl 09 Sep '15

09 Sep '15

Yesterday, I updated hwswskin to 1.3, but it still isn't downloadable. Is the generation of the skin download tarballs working? Ingo

3 8

Homepage DOCS needs update
by Ingo Brückl 24 Apr '14

24 Apr '14

If it's already on the to-do list ignore, but the documentation on the homepage doesn't get updated. Ingo

3 12

[PATCH] xvmc: handle shm xvimage allocation error
by Marcin Slusarz 06 Jan '14

06 Jan '14

- handle xvimage/shm allocation failure and fallback to non-shm xv - assert xvimage->data_size!=0 because 0 size will lead to memory corruptions (I hit it because of bug in Nouveau's early xvmc implementation) Index: libvo/vo_xvmc.c =================================================================== --- libvo/vo_xvmc.c (wersja 34098) +++ libvo/vo_xvmc.c (kopia robocza) @@ -181,6 +181,15 @@ return cur_render->state || (cur_render->mpi && cur_render->mpi->usage_count); } +static void allocate_xvimage_non_shm(int xvimage_width, int xvimage_height, int xv_format) +{ + xvimage = (XvImage *) XvCreateImage(mDisplay, xv_port, xv_format, NULL, + xvimage_width, xvimage_height); + assert(xvimage->data_size); + xvimage->data = malloc(xvimage->data_size); + XSync(mDisplay,False); +} + static void allocate_xvimage(int xvimage_width,int xvimage_height,int xv_format) { /* @@ -188,7 +197,8 @@ * mit-shm this will bomb... trzing to fix ::atmos */ #ifdef HAVE_SHM - if ( mLocalDisplay && XShmQueryExtension( mDisplay ) ) Shmem_Flag = 1; + if ( mLocalDisplay && XShmQueryExtension( mDisplay ) ) + Shmem_Flag = 0; else { Shmem_Flag = 0; @@ -198,25 +208,41 @@ { xvimage = (XvImage *) XvShmCreateImage(mDisplay, xv_port, xv_format, NULL, xvimage_width, xvimage_height, &Shminfo); + if (!xvimage) + goto noshmimage; + assert(xvimage->data_size); Shminfo.shmid = shmget(IPC_PRIVATE, xvimage->data_size, IPC_CREAT | 0777); + if (Shminfo.shmid == -1) + goto shmgetfail; + Shminfo.shmaddr = (char *) shmat(Shminfo.shmid, 0, 0); + if ((long)Shminfo.shmaddr == -1) + goto shmatfail; + Shminfo.readOnly = False; xvimage->data = Shminfo.shmaddr; - XShmAttach(mDisplay, &Shminfo); + if (!XShmAttach(mDisplay, &Shminfo)) + goto shmattachfail; + XSync(mDisplay, False); shmctl(Shminfo.shmid, IPC_RMID, 0); } else #endif - { - xvimage = (XvImage *) XvCreateImage(mDisplay, xv_port, xv_format, NULL, xvimage_width, xvimage_height); - xvimage->data = malloc(xvimage->data_size); - XSync(mDisplay,False); - } -// memset(xvimage->data,128,xvimage->data_size); + allocate_xvimage_non_shm(xvimage_width, xvimage_height, xv_format); return; + +shmattachfail: + shmdt(Shminfo.shmaddr); +shmatfail: + shmctl(Shminfo.shmid, IPC_RMID, 0); +shmgetfail: + XFree(xvimage); +noshmimage: + Shmem_Flag = 0; + allocate_xvimage_non_shm(xvimage_width, xvimage_height, xv_format); } static void deallocate_xvimage(void)

4 6

New redmine bugtracker - feedbacks ?
by Nicolas Coiffier 22 Oct '13

22 Oct '13

Hi everyone !! Almost a month ago, there was a thread about moving the actual mplayer bugtracker to a new location. ( http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2013-July/071853.html) Since then, I've contact Moritz, and I've tried to migrate the actual bugtracker to a new one. I choose redmine (http://www.redmine.org/) because it was easier to install and configure than trac, but with the same kind of features. An old version (from the backup of August 7th) is available here, on my personnal server: http://redmine.ncoif.net I managed to import everything, and I did my best for the configuration. But during the import, I had to reset all the passwords, so you will have to click on the link "lost password" to create a new one. But the usernames are still the same. And since it's my personnal server, I don't have any ssl certificate, so I generated a self-signed one, which can create a warning in your browser. One last thing: it is possible to link bugs to the source code, usng SCM subversion, but I didn't had time to configure it yet, I plan to do it as soon as possible. So if you like it, and that it doesn't need too much load, then I can host the new bugtracker on my server. Any feedback is wellcome !! Nicolas

6 22

[PATCH] disable unix protocol on win32
by Gianluigi Tiesi 09 Sep '13

09 Sep '13

Hi all, win32 does not have unix protocol so it needs to be disabled in libvprotocol Attached patch disables it in "win32" if block, feel free to move in "mingw" if, I don't known if cygwin has unix sockets, I doubt it can be anyway useful. Regards -- Gianluigi Tiesi <sherpya(a)netfarm.it> EDP Project Leader Netfarm S.r.l. - http://www.netfarm.it/ Free Software: http://oss.netfarm.it/

4 8

[rfc] time to update binary codec packages?
by compn 19 Aug '13

19 Aug '13

are the codec packages listed on dload still useful? ffmpeg has rv30/rv40 support, should we remove real player codecs from the packs and upload new ones? what about indeo? do the ppc/mac/alpha packs have any non-native codecs now? i've just been throwing dlls into http://samples.ffmpeg.org/drivers32/new/ http://samples.ffmpeg.org/drivers32/newcodecpack/ -compn

1 0

[PATCH] Update vo_png to use updated API
by Jiang Jiang 14 Aug '13

14 Aug '13

avcodec_encode_video is deprecated. --- libvo/vo_png.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libvo/vo_png.c b/libvo/vo_png.c index ae93dcf..3556c81 100644 --- a/libvo/vo_png.c +++ b/libvo/vo_png.c @@ -146,9 +146,10 @@ config(uint32_t width, uint32_t height, uint32_t d_width, uint32_t d_height, uin static uint32_t draw_image(mp_image_t* mpi){ AVFrame pic; int buffersize; - int res; + int res, got_pkt; char buf[100]; FILE *outfile; + AVPacket pkt; // if -dr or -slices then do nothing: if(mpi->flags&(MP_IMGFLAG_DIRECT|MP_IMGFLAG_DRAW_CALLBACK)) return VO_TRUE; @@ -170,7 +171,10 @@ static uint32_t draw_image(mp_image_t* mpi){ outbuffer = av_malloc(buffersize); outbuffer_size = buffersize; } - res = avcodec_encode_video(avctx, outbuffer, outbuffer_size, &pic); + av_init_packet(&pkt); + pkt.data = outbuffer; + pkt.size = outbuffer_size; + res = avcodec_encode_video2(avctx, &pkt, &pic, &got_pkt); if(res < 0){ mp_msg(MSGT_VO,MSGL_WARN, MSGTR_LIBVO_PNG_ErrorInCreatePng); @@ -178,7 +182,7 @@ static uint32_t draw_image(mp_image_t* mpi){ return 1; } - fwrite(outbuffer, res, 1, outfile); + fwrite(outbuffer, pkt.size, 1, outfile); fclose(outfile); return VO_TRUE; -- 1.8.3.1 (Apple Git-46)

2 3

[PATCH] Fix FOURCC format check in mplayer.c
by Hans-Dieter Kosch 13 Aug '13

13 Aug '13

Hi, some time ago I sent a patch to fix FOURCC format check in mplayer.c; there was no response yet, so I send it again. The comment in the code says: /* Assume FOURCC if all bytes >= 0x20 (' ') */ But this can only work if it is checked byte by byte instead of a single long word (e.g. 0x2020211f >= 0x20202020 holds falsely true). Hans-Dieter

2 2

[PATCH] GUI: Reset aspect ratio after playing stream
by Hans-Dieter Kosch 11 Aug '13

11 Aug '13

Attached patch resets the aspect ratio after playing a stream in the GUI like pure MPlayer does (default -1 resp. -aspect cmdline arg) and makes Win and Gtk GUI consistent. Hans-Dieter

2 2

Should there be movie_aspect and stricter prescaling checks?
by Ingo Brückl 07 Aug '13

07 Aug '13

Option "aspect" (variable movie_aspect) is restricted to range 0.1..10.0 in cfg-common.h. Command switch_ratio allows any value for movie_aspect in command.c and there is already prescaling for sh->aspect > 0.01 in vd.c. Should there be checks for the above range and prescaling only start if greater or equal 0.1, or is it ok for the switch_ratio command to leave the range of the aspect option? Should the range start with 0.01? Ingo

2 3