May 2013 - MPlayer-dev-eng - lists.mplayerhq.hu

Homepage skin download issue
by Ingo Brückl 09 Sep '15

09 Sep '15

Yesterday, I updated hwswskin to 1.3, but it still isn't downloadable. Is the generation of the skin download tarballs working? Ingo

3 8

Homepage DOCS needs update
by Ingo Brückl 24 Apr '14

24 Apr '14

If it's already on the to-do list ignore, but the documentation on the homepage doesn't get updated. Ingo

3 12

[PATCH] xvmc: handle shm xvimage allocation error
by Marcin Slusarz 06 Jan '14

06 Jan '14

- handle xvimage/shm allocation failure and fallback to non-shm xv - assert xvimage->data_size!=0 because 0 size will lead to memory corruptions (I hit it because of bug in Nouveau's early xvmc implementation) Index: libvo/vo_xvmc.c =================================================================== --- libvo/vo_xvmc.c (wersja 34098) +++ libvo/vo_xvmc.c (kopia robocza) @@ -181,6 +181,15 @@ return cur_render->state || (cur_render->mpi && cur_render->mpi->usage_count); } +static void allocate_xvimage_non_shm(int xvimage_width, int xvimage_height, int xv_format) +{ + xvimage = (XvImage *) XvCreateImage(mDisplay, xv_port, xv_format, NULL, + xvimage_width, xvimage_height); + assert(xvimage->data_size); + xvimage->data = malloc(xvimage->data_size); + XSync(mDisplay,False); +} + static void allocate_xvimage(int xvimage_width,int xvimage_height,int xv_format) { /* @@ -188,7 +197,8 @@ * mit-shm this will bomb... trzing to fix ::atmos */ #ifdef HAVE_SHM - if ( mLocalDisplay && XShmQueryExtension( mDisplay ) ) Shmem_Flag = 1; + if ( mLocalDisplay && XShmQueryExtension( mDisplay ) ) + Shmem_Flag = 0; else { Shmem_Flag = 0; @@ -198,25 +208,41 @@ { xvimage = (XvImage *) XvShmCreateImage(mDisplay, xv_port, xv_format, NULL, xvimage_width, xvimage_height, &Shminfo); + if (!xvimage) + goto noshmimage; + assert(xvimage->data_size); Shminfo.shmid = shmget(IPC_PRIVATE, xvimage->data_size, IPC_CREAT | 0777); + if (Shminfo.shmid == -1) + goto shmgetfail; + Shminfo.shmaddr = (char *) shmat(Shminfo.shmid, 0, 0); + if ((long)Shminfo.shmaddr == -1) + goto shmatfail; + Shminfo.readOnly = False; xvimage->data = Shminfo.shmaddr; - XShmAttach(mDisplay, &Shminfo); + if (!XShmAttach(mDisplay, &Shminfo)) + goto shmattachfail; + XSync(mDisplay, False); shmctl(Shminfo.shmid, IPC_RMID, 0); } else #endif - { - xvimage = (XvImage *) XvCreateImage(mDisplay, xv_port, xv_format, NULL, xvimage_width, xvimage_height); - xvimage->data = malloc(xvimage->data_size); - XSync(mDisplay,False); - } -// memset(xvimage->data,128,xvimage->data_size); + allocate_xvimage_non_shm(xvimage_width, xvimage_height, xv_format); return; + +shmattachfail: + shmdt(Shminfo.shmaddr); +shmatfail: + shmctl(Shminfo.shmid, IPC_RMID, 0); +shmgetfail: + XFree(xvimage); +noshmimage: + Shmem_Flag = 0; + allocate_xvimage_non_shm(xvimage_width, xvimage_height, xv_format); } static void deallocate_xvimage(void)

4 6

[PATCH] ao_jack: add "connect" suboption
by Markus Appel 03 Jun '13

03 Jun '13

Hi, here is a small patch to add a "(no)connect" option to the jack audio output module. The (unchanged) default behavior of the module is to limit the number of channels to the number of output ports found on the matching jack client and create one-to-one connections. If you want to get all available audio channels, you can now use "-ao jack:noconnect" and manually create whatever connections you desire. Cheers, Markus

2 6

[PATCH] DJGPP support
by Fabrizio Gennari 17 May '13

17 May '13

Hello. This patch allows compilation of MPlayer for MS-DOS using DJGPP dev environment. It applies to latest SVN rev 35946, and is based on one made by Khusraw of bttr-software.de forum, who ported SVN rev 34661 (available at http://omploader.org/vY3A4Mg) Cross-compilation is made by adding --target=i386-DJGPP to configure's parameters. In order to play sounds, it needs a special version of the WSS library, that can be found at http://rayer.g6.cz/download/wss.zip (plus the relevant --extra-cflags and --extra-ldflags so configure can detect it). A patch also needs to be applied to FFmpeg as well, see https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2013-March/140219.html Regards, Fabrizio

4 5

va-api support
by Igor Gnatenko 16 May '13

16 May '13

Hi all! How is the inclusion of va-api into the master branch mplayer? -- Best Regards, Igor Gnatenko

6 7

Patch for build failure with clang, lvvm, etc. on Mac OSX > 10.6
by Aubin Paul 15 May '13

15 May '13

Submitted this via Bugzilla but not sure if that's the right place anymore: http://bugzilla.mplayerhq.hu/show_bug.cgi?id=2134#c0 Darwin-specific changes to fix compilation on current Mac OS X/Xcode/clang It is not possible to build Mplayer on Mac OS X > 10.6 due to a few errors in the build system. The following changes (all can be implemented in configure for the darwin/x86_64 target) allow mplayer to build properly. 1. using -DPIC with YASM to allow ffmpeg to compile properly 2. Using -Wl,-pie to fix linking since -pie -fpie is incorrect under Darwin's clang 3. --mdynamic-no-pic breaks compilation due to security features in newer versions of Mac OS X Clang does support PIC but the configure check breaks due to the inclusion of -fpie -pie so I added a separate check for clang and darwin to include the right flags. After that, PIC is successfully detected and works fine. Attached a patch which fixes the issue and should not affect any other platforms.

2 1

Improve bluray chapter support
by Olivier Rolland 15 May '13

15 May '13

Hello, Here are some patches to improve chapter support for bluray. The 2 following patches fix issues in the current code. 0001-Fix-chapter-selection.patch: According to the documentation, -bluray-chapter indicates the chapter to start playing from, the default being 1. However, manually specifying -bluray-chapter 1 starts playing from chapter 2 (-bluray-chapter 0 starts playing from chapter 1). Moreover, specifying a chapter number greater than or equal to the number of chapters starts playing at position -1 because the chapter number is not clamped correctly. This patch fixes all that. 0002-Fix-current-chapter.patch: The current chapter is always the start chapter. With this patch, it is indeed the chapter currently playing. The 3 following patches add support for a chapter to stop playing at. For that, it is necessary to make stream_bluray.c use the same variables for chapters as stream_dvd.c, namely dvd_chapter and dvd_last_chapter. It then has to use the same function to parse chapter ranges. 0003-Extract-chapter-parsing.patch: This patch moves the chapter parsing function from stream_dvd.c/h to stream.c/h. 0004-Add-last-chapter-support.patch: This patch replaces bluray specific chapter variables with dvd variables, makes use of the same command line option for dvd and bluray chapter selection, keeps the bluray specific command line option for compatibility sake and adds full support for end chapter of bluray. It also updates the man page. 0005-Remove-bluray-chapter.patch: This patch removes the bluray specific command line option for chapter selection from the code and the man page. Please, review and comment. Olivier

3 7

[PATCH] Correct bogus #ifs for codec ids (was: [MPlayer-cvslog] r36172 - trunk/libmpdemux/demux_lavf.c)
by Dominik 'Rathann' Mierzejewski 15 May '13

15 May '13

Hi, On Thursday, 18 April 2013 at 23:54, cboesch wrote: [...] > Modified: trunk/libmpdemux/demux_lavf.c > ============================================================================== > --- trunk/libmpdemux/demux_lavf.c Mon Apr 15 04:23:17 2013 (r36171) > +++ trunk/libmpdemux/demux_lavf.c Thu Apr 18 23:54:53 2013 (r36172) > @@ -441,7 +441,11 @@ static void handle_stream(demuxer_t *dem > type = 't'; > else if (codec->codec_id == AV_CODEC_ID_MOV_TEXT) > type = 'm'; > - else if (codec->codec_id == AV_CODEC_ID_SSA) > + else if (codec->codec_id == AV_CODEC_ID_SSA > +#if LIBAVUTIL_VERSION_MICRO >= 100 > + || codec->codec_id == AV_CODEC_ID_ASS > +#endif /* LIBAVUTIL_VERSION_MICRO >= 100 */ > + ) > type = 'a'; > else if (codec->codec_id == AV_CODEC_ID_DVD_SUBTITLE) > type = 'v'; I'm not sure why this one and several others before were added with that #if condition, but it's clearly wrong. I'm attaching a patch which corrects some of these. Regards, Dominik -- MPlayer http://mplayerhq.hu | RPM Fusion http://rpmfusion.org There should be a science of discontent. People need hard times and oppression to develop psychic muscles. -- from "Collected Sayings of Muad'Dib" by the Princess Irulan

3 6

[PATCH] Set default Blu-ray device
by Brad Smith 12 May '13

12 May '13

Submitting a local patch from our OpenBSD ports tree to set a default Blu-ray device. Index: configure =================================================================== --- configure (revision 36233) +++ configure (working copy) @@ -5853,7 +5853,7 @@ fi #if os2 -# set default CD/DVD devices +# set default CD/DVD/Blu-ray devices if win32 || os2 ; then default_cdrom_device="D:" elif darwin ; then @@ -5876,10 +5876,13 @@ if win32 || os2 || dragonfly || freebsd || openbsd || sunos || amigaos ; then default_dvd_device=$default_cdrom_device + default_bluray_device=$default_cdrom_device elif darwin ; then default_dvd_device="/dev/rdiskN" + default_bluray_device="/dev/rdiskN" else default_dvd_device="/dev/dvd" + default_bluray_device="/dev/dvd" fi @@ -8758,6 +8761,7 @@ /* Blu-ray/DVD/VCD/CD */ #define DEFAULT_CDROM_DEVICE "$default_cdrom_device" #define DEFAULT_DVD_DEVICE "$default_dvd_device" +#define DEFAULT_BLURAY_DEVICE "$default_bluray_device" $def_bluray $def_cddb $def_cdparanoia Index: stream/stream_bluray.c =================================================================== --- stream/stream_bluray.c (revision 36233) +++ stream/stream_bluray.c (working copy) @@ -254,6 +254,8 @@ device = p->device; else if (bluray_device) device = bluray_device; + else + device = DEFAULT_BLURAY_DEVICE; if (!device) { mp_msg(MSGT_OPEN, MSGL_ERR, MSGTR_BlurayNoDevice); -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.

2 8