August 2012 - MPlayer-dev-eng - lists.mplayerhq.hu

Homepage skin download issue
by Ingo Brückl 09 Sep '15

09 Sep '15

Yesterday, I updated hwswskin to 1.3, but it still isn't downloadable. Is the generation of the skin download tarballs working? Ingo

3 8

Homepage DOCS needs update
by Ingo Brückl 24 Apr '14

24 Apr '14

If it's already on the to-do list ignore, but the documentation on the homepage doesn't get updated. Ingo

3 12

[PATCH] xvmc: handle shm xvimage allocation error
by Marcin Slusarz 06 Jan '14

06 Jan '14

- handle xvimage/shm allocation failure and fallback to non-shm xv - assert xvimage->data_size!=0 because 0 size will lead to memory corruptions (I hit it because of bug in Nouveau's early xvmc implementation) Index: libvo/vo_xvmc.c =================================================================== --- libvo/vo_xvmc.c (wersja 34098) +++ libvo/vo_xvmc.c (kopia robocza) @@ -181,6 +181,15 @@ return cur_render->state || (cur_render->mpi && cur_render->mpi->usage_count); } +static void allocate_xvimage_non_shm(int xvimage_width, int xvimage_height, int xv_format) +{ + xvimage = (XvImage *) XvCreateImage(mDisplay, xv_port, xv_format, NULL, + xvimage_width, xvimage_height); + assert(xvimage->data_size); + xvimage->data = malloc(xvimage->data_size); + XSync(mDisplay,False); +} + static void allocate_xvimage(int xvimage_width,int xvimage_height,int xv_format) { /* @@ -188,7 +197,8 @@ * mit-shm this will bomb... trzing to fix ::atmos */ #ifdef HAVE_SHM - if ( mLocalDisplay && XShmQueryExtension( mDisplay ) ) Shmem_Flag = 1; + if ( mLocalDisplay && XShmQueryExtension( mDisplay ) ) + Shmem_Flag = 0; else { Shmem_Flag = 0; @@ -198,25 +208,41 @@ { xvimage = (XvImage *) XvShmCreateImage(mDisplay, xv_port, xv_format, NULL, xvimage_width, xvimage_height, &Shminfo); + if (!xvimage) + goto noshmimage; + assert(xvimage->data_size); Shminfo.shmid = shmget(IPC_PRIVATE, xvimage->data_size, IPC_CREAT | 0777); + if (Shminfo.shmid == -1) + goto shmgetfail; + Shminfo.shmaddr = (char *) shmat(Shminfo.shmid, 0, 0); + if ((long)Shminfo.shmaddr == -1) + goto shmatfail; + Shminfo.readOnly = False; xvimage->data = Shminfo.shmaddr; - XShmAttach(mDisplay, &Shminfo); + if (!XShmAttach(mDisplay, &Shminfo)) + goto shmattachfail; + XSync(mDisplay, False); shmctl(Shminfo.shmid, IPC_RMID, 0); } else #endif - { - xvimage = (XvImage *) XvCreateImage(mDisplay, xv_port, xv_format, NULL, xvimage_width, xvimage_height); - xvimage->data = malloc(xvimage->data_size); - XSync(mDisplay,False); - } -// memset(xvimage->data,128,xvimage->data_size); + allocate_xvimage_non_shm(xvimage_width, xvimage_height, xv_format); return; + +shmattachfail: + shmdt(Shminfo.shmaddr); +shmatfail: + shmctl(Shminfo.shmid, IPC_RMID, 0); +shmgetfail: + XFree(xvimage); +noshmimage: + Shmem_Flag = 0; + allocate_xvimage_non_shm(xvimage_width, xvimage_height, xv_format); } static void deallocate_xvimage(void)

4 6

GUI and vo_x11 functions
by Ingo Brückl 02 Mar '13

02 Mar '13

I'm about to commit the vo_x11_ewmh_fullscreen() patch which adds a window parameter to the function, but I'm not quite sure whether this really is ok, although I got permission. The question is whether vo_x11_ewmh_fullscreen() and all the other vo_x11 functions should only operate on the global vo variables (like vo_window in that case) or whether they should be reusable functions, offering services for whoever wants to call them (the GUI in my case). The reason why I raise this issue is that the GUI does call three other vo_x11 functions (with relative success), namely vo_x11_decoration() vo_x11_sizehint() vo_x11_setlayer() While vo_x11_decoration() seems to be problem-free (it has some useful parameters, but uses global variables as well), vo_x11_sizehint() mostly uses global variables (which causes some X errors with the GUI then if called at a time when these variables aren't yet set). vo_x11_setlayer() is pointlessly called by the GUI, because it doesn't do anything in case of WinID >= 0. So, what is the right way to continue? Setting all necessary global vo variables in the GUI - even prior to the vo driver (vo_window is known to become WinID later anyway, for example), trying to modestly patch these four functions so that they can be reused or copy the code and letting the GUI use its own copies? All these four functions are window specific and window handling should be GUI's task although commonly used code is convenient. Pros and cons should be obvious. Ingo

3 16

Performance of libdvdread/libdvdcss
by Vicente Sendra 01 Sep '12

01 Sep '12

I'm new to mplayer developers mailing list, i hope this is the right place to talk about this. Firs of all, i am compiling for Win32 with mingw, and testing on my windows xp laptop, but i think all this is ok for all other platforms. I've been developing a new system for double frame rate output (for filters like yadif and tfields) that solves 3 problems with mplayer: 1-You get exact double framerate timing, old system did 2 continuous page flips, resulting in two frames very close in time, depending on your video card refresh rate. 2-New system always pushes filter frames to queue and gets them in mplayer.c main loop with vf_output_queued_frame, so they can be framedropped if needed. 3-New framedrop system for framerates > video card refresh rate, that resulted in 100% cpu usage with vsync activated, because page flip gets blocked with full buffer until next video card refresh. New system checks page flip time and if it gets too big, it starts dropping interpolated frames, if no interpolated frames or if dropping them is not enougth, only then full frames are dropped, this problem is very old but now it's very annoying because most lcd monitors can't go > 60hz (my old CRT was set to 75Hz, so no problem here). http://forum.doom9.org/showthread.php?p=1333149 http://www.nvnews.net/vbulletin/showthread.php?t=106409 I've got this system working with r34401 (i was getting compile errors from las r35119), but debugging this system has shown me the low performance of cache system when using "Win2K API" for dvd access (vs "libc" acess). Cache doesn't fill fast enough, even if there is cpu time available and, of course, media is fast enough. Cache works ok with libc and same settings, double frame rate and same dvd. To test it i'm using this command line options: for win32k: mplayer.exe -ao dsound:device=0 -vf-add yadif=1 -dvd-device K:\ -dvdangle 1 -msglevel all=9 for libc: mplayer.exe -ao dsound:device=0 -vf-add yadif=1 -dvd-device K:\VIDEO_TS -dvdangle 1 -msglevel all=9 (i set DVDCSS_VERBOSE environment variable to 2 to see more info about css) DVD activity led performs very different with the two access methods, win32k blinks a lot, indicating a lot of activity, when in fact it fills cache at a lower speed, with libc, it barely lights up but it fills cache pretty quickly. Any ideas on how can i improve reading with win32k. How can libc be used with scrambled DVDs?, it reports: Device K:\VIDEO_TS inaccessible, CSS authentication not available (see following logs). Here are the logs of libdvdcss: ########## win32k ######### libdvdread: Using libdvdcss version 1.2.10 for DVD access libdvdcss debug: opening target `K:' libdvdcss debug: using Win2K API for access libdvdcss debug: disc reports copyright information 0x0 libdvdcss debug: drive region mask 0xfd, RPC-II, region code set libdvdread: Attempting to retrieve all CSS keys libdvdread: This can take a _long_ time, please be patient libdvdread: Found 3 VTS's libdvdread: Elapsed time 0 ######### libc: ####### libdvdread: Using libdvdcss version 1.2.10 for DVD access libdvdcss debug: opening target `K:\VIDEO_TS' libdvdcss debug: using libc for access libdvdcss debug: cannot open K:\VIDEO_TS (Permission denied) libdvdcss error: failed to open device libdvdread: Could not open K:\VIDEO_TS with libdvdcss. libdvdread: Can't open K:\VIDEO_TS for reading libdvdread: Device K:\VIDEO_TS inaccessible, CSS authentication not available. libdvdcss debug: opening target `K:\VIDEO_TS/VIDEO_TS.IFO' libdvdcss debug: using libc for access libdvdcss debug: opening target `K:\VIDEO_TS/VTS_01_0.IFO' libdvdcss debug: using libc for access libdvdcss debug: opening target `K:\VIDEO_TS/VTS_01_1.VOB' libdvdcss debug: using libc for access libdvdcss debug: cracking title key at block 0 libdvdcss debug: end of title reached libdvdcss debug: successful attempts 0/0, scrambled blocks 0/2000 libdvdcss debug: no scrambled sectors found libdvdcss debug: title key is 00:00:00:00:00 libdvdcss debug: unencrypted title

2 11

[PATCH] vf_ass: support uyvy and yuy2 directly
by Xidorn Quan 30 Aug '12

30 Aug '12

Hi, This patch adds uyvy and yuy2 format support for vf_ass. uyvy and yuy2 pictures then needn't to be convert by scale anymore when using ass. Though, I think the code can probably be optimized more by using sth like MMX, or considering more about CPU cache. But I'm not experienced in doing so. Best Regards, Xidorn Quan

3 13

[PATCH] add vda decoder support for mplayer
by Xidorn Quan 28 Aug '12

28 Aug '12

Hi, FFmpeg has applied my patch of implementing vda decoder. This patch add vda decoder support for mplayer. Best Regards, Xidorn Quan

3 2

[PATCH] fix compiling issue with ffmpeg
by Xidorn Quan 28 Aug '12

28 Aug '12

Hi, This patch fixes an issue of compiling with ffmpeg. Regards, Xidorn Quan

1 0

proposed new feature: ppm decoder
by Hernan Badino 28 Aug '12

28 Aug '12

Hi All, I'm sending you a patch file for a new ppm decoder. The proposed changes add the capability of to using ppm and pgm as input files (e.g., using mf://*.ppm). The new changes don't add any new dependency, since ppm and pgm are very easy to decode. I've wrote the code in plain C. The changes are a new file libmpcodecs/vd_mppm.c, and just a few line insertions in libmpcodecs/vd.c libmpdemux/demux_mf.c etc/codecs.conf and Makefile. I've tested the code on correct and corrupted ppm, pgm, and it works as expected. I've also added a long comment in the libmpcodecs/vd_mppm.c file for what I think it is a bug. This comment should probably be removed before submitting the file. Please, let me know if you have any questions. Hernan

3 4

why my mplayer-android porting have lower performance than many other players ?
by lean fu 26 Aug '12

26 Aug '12

Hi list:: at first,i'm sorry to ask so preliminary problems here,but i really need help from experts. i tried to play 720p rmvb or mkv videos on an android phone which with 600Mhz arm processor,most of time , the picture nearly totally stop to refresh,and the strange thing is audio can always keep smooth,i tested " -framedrop,lowres=1:fast:skiploopfilter=all ..." in slave mode, but seems nothing get better,and picture become worse. I want mplayer only demux files and skip all decoding steps of P and B frames until the next I frame comes,another words,i want mplayer try it's best to catch the audio. i can accept picture loss,but can't accept picture seems completly halt ,how can i do this ?, any rely is appreciated, thanks.

3 5