November 2012 - MPlayer-dev-eng - lists.mplayerhq.hu

Homepage skin download issue
by Ingo Brückl 09 Sep '15

09 Sep '15

Yesterday, I updated hwswskin to 1.3, but it still isn't downloadable. Is the generation of the skin download tarballs working? Ingo

3 8

Homepage DOCS needs update
by Ingo Brückl 24 Apr '14

24 Apr '14

If it's already on the to-do list ignore, but the documentation on the homepage doesn't get updated. Ingo

3 12

[PATCH] xvmc: handle shm xvimage allocation error
by Marcin Slusarz 06 Jan '14

06 Jan '14

- handle xvimage/shm allocation failure and fallback to non-shm xv - assert xvimage->data_size!=0 because 0 size will lead to memory corruptions (I hit it because of bug in Nouveau's early xvmc implementation) Index: libvo/vo_xvmc.c =================================================================== --- libvo/vo_xvmc.c (wersja 34098) +++ libvo/vo_xvmc.c (kopia robocza) @@ -181,6 +181,15 @@ return cur_render->state || (cur_render->mpi && cur_render->mpi->usage_count); } +static void allocate_xvimage_non_shm(int xvimage_width, int xvimage_height, int xv_format) +{ + xvimage = (XvImage *) XvCreateImage(mDisplay, xv_port, xv_format, NULL, + xvimage_width, xvimage_height); + assert(xvimage->data_size); + xvimage->data = malloc(xvimage->data_size); + XSync(mDisplay,False); +} + static void allocate_xvimage(int xvimage_width,int xvimage_height,int xv_format) { /* @@ -188,7 +197,8 @@ * mit-shm this will bomb... trzing to fix ::atmos */ #ifdef HAVE_SHM - if ( mLocalDisplay && XShmQueryExtension( mDisplay ) ) Shmem_Flag = 1; + if ( mLocalDisplay && XShmQueryExtension( mDisplay ) ) + Shmem_Flag = 0; else { Shmem_Flag = 0; @@ -198,25 +208,41 @@ { xvimage = (XvImage *) XvShmCreateImage(mDisplay, xv_port, xv_format, NULL, xvimage_width, xvimage_height, &Shminfo); + if (!xvimage) + goto noshmimage; + assert(xvimage->data_size); Shminfo.shmid = shmget(IPC_PRIVATE, xvimage->data_size, IPC_CREAT | 0777); + if (Shminfo.shmid == -1) + goto shmgetfail; + Shminfo.shmaddr = (char *) shmat(Shminfo.shmid, 0, 0); + if ((long)Shminfo.shmaddr == -1) + goto shmatfail; + Shminfo.readOnly = False; xvimage->data = Shminfo.shmaddr; - XShmAttach(mDisplay, &Shminfo); + if (!XShmAttach(mDisplay, &Shminfo)) + goto shmattachfail; + XSync(mDisplay, False); shmctl(Shminfo.shmid, IPC_RMID, 0); } else #endif - { - xvimage = (XvImage *) XvCreateImage(mDisplay, xv_port, xv_format, NULL, xvimage_width, xvimage_height); - xvimage->data = malloc(xvimage->data_size); - XSync(mDisplay,False); - } -// memset(xvimage->data,128,xvimage->data_size); + allocate_xvimage_non_shm(xvimage_width, xvimage_height, xv_format); return; + +shmattachfail: + shmdt(Shminfo.shmaddr); +shmatfail: + shmctl(Shminfo.shmid, IPC_RMID, 0); +shmgetfail: + XFree(xvimage); +noshmimage: + Shmem_Flag = 0; + allocate_xvimage_non_shm(xvimage_width, xvimage_height, xv_format); } static void deallocate_xvimage(void)

4 6

Re: [MPlayer-dev-eng] MPlayer fails to build with live-2012.08.20
by Ross Finlayson 22 Apr '13

22 Apr '13

> Does adding > #define RTSPCLIENT_SYNCHRONOUS_INTERFACE 1 > to the configure test also fixes this problem? It probably will. I should warn you, though, that the synchronous "RTSPClient" interface is considered deprecated, and will eventually be removed. You should plan on updating your LIVE555 interface code to use the new asynchronous interface instead (as VLC did a couple of years ago). Ross Finlayson Live Networks, Inc. http://www.live555.com/

2 2

GUI and vo_x11 functions
by Ingo Brückl 02 Mar '13

02 Mar '13

I'm about to commit the vo_x11_ewmh_fullscreen() patch which adds a window parameter to the function, but I'm not quite sure whether this really is ok, although I got permission. The question is whether vo_x11_ewmh_fullscreen() and all the other vo_x11 functions should only operate on the global vo variables (like vo_window in that case) or whether they should be reusable functions, offering services for whoever wants to call them (the GUI in my case). The reason why I raise this issue is that the GUI does call three other vo_x11 functions (with relative success), namely vo_x11_decoration() vo_x11_sizehint() vo_x11_setlayer() While vo_x11_decoration() seems to be problem-free (it has some useful parameters, but uses global variables as well), vo_x11_sizehint() mostly uses global variables (which causes some X errors with the GUI then if called at a time when these variables aren't yet set). vo_x11_setlayer() is pointlessly called by the GUI, because it doesn't do anything in case of WinID >= 0. So, what is the right way to continue? Setting all necessary global vo variables in the GUI - even prior to the vo driver (vo_window is known to become WinID later anyway, for example), trying to modestly patch these four functions so that they can be reused or copy the code and letting the GUI use its own copies? All these four functions are window specific and window handling should be GUI's task although commonly used code is convenient. Pros and cons should be obvious. Ingo

3 16

[PATCH 0/7] stream ftp: Support longer file names
by Alexander Strasser 27 Jan '13

27 Jan '13

Due to the concerns raised recently about long file names with stream ftp, this series aims to make longer ones possible. After the first 6 patches are applied it is finally possible to change the command buffer size which is mainly responsible for the supported file name length. I increase that size in patch 7. But I still had some problems with very long file names at some point when testing here locally. But I could use much longer names than are supported now. Seems to be a server problem but I am not very sure about it. So testing is very welcome especially with long names and with different FTP servers at the remote end. I also would welcome code reviews on this. Alexander Strasser (7): stream ftp: readline: Fix off-by-one error stream ftp: readline: Always initialize output parameter buf stream ftp: readline: Always try to read complete lines stream ftp: Only send QUIT command if connected stream ftp: Create buffers before opening control connection stream ftp: Allocate command buffer on-heap stream ftp: Increase command buffer size stream/stream_ftp.c | 96 ++++++++++++++++++++++++++++++++++++++--------------- 1 file changed, 69 insertions(+), 27 deletions(-) -- 1.7.10.2.552.gaa3bb87

9 100

how to enable hardware acceleration video decoding based on stagefright of android ?
by lean fu 14 Jan '13

14 Jan '13

hi list: ffmpeg 0.10 or later has "libstagefright.cpp" providing hardware acceleration on android , and there's an building script at " ffmpeg/tool/build_libstagefright" for compiling this feature , but unfortunate, 'configure' of mplayer don't support "--enable-libstagefright-h264" , i have to modify config.h and config.mak to add some stagefright related macro manually. and change the 'name' member of ff_libstagefright_h264_decoder from "libstagefright_h264" to "h264". after these changes, when play a file contains h264, procedure will call into 'Stagefright_decode_frame'. but the picture looks abnormal , sometimes appears full blue(or green) screen,for some 1080p files,even throw fatal errors. had somebody get the stagefright features works successfully? and is there some more simple way that i can integrate the stagefright feature into my android port of mplayer ? thanks !

3 3

int vs. bool
by Ingo Brückl 03 Dec '12

03 Dec '12

Are there any objections to using data type bool, or are there disadvantages or possible problems? Ingo

3 8

[PATCH 1/4] stream ftp: Pass full buffer size to snprintf
by Alexander Strasser 26 Nov '12

26 Nov '12

Previously the buffer size was always passed as one less than the underlying buffer's size. This is not using the underlying buffer to its full potential according to the C99 standard. The last byte of the buffers were never used. No vulnerabilities should have been caused by this mistake because the strings stored in the buffers were zero terminated at all times. Neither were out-of-array writes nor reads possible. Signed-off-by: Alexander Strasser <eclipse7(a)gmx.net> --- stream/stream_ftp.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/stream/stream_ftp.c b/stream/stream_ftp.c index 4d0925d..372051a 100644 --- a/stream/stream_ftp.c +++ b/stream/stream_ftp.c @@ -281,7 +281,7 @@ static int FtpOpenPort(struct stream_priv_s* p) { sscanf(par+1,"%u,%u,%u,%u,%u,%u",&num[0],&num[1],&num[2], &num[3],&num[4],&num[5]); - snprintf(str,127,"%d.%d.%d.%d",num[0],num[1],num[2],num[3]); + snprintf(str,sizeof(str),"%d.%d.%d.%d",num[0],num[1],num[2],num[3]); fd = connect2Server(str,(num[4]<<8)+num[5],0); if(fd < 0) @@ -301,7 +301,7 @@ static int FtpOpenData(stream_t* s,off_t newpos) { if(s->fd < 0) return 0; if(newpos > 0) { - snprintf(p->cmd_buf,CMD_BUFSIZE - 1,"REST %"PRId64, (int64_t)newpos); + snprintf(p->cmd_buf,CMD_BUFSIZE,"REST %"PRId64, (int64_t)newpos); resp = FtpSendCmd(p->cmd_buf,p,rsp_txt); if(resp != 3) { @@ -311,7 +311,7 @@ static int FtpOpenData(stream_t* s,off_t newpos) { } // Get the file - snprintf(p->cmd_buf,CMD_BUFSIZE - 1,"RETR %s",p->filename); + snprintf(p->cmd_buf,CMD_BUFSIZE,"RETR %s",p->filename); resp = FtpSendCmd(p->cmd_buf,p,rsp_txt); if(resp != 1) { @@ -464,12 +464,12 @@ static int open_f(stream_t *stream,int mode, void* opts, int* file_format) { } // Login - snprintf(p->cmd_buf,CMD_BUFSIZE - 1,"USER %s",p->user); + snprintf(p->cmd_buf,CMD_BUFSIZE,"USER %s",p->user); resp = FtpSendCmd(p->cmd_buf,p,rsp_txt); // password needed if(resp == 3) { - snprintf(p->cmd_buf,CMD_BUFSIZE - 1,"PASS %s",p->pass); + snprintf(p->cmd_buf,CMD_BUFSIZE,"PASS %s",p->pass); resp = FtpSendCmd(p->cmd_buf,p,rsp_txt); if(resp != 2) { mp_msg(MSGT_OPEN,MSGL_ERR, "[ftp] command '%s' failed: %s\n",p->cmd_buf,rsp_txt); @@ -491,7 +491,7 @@ static int open_f(stream_t *stream,int mode, void* opts, int* file_format) { } // Get the filesize - snprintf(p->cmd_buf,CMD_BUFSIZE - 1,"SIZE %s",p->filename); + snprintf(p->cmd_buf,CMD_BUFSIZE,"SIZE %s",p->filename); resp = FtpSendCmd(p->cmd_buf,p,rsp_txt); if(resp != 2) { mp_msg(MSGT_OPEN,MSGL_WARN, "[ftp] command '%s' failed: %s\n",p->cmd_buf,rsp_txt); -- 1.7.10.2.552.gaa3bb87

3 8

[patch] fix compilation error in gui/win32/interface.c
by Stephen Sheldon 24 Nov '12

24 Nov '12

I am getting a compilation error in gui/win32/interface.c. x86_64-w64-mingw32-gcc -MD -MP -Wundef -Wall -Wno-switch -Wno-parentheses -Wpointer-arith -Wredundant-decls -Wstrict-prototypes -Wmissing-prototypes -Wdisabled-optimization -Wno-pointer-sign -Wdeclaration-after-statement -std=gnu99 -Werror-implicit-function-declaration -O4 -march=native -mtune=native -pipe -ffast-math -fomit-frame-pointer -fno-tree-vectorize -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE64_SOURCE -Ilibdvdread4 -I. -Iffmpeg -I/mingw64/include -fno-common -DPIC -I/mingw64/include/freetype2 -I/mingw64/include -I/mingw64/include -Wno-strict-prototypes -c -o gui/win32/interface.o gui/win32/interface.c In file included from gui/win32/interface.c:27:0: /mingw64/include/cdio/cdda.h:178:5: warning: "TESTING_IS_FINISHED" is not defined In file included from ./libmpdemux/stheader.h:23:0, from ./gui/interface.h:24, from gui/win32/interface.c:46: ./libmpdemux/aviheader.h:132:0: warning: "FOURCC_RIFF" redefined /usr/x86_64-w64-mingw32/sys-root/mingw/include/mmsystem.h:1726:0: note: this is the location of the previous definition ./libmpdemux/aviheader.h:133:0: warning: "FOURCC_LIST" redefined /usr/x86_64-w64-mingw32/sys-root/mingw/include/mmsystem.h:1727:0: note: this is the location of the previous definition gui/win32/interface.c: In function 'guiInit': gui/win32/interface.c:530:17: warning: assignment makes pointer from integer without a cast gui/win32/interface.c: In function 'gui': gui/win32/interface.c:693:31: warning: cast from pointer to integer of different size gui/win32/interface.c:717:54: warning: cast from pointer to integer of different size gui/win32/interface.c:719:20: warning: cast from pointer to integer of different size gui/win32/interface.c: At top level: gui/win32/interface.c:820:12: error: static declaration of 'add_to_gui_playlist' follows non-static declaration ./gui/interface.h:153:5: note: previous declaration of 'add_to_gui_playlist' was here Makefile:747: recipe for target `gui/win32/interface.o' failed make: *** [gui/win32/interface.o] Error 1 The following fixes it for me. Index: gui/win32/interface.c =================================================================== --- gui/win32/interface.c (revision 35463) +++ gui/win32/interface.c (working copy) @@ -817,7 +817,7 @@ } /* This function adds/inserts one file into the gui playlist */ -static int add_to_gui_playlist(const char *what, int how) +int add_to_gui_playlist(const char *what, int how) { char filename[MAX_PATH]; char *filepart = filename;

4 8