April 2011 - MPlayer-dev-eng - lists.mplayerhq.hu

Homepage DOCS needs update
by Ingo Brückl 24 Apr '14

24 Apr '14

If it's already on the to-do list ignore, but the documentation on the homepage doesn't get updated. Ingo

3 12

[PATCH] add support of compression algorithm 3 in mkv demuxer
by Alexander Beregalov 02 Jan '12

02 Jan '12

Specs from http://www.matroska.org/technical/specs/ : ContentCompAlgo The compression algorithm used. Algorithms that have been specified so far are: 0 - zlib, 1 - bzlib, 2 - lzo1x, 3 - Header Stripping. ContentCompSettings Settings that might be needed by the decompressor. For Header Stripping (ContentCompAlgo=3), the bytes that were removed from the beggining of each frames of the track. I have such file, it works for me. | + A track | + Track number: 2 | + Track UID: 2 | + Track type: audio | + Lacing flag: 1 | + Default flag: 1 | + Codec ID: A_AC3 | + Content encodings | + Content encoding | + Content compression | + Algorithm: 3 (header removal) | + Settings: length 2, data: 0x0b 0x77 See an attachment. Please comment.

7 21

DxVA in MPlayer
by Georgi Petrov 26 Jun '11

26 Jun '11

Hello, I'm Georgi Petrov and a year ago I developed the Direct 3D renderer. Now I'm interested in implementing DxVA support in MPlayer. Yesterday I started to investigate the amount of work and any difficulties I may have and I came up with the following questions: 1. Since DxVA 2 requires EVR renderer (the current Direct 3D one won't work), I suppose that the best way to start is implementing a working EVR renderer first. If so, are there anybody who is familiar at least a little with it? The only thing that bothers me is that EVR is supposed to be used in a DirectShow chain and MPlayer has nothing to do with DirectShow... In short - does anybody know is it feasible to develop the EVR renderer first and test it with the current (non-accelerated) internal MPlayer codecs? 2. Once the EVR custom presenter is ready, FFmpeg already has the needed infrastructure for offloading computations for H.264, VC-1, MPEG-2 and MPEG-4 ASP. Excuse me if I don't get it, but each one of these standards should have an "accelerated" implementation, which from MPlayer's point of view is a new codec. Then inside the codec there are places, where one can hook and transfer the decoding part to the DxVA/VA API/VDAPU at any given stage (IDCT, MO and so on). Is this right? I'm starting to look at the code right now, but a higher abstract point of view is welcome. 3. As far as I understand this approach is used by VA API and VDPAU. Can I reuse their infrastructure as well? On this page I see a VA API patches: http://www.splitted-desktop.com/~gbeauchesne/mplayer-vaapi/ Are they part of MPlayer already or not? 4. Can somebody, who has already worked on VA API/VDPAU implementations give me some clue? How much work is involved in getting the whole chain work? Are most of the puzzle pieces in place or I will have to dig deeper into understanding how H.264 / VC-1 and so on work on a pure codec level? 5. I am trying to figure out a realistic estimate about how much time and hard work this is about, so any help in this direction is welcome. Greeting, Georgi

9 46

[PATCH] Add size based support for -endpos in MPlayer
by Clément Bœsch 11 Jun '11

11 Jun '11

A small patch to add size based support for -endpos in MPlayer. I tested it with random videos, audio only files and -loop option and it seems to work. Anything else I should test? However, I don't understand why mpctx->sh_audio is tested when mpctx->sh_video is NULL; is there a way to call the code around mplayer.c:L3698 without having neither mpctx->sh_video and mpctx->sh_audio? And then, does this mean mpctx->stream could be NULL? -- Clément B. Not sent from a jesusPhone.

2 12

[PATCH 1/5] Remove some useless static zero initializations.
by Clément Bœsch 11 Jun '11

11 Jun '11

--- mplayer.c | 48 ++++++++++++++++++++++++------------------------ 1 files changed, 24 insertions(+), 24 deletions(-) diff --git a/mplayer.c b/mplayer.c index c946b4a..501e2d4 100644 --- a/mplayer.c +++ b/mplayer.c @@ -162,7 +162,7 @@ static int cfg_include(m_option_t *conf, char *filename){ return m_config_parse_config_file(mconfig, filename); } -static int max_framesize=0; +static int max_framesize; int noconsolecontrols=0; //**************************************************************************// @@ -188,16 +188,16 @@ int fixed_vo=0; // benchmark: double video_time_usage=0; double vout_time_usage=0; -static double audio_time_usage=0; -static int total_time_usage_start=0; -static int total_frame_cnt=0; -static int drop_frame_cnt=0; // total number of dropped frames +static double audio_time_usage; +static int total_time_usage_start; +static int total_frame_cnt; +static int drop_frame_cnt; // total number of dropped frames int benchmark=0; // options: #define DEFAULT_STARTUP_DECODE_RETRY 8 int auto_quality=0; -static int output_quality=0; +static int output_quality; float playback_speed=1.0; @@ -207,7 +207,7 @@ int use_gui=0; int enqueue=0; #endif -static int list_properties = 0; +static int list_properties; int osd_level=1; // if nonzero, hide current OSD contents when GetTimerMS() reaches this @@ -218,12 +218,12 @@ int osd_fractions = 0; // determines how fractions of seconds are displayed int term_osd = 1; static char* term_osd_esc = "\x1b[A\r\x1b[K"; -static char* playing_msg = NULL; +static char* playing_msg; // seek: static double seek_to_sec; -static off_t seek_to_byte=0; -static off_t step_sec=0; -static int loop_seek=0; +static off_t seek_to_byte; +static off_t step_sec; +static int loop_seek; static m_time_size_t end_at = { .type = END_AT_NONE, .pos = 0 }; @@ -251,7 +251,7 @@ int dvdsub_lang_id; int vobsub_id=-1; char* audio_lang=NULL; char* dvdsub_lang=NULL; -static char* spudec_ifo=NULL; +static char* spudec_ifo; char* filename=NULL; //"MI2-Trailer.avi"; int forced_subs_only=0; int file_filter=1; @@ -271,14 +271,14 @@ int capture_dump = 0; // A-V sync: static float default_max_pts_correction=-1; static float max_pts_correction=0;//default_max_pts_correction; -static float c_total=0; +static float c_total; float audio_delay=0; -static int ignore_start=0; +static int ignore_start; -static int softsleep=0; +static int softsleep; double force_fps=0; -static int force_srate=0; +static int force_srate; static int audio_output_format=-1; // AF_FORMAT_UNKNOWN int frame_dropping=0; // option 0=no drop 1= drop vo 2= drop decode static int play_n_frames=-1; @@ -309,9 +309,9 @@ static const vf_info_t* const libmenu_vfs[] = { &vf_info_menu, NULL }; -static vf_instance_t* vf_menu = NULL; +static vf_instance_t* vf_menu; int use_menu = 0; -static char* menu_cfg = NULL; +static char* menu_cfg; static char* menu_root = "main"; #endif @@ -337,14 +337,14 @@ int edl_start_pts = 0; ///< Automatically add/sub this from EDL start/stop pos int use_filedir_conf; int use_filename_title; -static unsigned int initialized_flags=0; +static unsigned int initialized_flags; /// step size of mixer changes int volstep = 3; #ifdef CONFIG_CRASH_DEBUG static char *prog_path; -static int crash_debug = 0; +static int crash_debug; #endif /* This header requires all the global variable declarations. */ @@ -759,7 +759,7 @@ static void child_sighandler(int x){ #endif static void exit_sighandler(int x){ - static int sig_count=0; + static int sig_count; #ifdef CONFIG_CRASH_DEBUG if (!crash_debug || x != SIGTRAP) #endif @@ -1351,7 +1351,7 @@ struct mp_osd_msg { }; /// OSD message stack. -static mp_osd_msg_t* osd_msg_stack = NULL; +static mp_osd_msg_t* osd_msg_stack; /** * \brief Add a message on the OSD message stack @@ -1439,7 +1439,7 @@ static void clear_osd_msgs(void) { static mp_osd_msg_t* get_osd_msg(void) { mp_osd_msg_t *msg,*prev,*last = NULL; - static unsigned last_update = 0; + static unsigned last_update; unsigned now = GetTimerMS(); unsigned diff; char hidden_dec_done = 0; @@ -2039,7 +2039,7 @@ static void adjust_sync_and_print_status(int between_frames, float timing_error) v_pts = mpctx->sh_video->pts; { - static int drop_message=0; + static int drop_message; double AV_delay = a_pts - audio_delay - v_pts; double x; // not a good idea to do A-V correction with with bogus values -- 1.7.4.4

7 44

[PATCH] vf_delogo: variable rectangle
by Nicolas George 23 May '11

23 May '11

Hi. The attached patch makes it possible to change the coordinates of the rectangle for the delogo filter, by supplying a subtitle-like file with the times and coordinates. Regards, -- Nicolas George

3 24

CONF_TYPE_STRING issue
by Ingo Brückl 22 May '11

22 May '11

There are CONF_TYPE_STRING options in the GUI's config whose associated char *variables get freed and strdup'ed by the GUI to change them. To investigate whether this is ok (which I assumed might not be), I added some printfs to the config/option code (which unfortunately is very hard work) to see how/where allocated memory for CONF_TYPE_STRING options is beeing freed. I was very surprised to find no such freeing, so either it's a memory leak bug or I am doing something wrong. For example, I set name="foobar" in my user config and got: # (copy_str, strdup) "foobar" at 0x91c9188 # (before m_config_free) vo_winname = "foobar" at 0x91c9188 # (m_option_free) name="foobar" at 0x91c9188 # (free_str) "foobar" at 0x91c68d0 # (m_option_free) name="foobar" at 0x91c9188 ### don't know why it's called twice, but 0x91c68d0 already freed, so no action # (after m_config_free) vo_winname = "foobar" at 0x91c9188 # (manually freeing vo_winname now...) # (after freeing vo_winname) vo_winname = "^P^Har" at 0x91c9188 So we see that the string "foobar" is created at 0x91c9188 and is still at that address before m_config_free() starts. m_option_free() is called, but then a "foobar" (slot?) at a different address (0x91c68d0) is freed. As a result, "our" "foobar" is still present after m_config_free() and can be freed by a simple free() (called "manually" in the output). After that, it finally is gone. BTW, my original question concerning the GUI was: What is the right way to change a string option's value so that memory associated with the old value gets freed and the new one will be freed when m_config_free() is executed? (I was supposing m_option_save() or m_config_set_option() do the job.) Ingo

2 12

compiling mplayer with gcc 4.6, broken audio decoding
by Ionuț Bîru 18 May '11

18 May '11

Hi, right now i only found that mp3lib codec is affected, very high pitch sound, doesn't matter which audio output i'm using. mplayer log while playing: http://paste.xinu.at/XqVg/ config.log http://paste.xinu.at/XxBKH/ config.mak http://paste.xinu.at/gAHO/ -- Ionuț

8 12

Hardware acceleration with fbdev
by Roman Byshko 05 May '11

05 May '11

Hi, I'm interested in hardware acceleration for fbdev, as I would like to watch movies without X Server (and I do not like software scaling and decoding). As I understood for this purpose vidix drivers should be used. Or there are any other possibilities? Also, vidix does not support Intel graphic cards at the moment. Are there any plans/intends/willingness to have it implemented? And another general question. What is the state of vidix? I've browsed the svn history and mailing list. There is no so much going on. Are vidix API and drivers in legasy state? Best regards, Roman

6 13

[PATCH] Bind to seek to a given percent
by Clément Bœsch 05 May '11

05 May '11

Hi, It's the second time a person tells me he prefers GUI over classic MPlayer because the progress bar allows them to seek to a given position immediately. So I was wondering about making a default bind for this. It seems there is not current solution to bind a combination of keys, just like KEY_CTRL + '1', so I just binded F1 to F9 ('1' to '9' are for most of them already in use). I know this bind is not really good (especially for those using desktop managers) but I didn't find any better. What do you think of this? -- Clément B. Not sent from a jesusPhone.

3 8