October 2011 - MPlayer-dev-eng - lists.mplayerhq.hu

Homepage skin download issue
by Ingo Brückl 09 Sep '15

09 Sep '15

Yesterday, I updated hwswskin to 1.3, but it still isn't downloadable. Is the generation of the skin download tarballs working? Ingo

3 8

Homepage DOCS needs update
by Ingo Brückl 24 Apr '14

24 Apr '14

If it's already on the to-do list ignore, but the documentation on the homepage doesn't get updated. Ingo

3 12

[PATCH] xvmc: handle shm xvimage allocation error
by Marcin Slusarz 06 Jan '14

06 Jan '14

- handle xvimage/shm allocation failure and fallback to non-shm xv - assert xvimage->data_size!=0 because 0 size will lead to memory corruptions (I hit it because of bug in Nouveau's early xvmc implementation) Index: libvo/vo_xvmc.c =================================================================== --- libvo/vo_xvmc.c (wersja 34098) +++ libvo/vo_xvmc.c (kopia robocza) @@ -181,6 +181,15 @@ return cur_render->state || (cur_render->mpi && cur_render->mpi->usage_count); } +static void allocate_xvimage_non_shm(int xvimage_width, int xvimage_height, int xv_format) +{ + xvimage = (XvImage *) XvCreateImage(mDisplay, xv_port, xv_format, NULL, + xvimage_width, xvimage_height); + assert(xvimage->data_size); + xvimage->data = malloc(xvimage->data_size); + XSync(mDisplay,False); +} + static void allocate_xvimage(int xvimage_width,int xvimage_height,int xv_format) { /* @@ -188,7 +197,8 @@ * mit-shm this will bomb... trzing to fix ::atmos */ #ifdef HAVE_SHM - if ( mLocalDisplay && XShmQueryExtension( mDisplay ) ) Shmem_Flag = 1; + if ( mLocalDisplay && XShmQueryExtension( mDisplay ) ) + Shmem_Flag = 0; else { Shmem_Flag = 0; @@ -198,25 +208,41 @@ { xvimage = (XvImage *) XvShmCreateImage(mDisplay, xv_port, xv_format, NULL, xvimage_width, xvimage_height, &Shminfo); + if (!xvimage) + goto noshmimage; + assert(xvimage->data_size); Shminfo.shmid = shmget(IPC_PRIVATE, xvimage->data_size, IPC_CREAT | 0777); + if (Shminfo.shmid == -1) + goto shmgetfail; + Shminfo.shmaddr = (char *) shmat(Shminfo.shmid, 0, 0); + if ((long)Shminfo.shmaddr == -1) + goto shmatfail; + Shminfo.readOnly = False; xvimage->data = Shminfo.shmaddr; - XShmAttach(mDisplay, &Shminfo); + if (!XShmAttach(mDisplay, &Shminfo)) + goto shmattachfail; + XSync(mDisplay, False); shmctl(Shminfo.shmid, IPC_RMID, 0); } else #endif - { - xvimage = (XvImage *) XvCreateImage(mDisplay, xv_port, xv_format, NULL, xvimage_width, xvimage_height); - xvimage->data = malloc(xvimage->data_size); - XSync(mDisplay,False); - } -// memset(xvimage->data,128,xvimage->data_size); + allocate_xvimage_non_shm(xvimage_width, xvimage_height, xv_format); return; + +shmattachfail: + shmdt(Shminfo.shmaddr); +shmatfail: + shmctl(Shminfo.shmid, IPC_RMID, 0); +shmgetfail: + XFree(xvimage); +noshmimage: + Shmem_Flag = 0; + allocate_xvimage_non_shm(xvimage_width, xvimage_height, xv_format); } static void deallocate_xvimage(void)

4 6

GUI and vo_x11 functions
by Ingo Brückl 02 Mar '13

02 Mar '13

I'm about to commit the vo_x11_ewmh_fullscreen() patch which adds a window parameter to the function, but I'm not quite sure whether this really is ok, although I got permission. The question is whether vo_x11_ewmh_fullscreen() and all the other vo_x11 functions should only operate on the global vo variables (like vo_window in that case) or whether they should be reusable functions, offering services for whoever wants to call them (the GUI in my case). The reason why I raise this issue is that the GUI does call three other vo_x11 functions (with relative success), namely vo_x11_decoration() vo_x11_sizehint() vo_x11_setlayer() While vo_x11_decoration() seems to be problem-free (it has some useful parameters, but uses global variables as well), vo_x11_sizehint() mostly uses global variables (which causes some X errors with the GUI then if called at a time when these variables aren't yet set). vo_x11_setlayer() is pointlessly called by the GUI, because it doesn't do anything in case of WinID >= 0. So, what is the right way to continue? Setting all necessary global vo variables in the GUI - even prior to the vo driver (vo_window is known to become WinID later anyway, for example), trying to modestly patch these four functions so that they can be reused or copy the code and letting the GUI use its own copies? All these four functions are window specific and window handling should be GUI's task although commonly used code is convenient. Pros and cons should be obvious. Ingo

3 16

[PATCH] remove mp3lib
by Reimar Döffinger 05 Feb '12

05 Feb '12

Hello, I am still interested in seeing performance numbers and statistics from ffmp3 vs. mp3lib when ffmp3 is slower, but I guess it's time to start some more specific moves to get rid of it.

12 59

GUI Icon
by Ingo Brückl 10 Jan '12

10 Jan '12

Although I like the MPlayer logo, I think that it isn't really suitable for a desktop icon. On Bugzilla (http://bugzilla.mplayerhq.hu/show_bug.cgi?id=710) there is an offer for a GUI icon set that is quite nice. There is licence information for the Tango Desktop Project Icon Library, but it is missing for the Tango Fridays which supposably is a problem. If there is no general objection in using these icons for the GUI, I could try to contact the creator, Andreas Nilsson, and ask for a full set of these icons and a licence information to include both to the MPlayer repository. Would that be OK? Ingo PS: Where can I find the original (svg?) of the MPlayer logo?

2 2

[PATCH] add support of compression algorithm 3 in mkv demuxer
by Alexander Beregalov 02 Jan '12

02 Jan '12

Specs from http://www.matroska.org/technical/specs/ : ContentCompAlgo The compression algorithm used. Algorithms that have been specified so far are: 0 - zlib, 1 - bzlib, 2 - lzo1x, 3 - Header Stripping. ContentCompSettings Settings that might be needed by the decompressor. For Header Stripping (ContentCompAlgo=3), the bytes that were removed from the beggining of each frames of the track. I have such file, it works for me. | + A track | + Track number: 2 | + Track UID: 2 | + Track type: audio | + Lacing flag: 1 | + Default flag: 1 | + Codec ID: A_AC3 | + Content encodings | + Content encoding | + Content compression | + Algorithm: 3 (header removal) | + Settings: length 2, data: 0x0b 0x77 See an attachment. Please comment.

7 21

compiling rc4 / color management patch
by Jos van Riswick 30 Dec '11

30 Dec '11

Hi I need color management in mplayer, and found this patch that provides it: http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2010-June/064978.html I found it can be applied to this version of mplayer: http://www.mplayerhq.hu/MPlayer/releases/MPlayer-1.0rc4.tar.bz2 Unfortunately, it doesn't compile on my ubuntu 11.04: libmpcodecs/vd_mpng.c: In function 'pngReadFN': libmpcodecs/vd_mpng.c:77:19: error: dereferencing pointer to incomplete type libmpcodecs/vd_mpng.c: In function 'decode': libmpcodecs/vd_mpng.c:114:14: error: derefersencing pointer to incomplete type libmpcodecs/vd_mpng.c:131:87: error: dereferencing pointer to incomplete type make: *** [libmpcodecs/vd_mpng.o] Error 1 On many forums it says this error has something to do with libpng 1.5, older versions not having the problem. However I have libpng 1.2. .... Any help would be appreciated ! Josvanr

2 4

Apply color management patch
by Jos van Riswick 29 Dec '11

29 Dec '11

http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2010-June/064978.html I want to use the color management patch. It doesn't seem to work for the current version of mplayer. How do I find out which old source code to use, when I want to apply this patch? Jos van Riswick

2 2

MPlayer/MEncoder crash on using -vf scale and expand together. Fix attached.
by Alex C 06 Nov '11

06 Nov '11

Problem: SIGSEGV on mplayer -vf scale=720:480,expand=720:480 test.mkv Sample test file: https://ffmpeg.org/trac/ffmpeg/attachment/ticket/594/rotate_x.mp4 Backtrace on: http://pastebin.com/uHPRtswz Similar to ffmpeg bug: https://ffmpeg.org/trac/ffmpeg/ticket/594?cversion=1&cnum_hist=4 Patched in ffmpeg by michaelni: http://git.videolan.org/gitweb.cgi?p=ffmpeg.git;a=commitdiff;h=3e4375833d96… I have applied a similar patch for mplayer. Patch is attached. The crash is averted as a result. --- AC P.S.: Yahoo has changed its email software since I last used it. Please excuse if this email is in HTML. I've tried to force plain text but it still may be SNAFU'd.

5 13