September 2010 - MPlayer-dev-eng

[PATCH] add support of compression algorithm 3 in mkv demuxer
by Alexander Beregalov 02 Jan '12

02 Jan '12

Specs from http://www.matroska.org/technical/specs/ : ContentCompAlgo The compression algorithm used. Algorithms that have been specified so far are: 0 - zlib, 1 - bzlib, 2 - lzo1x, 3 - Header Stripping. ContentCompSettings Settings that might be needed by the decompressor. For Header Stripping (ContentCompAlgo=3), the bytes that were removed from the beggining of each frames of the track. I have such file, it works for me. | + A track | + Track number: 2 | + Track UID: 2 | + Track type: audio | + Lacing flag: 1 | + Default flag: 1 | + Codec ID: A_AC3 | + Content encodings | + Content encoding | + Content compression | + Algorithm: 3 (header removal) | + Settings: length 2, data: 0x0b 0x77 See an attachment. Please comment.

7 21

[PATCH] -vf fixpts=use_timer
by Rudolf Polzer 22 Feb '11

22 Feb '11

Hello, I added an option to -vf fixpts that takes over the timer from mplayer/mencoder's "best known idea" of the current display time. It is mostly useless in mplayer as mplayer usually generates good pts anyway, but works there too for completeness. Its main intention is to support ASS subtitle baking in mencoder, even if the input video is variable frame rate. My mencoder profile for embedding subtitles is currently: [subtitles] vf-add=fixpts=use_timer,ass,expand=::::1,fixpts ass=yes embeddedfonts=yes It works by having mplayer/mencoder export their timer to a global variable, and having fixpts=use_timer read that back and use it as replacement pts. In case of mplayer, I simply could export sh_video->timer (did NOT use the usually more accurate sh_video->pts, as using that one is quite pointless as it is exactly what is sent as current timestamp anyway). The feature therefore is mainly a debugging help in mplayer. In case of mencoder, sh_video->timer was not available, and sh_video->pts was not monotonous (and thus bad for e.g. subtitle rendering), so I got no better idea than using the audio timer instead. As I noticed the audio timer is broken (positive infinity) for some input video files (e.g. those which use vorbis as audio codec), I had to port over mplayer's audio PTS generation (which is, if possible, no longer based on constant bitrate input data sizes, but on output data sizes of the audio codec, which also works for VBR audio like vorbis). This also solves almost all failcases of mencoder that I have that previously needed -mc 0 to encode properly, as apparently this very issue also caused AV sync to fail in mencoder. To do this port, I also had to delete the written-only (grep did not find any other access to it anywhere) delay_corrected variable. I hope that is okay. If desired, I can split up the changes into separate diffs, however the fixpts=use_timer feature depends on the mencoder.c audio timer fix, or rather, causes huge breakage (infinite pts values) on many input video files when added to the filter chain. Or you can instead download them separately on github: http://github.com/divVerent/mplayer/commits/divVerent/fix_audio_pts http://github.com/divVerent/mplayer/commits/divVerent/fixpts_get_audio_pts http://github.com/divVerent/mplayer/commits/divVerent/integration/fixpts (integration branch of both + current svn) I attached my patch to svn r31721 (= git master on git.mplayerhq.hu), and hope for a review. Best regards, Rudolf Polzer

4 17

[PATCH] Fix for broken GUI support in current SVN head mplayer version
by Dirk Porezag 05 Jan '11

05 Jan '11

xmga video-out support is broken in the current SVN release in GUI (gmplayer) mode. Playing a video will crash since "vo_window" is not set up properly before using. Also, moving the window across the screen also doesn't work. The patch fixes both issues, changes are rather trivial but I'm happy to discuss them if needed. There still is an issue with extensive flickering in full-screen mode that is neither addressed nor caused by this patch - I didn't have time yet to look into this. Thanks & keep up the good work on my favorite video player, Dirk

2 1

[PATCH] proper version info for git.mplayerhq.hu
by Rudolf Polzer 17 Dec '10

17 Dec '10

I attached a small patch that, if mplayer is compiled from mplayer.git, uses the git commit hash instead of UNKNOWN as version info. The format will be: git-<commithash>-<gccversion> if mplayer is built from "master", and git-<closest commithash on master>-<commithash>-<gccversion> if mplayer is built from another branch. In my case, at the moment it prints: MPlayer git-15dfe0a-ceba2bd-4.4.1 (C) 2000-2010 MPlayer Team It changes nothing if run from a svn repository. Best regards, Rudolf Polzer

5 17

Donating
by Laura 27 Oct '10

27 Oct '10

Dear Sir/Madam, There I visited http://www.mplayerhq.hu/ today I'm writing this email. I'm using open source software everyday and just saw your helpful project. I would like to know more about donating. Are there possibilities to donate and get acknowledged on your homepage? (like Init7) If the answer is yes, I could give a nice donation. I hope to hear from you soon. Thank you in advance! Kind regards, Laura laura(a)singaporereizen.nl

2 1

[PATCH] DVB TS subtitle not working if corresponding PID doesn't occur at beginning for -demux lavf
by K.S. Ng 24 Oct '10

24 Oct '10

Hello, Subtitles in DVB broadcast very often occur dynamically, i.e. subtitle streams and their respective PID information in the PMT occur only when present. It is found that demux-lavf (mplayer invoked with -demux lavf) is not aware of such subtitle streams if their PIDs are not present when opening the transport stream. Below is a small patch to fix this issue. I've tested it with DVB broadcast in Hong Kong. Please kindly review! Thanks, K.S. Ng Index: libmpdemux/demux_lavf.c =================================================================== --- libmpdemux/demux_lavf.c (revision 32358) +++ libmpdemux/demux_lavf.c (working copy) @@ -77,6 +77,7 @@ int vstreams[MAX_V_STREAMS]; int sstreams[MAX_S_STREAMS]; int cur_program; + int nb_streams_last; }lavf_priv_t; static int mp_read(void *opaque, uint8_t *buf, int size) { @@ -573,6 +574,8 @@ demuxer->video->id=-2; // audio-only } //else if (best_video > 0 && demuxer->video->id == -1) demuxer->video->id = best_video; + priv->nb_streams_last = priv->avfc->nb_streams; + return demuxer; } @@ -581,7 +584,7 @@ AVPacket pkt; demux_packet_t *dp; demux_stream_t *ds; - int id; + int id, i; mp_msg(MSGT_DEMUX,MSGL_DBG2,"demux_lavf_fill_buffer()\n"); demux->filepos=stream_tell(demux->stream); @@ -589,6 +592,14 @@ if(av_read_frame(priv->avfc, &pkt) < 0) return 0; + if( priv->nb_streams_last != priv->avfc->nb_streams ) { + mp_msg(MSGT_DEMUX, MSGL_DBG2, "Nb streams changed %d %d\n", priv->nb_streams_last, priv->avfc->nb_streams); + for(i=priv->nb_streams_last; i<priv->avfc->nb_streams; i++) { + handle_stream(demux, priv->avfc, i); + } + } + priv->nb_streams_last = priv->avfc->nb_streams; + id= pkt.stream_index; if(id==demux->audio->id){

3 2

[PATCH] Capture feature
by Pásztor Szilárd 23 Oct '10

23 Oct '10

Hi, I'm attaching a simple patch that implements a basic capture feature. Upon pressing 'c' (by default) while playing, it does as if -dumpstream had been given on the command line and saves the stream until the next 'c'. I find this feature extremely useful for saving dvb streams on the fly, while watching, and you can even cut mpgs with it. Most probably this is not a proper patch, and the filename is not handled very cleverly. I wanted to integrate it so that the known -dumpfile overrides on the default "capture.dump" but couldn't do it in a short time frame yet. Nevertheless, I'd like to have your opinions on the concept, and so on, if you can take the time for a short look.

8 46

[PATCH] SMPlayer's audio equalizer slave command patch
by Adrian Stutz 17 Oct '10

17 Oct '10

Hello, SMPlayer has been using a patch to set the audio equalizer bands from the command line for a long time now, the patch was originally posted in June 2008 on this list: http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2008-June/057840.html An updated version can be found in the SMPlayer SVN: http://smplayer.svn.sourceforge.net/viewvc/smplayer/mplayer-builds/patches/… Are there any issues with this patch? I started using it in MPlayer OSX Extended as well and would prefer if it got applied to SVN. Greetings Adrian

2 13

[PATCH] Two small subtitles improvments
by Clément Bœsch 17 Oct '10

17 Oct '10

Hi again, I'd like to propose two more patches for subreader.c: - patch-malloc-memset-to-calloc.diff As says the file name, just replace two couples of malloc+memset into calloc calls. - patch-rt-format.diff Explicit recognition for the RealTime format. I made a Google research ("time begin ext:rt"), and fetched all the subtitles (not that much, 28). I only ran into two "headers": "<window" and "<WINDOW" so I think it's fine to rely on it. Even if there were no white spaces before, I used strstr() function, just in case. Also note the spaces before the opening brackets are here just to stay consistent with the rest of the function. Regards, -- Clément B.

4 15

[PATCH]printf format string used everywhere
by Frédéric Marchal 15 Oct '10

15 Oct '10

Hello, I'm submitting this trivial patch to force the use of a format string in every printf-like function. It has two advantages: 1) In the unlikely case where the string to print contains a sequence that looks like a valid format specifier, the function won't fail while reading the missing arguments. 2) It is possible to compile with -Wformat -Werror=format-security in the CFLAGS and increase the confidence that every printf-like function is parsing the right arguments. Frederic --- Index: libmpcodecs/vd_ffmpeg.c =================================================================== --- libmpcodecs/vd_ffmpeg.c (révision 32250) +++ libmpcodecs/vd_ffmpeg.c (copie de travail) @@ -227,7 +227,7 @@ static void mp_msp_av_log_callback(void *ptr, int print_prefix= strchr(fmt, '\n') != NULL; vsnprintf(buf, sizeof(buf), fmt, vl); - mp_msg(type, mp_level, buf); + mp_msg(type, mp_level, "%s", buf); } static void set_format_params(struct AVCodecContext *avctx, enum PixelFormat fmt){ Index: stream/librtsp/rtsp_rtp.c =================================================================== --- stream/librtsp/rtsp_rtp.c (révision 32250) +++ stream/librtsp/rtsp_rtp.c (copie de travail) @@ -218,7 +218,7 @@ parse_destination (const char *line) len = strlen (parse1) - strlen (parse2) - strlen (RTSP_SETUP_DESTINATION) + 1; dest = (char *) malloc (len + 1); - snprintf (dest, len, parse1 + strlen (RTSP_SETUP_DESTINATION)); + snprintf (dest, len, "%s", parse1 + strlen (RTSP_SETUP_DESTINATION)); free (line_copy); return dest; Index: vidix/mtrr.c =================================================================== --- vidix/mtrr.c (révision 32250) +++ vidix/mtrr.c (copie de travail) @@ -57,7 +57,7 @@ int mtrr_set_type(unsigned base,unsigned size,int char sout[256]; unsigned wr_len; sprintf(sout,"base=0x%08X size=0x%08X type=%s\n",base,size,stype); - wr_len = fprintf(mtrr_fd,sout); + wr_len = fprintf(mtrr_fd,"%s",sout); /*printf("MTRR: %s\n",sout);*/ fclose(mtrr_fd); return wr_len == strlen(sout) ? 0 : EPERM;

3 8