June 2007 - MPlayer-dev-eng - lists.mplayerhq.hu

[PATCH] Audio balance feature
by Zuxy Meng 20 Jun '07

20 Jun '07

Hi, Attached patch implements the audio balance feature commonly present in other players by using the pan audio filter. With this patch a user can adjust the balance between the two front channels during play with '(' and ')'. Comments and testing welcome! -- Zuxy Beauty is truth, While truth is beauty. PGP KeyID: E8555ED6

5 39

offset playback trouble
by Juan Manuel Lopez Baio 19 Jun '07

19 Jun '07

Hello. I have an application that records a cable signal with mencoder, with the following parameters: acodec:mp3 vcodec: mpeg4 acompressor: lavc vdriver:v4l2 vbitrate:200 abitrate:96 outputformat:mpeg vsize:medium vfps:25 Afterwards, there are occasions where I need to play this videos not from the beginning but from a certain offset. To do this I use libavcodec library to access and seek the media file, and send the proper content via http to a vlc client. This doesn't seem to be working. vlc is getting a stream that doesn't play anything. I wonder if there is any special consideration regarding the container format and/or codec, or anything I might be missing that should be taking into account for this offset playback to work. Any thoughts on this are welcome. Thanks! juan

2 1

[PATCH] make disable-mmx etc. work with runtime cpudetection
by Reimar Doeffinger 19 Jun '07

19 Jun '07

Hello, especially helpful for people who want runtime cpudetection and do not want to upgrade binutils. Ok to apply? Greetings, Reimar Doeffinger

3 3

[PATCH] possibly cleaner way to generate ARCH_, ENABLE_ etc. defines
by Reimar Doeffinger 19 Jun '07

19 Jun '07

Hello, please comment on attached patch. Can probably be further simplified, but I'm not motivated to take it that far... Greetings, Reimar Doeffinger

3 2

how to add coreavc to mplayer
by yang yong 19 Jun '07

19 Jun '07

hello , Alan Nisota:* * I want to add coreavc to mplayer, after seeing you text( [MPlayer-dev-eng]CoreAVCDecoder support), I have some questions. 1. which version is your mplayer, I can not find the loader/modify_reg.c in the Mplayer-1.0rc. 2. where can I find the patches, and how can I use them? please give me a answer in detail, thank you?

1 0

[PATCH] Do not block mplayer at rtsp eof
by Carl Eugen Hoyos 19 Jun '07

19 Jun '07

Hi! Current svn hangs on eof when playing rtsp streams (from a server that supports trick play). Attached patch fixes this issue by quitting after no packet has arrived for three seconds. Please comment, Carl Eugen Index: libmpdemux/demux_rtp.cpp =================================================================== --- libmpdemux/demux_rtp.cpp (Revision 23185) +++ libmpdemux/demux_rtp.cpp (Arbeitskopie) @@ -448,6 +448,10 @@ RTPState* rtpState = (RTPState*)(demuxer->priv); ReadBufferQueue* bufferQueue = NULL; int headersize = 0; + TaskToken task; + + if (demuxer->stream->eof) return NULL; + if (ds == demuxer->video) { bufferQueue = rtpState->videoBufferQueue; if (((sh_video_t*)ds->sh)->format == mmioFOURCC('H','2','6','4')) @@ -500,7 +504,9 @@ // Block ourselves until data becomes available: TaskScheduler& scheduler = bufferQueue->readSource()->envir().taskScheduler(); + task = scheduler.scheduleDelayedTask(3000000, onSourceClosure, bufferQueue); scheduler.doEventLoop(&bufferQueue->blockingFlag); + scheduler.unscheduleDelayedTask(task); if (headersize == 1) // amr dp->buffer[0] = @@ -510,7 +516,7 @@ bufferQueue->dp = dp = bufferQueue->nextpacket; bufferQueue->nextpacket = NULL; } - if (headersize == 3 && h264parserctx) { // h264 + if (headersize == 3 && h264parserctx && !demuxer->stream->eof) { // h264 consumed = h264parserctx->parser->parser_parse(h264parserctx, NULL, &poutbuf, &poutbuf_size,

5 11

r23257 breaks asf playback due to making get_ext_stream_properties errors criticalk
by Reimar Doeffinger 18 Jun '07

18 Jun '07

Hello, For details please see bugzilla #843 (http://bugzilla.mplayerhq.hu/show_bug.cgi?id=843) Someone who knows the code please fix it. Greetings, Reimar Doeffinger

3 3

Aspect Ratio Detection
by Alexander Roalter 18 Jun '07

18 Jun '07

As suggested by Carl Eugen Hoyos, I'm posting it here.... As I'm using the english language version, there's a patch also applied to help/help_mp-en.h, which should instead go to all the different languages, but I have not yet done this... (i.e. it won't work with other languages ATM) horus:/usr/src/mplayer/help # svn diff help_mp-en.h And of course the fleshy part in libmpcodecs: horus:/usr/src/mplayer/libmpcodecs # svn diff vf_cropdetect.c The Output of -vf cropdetect then looks like this: [CROP] Crop area: X: 0..719 Y: 13..562 R:1.86:1 (-vf crop=720:544:0:16). The the point 1.86:1 is especially interesting for me. For those only using the crop hinting for doing cropping this is easily another information (which btw. could also be used on setting the newly created movie's aspect ratio..., and I can use the info for my DVD database with exact aspect ratios instead of the often wrong specified 1.33, 2.35 or 1.85 on the box cover (see http://www.roalter.it/dvd/single.php?who=0&id=1 as an example) -- cheers, Alex Index: vf_cropdetect.c =================================================================== --- vf_cropdetect.c (revision 23574) +++ vf_cropdetect.c (working copy) @@ -16,6 +16,7 @@ int limit; int round; int fno; + float aspect; }; static int checkline(unsigned char* src,int stride,int len,int bpp){ @@ -50,11 +51,17 @@ vf->priv->x2=0; vf->priv->y2=0; vf->priv->fno=0; + if (d_height == 0) + vf->priv->aspect = 1; + else + vf->priv->aspect = (float)d_width/(float)d_height; return vf_next_config(vf,width,height,d_width,d_height,flags,outfmt); } static int put_image(struct vf_instance_s* vf, mp_image_t *mpi, double pts){ mp_image_t *dmpi; + float ratio; + float stretch; int bpp=mpi->bpp/8; int w,h,x,y,shrink_by; @@ -124,13 +131,24 @@ shrink_by = h % vf->priv->round; h -= shrink_by; y += (shrink_by / 2 + 1) & ~1; + ratio = (((float)(vf->priv->x2 - vf->priv->x1 + 1))/ + ((float)(vf->priv->y2 - vf->priv->y1 + 1))); + if ((mpi->height == 0) || (mpi->width == 0)) + stretch = 1; + else + stretch = vf->priv->aspect / ((float)mpi->width/ (float)mpi->height); - mp_msg(MSGT_VFILTER, MSGL_INFO, MSGTR_MPCODECS_CropArea, - vf->priv->x1,vf->priv->x2, - vf->priv->y1,vf->priv->y2, - w,h,x,y); + mp_msg(MSGT_VFILTER, MSGL_INFO, MSGTR_MPCODECS_CropArea, + vf->priv->x1,vf->priv->x2, + vf->priv->y1,vf->priv->y2, ratio * stretch, + w,h,x,y); +// mp_msg(MSGT_VFILTER, MSGL_INFO, MSGTR_MPCODECS_CropArea, +// vf->priv->x1,vf->priv->x2, +// vf->priv->y1,vf->priv->y2, +// w,h,x,y); + } return vf_next_put_image(vf,dmpi, pts); Index: help_mp-en.h =================================================================== --- help_mp-en.h (revision 23574) +++ help_mp-en.h (working copy) @@ -1656,7 +1656,7 @@ #define MSGTR_MPCODECS_CropBadPositionWidthHeight "[CROP] Bad position/width/height - cropped area outside of the original!\n" // libmpcodecs/vf_cropdetect.c -#define MSGTR_MPCODECS_CropArea "[CROP] Crop area: X: %d..%d Y: %d..%d (-vf crop=%d:%d:%d:%d).\n" +#define MSGTR_MPCODECS_CropArea "[CROP] Crop area: X: %d..%d Y: %d..%d R:%0.2f:1 (-vf crop=%d:%d:%d:%d).\n" // libmpcodecs/vf_format.c, vf_palette.c, vf_noformat.c #define MSGTR_MPCODECS_UnknownFormatName "[VF_FORMAT] Unknown format name: '%s'.\n"

2 3

[PATCH] set subtitle type in mpg demuxer
by Reimar Doeffinger 17 Jun '07

17 Jun '07

Hello, attached patch does this, this seems to fix subtitle switching with vobs. Another way to do this would be to just set it to 'v' in new_sh_sid by default, or do both. What is your opinion? Greetings, Reimar Doeffinger

2 2

[PATCH] Allow '=' and '.' characters in style names for -ass-force-style
by Бранко Мајић 15 Jun '07

15 Jun '07

According to the specification of the ASS subtitle (see http://people.ee.ethz.ch/~adogan/ass-specs.ps.gz if interested), the style name can consist of any character, except the comma (,). This means that style name can also consist of dots (.) and equality (=) signs. -ass-force-style uses commas, dots, and equality signs in its arguments to delimiter its multiple parameters (which means we have no problems with commas). Current code that does parsing doesn't work correctly if the style name contains dots or equality signs. This patch should fix this situation, by searching for these characters backwards (using strrchr function instead of strchr). The only problematic situation after this might be the fact that even some of the font names could also use equality signs or dots (haven't ever run into this one, though). Here's an example of what this patch actually fixes: 1) .hack.FontSize=20 2) style=name.FontSize=30 In first case the style name is .hack, but the current parsing function will stop at first dot, and will assume that style name is actually empty, which is incorrect (this is actually a real-life problem I had). In second case the parsing function will seek for first equality sign and presume that the property(+style) being changed is named style, while the actual name is style=name. P.S. Sorry if my explanation is too long, but it was hard for me to describe it in fewer lines :)

2 1