April 2006 - MPlayer-dev-eng - lists.mplayerhq.hu

[PATCH] New mode for 'tinterlace' filter
by Walter Belhaven 08 Apr '06

08 Apr '06

Hi, Here's a patch to libmpcodecs/vf_tinterlace.c which adds a new mode (-vf tinterlace=4). The new mode interleaves the even lines from Frame 'j' with the odd lines of Frame 'j+1', halving the Frame rate in the process while preserving the overall image height. In ASCII art: Original Original New Frame Frame 'j' Frame 'j+1' (tinterlace=4) ========== =========== ================== Line 0 --------------------> Frame 'j' Line 0 Line 1 Line 1 ----> Frame 'j+1' Line 1 Line 2 ---------------------> Frame 'j' Line 2 Line 3 Line 3 ----> Frame 'j+1' Line 3 ... ... ... I'll use the following notation to explain this new option and why I need it: o Capital 'F' means 'F'rames (typically progressive) o lower-case 'f' means 'f'ields (interlaced) o "film" means ~24 *unique* Fps (regardless of how transmitted) o "video" means ~60 *unique* Fps or fps (NTSC) My application for this filter is transcoding 720p HD "video" sources (specifically, 720p/60Fps) to SD NTSC "video", at 480i/60fps (30Fps interlaced) for ultimate authoring to an NTSC DVD-Video. Here's how it would be used in practice: mencoder ... -vf tinterlace=4,scale=720:480:1 ... or mencoder ... -vf scale=720:480,tinterlace=4 ... Please see the "@@ Need help" comments I included in the implementation of the new case for tinterlace. I need to know whether I should set dmpi->fields to indicate that the (output) Frame is interlaced. Thanks for your review. I'll be glad to incorporate this into the documentation if you folks approve and if someone can tell me how to do that. :) Cheers, WB P.S. This filter MIGHT also be useful -- in conjunction with 'pullup' et. al. -- to recover the original "film" cadence in a 720p/60Fps transmission of a "film", in which the broadcaster simply duplicates the original "film" Frames in a 2:3:2:3 pattern. The 'tinterlace=4' filter can make the 720p/60Fps look like hard telecined 720i/30Fps (i.e., 720i/60fps) which is what 'pullup' expects to see. I haven't tested this application yet, so I don't know if it works. It probably doesn't work, unless it just magically happens to be at the correct phase of the 2:3:2:3 pattern. __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

4 8

v4l bugfix
by Mark Sanderson 08 Apr '06

08 Apr '06

video4linux ioctls VIDIOCGTUNER/VIDIOCSTUNER require the tuner argument set before calling. Defaulting it to zero is the fix: libmpdemux/tvi_v4l.c line 593 + priv->tuner.tuner = 0; Regards, Mark.

2 1

[PATCH] minor tweak to title range parsing
by Robert Henney 07 Apr '06

07 Apr '06

this adds 3 minor changes. handling of play ranges with 3-digit title numbers is handled correctly. eg. dvd://99-100 nope, I've yet to see a dvd with that many titles, but I've seen ones that have gotten close. ranges that end on the same title they begin at are handled as would be expected and are not taken to be invalid. eg. dvd://4-4 reliance on the uninitialized state of the last byte in the string buffer removed, along with magic number.

3 4

[PATCH] Remove bogus Vorbis pts values from Matroska demuxer
by Uoti Urpala 07 Apr '06

07 Apr '06

The Matroska demuxer currently gives the same pts value for each laced Vorbis packet. These bogus pts values make av sync unstable. The attached patch removes pts values from packets other than the first laced packet when the track has no default packet duration (there is no way to give them correct timestamps other than decoding the packets and calculating the length of the resulting audio). Are there any cases where default_duration would be 0 and giving all the packets the same pts value would be the right thing to do? If there are then this fix could be changed to affect Vorbis streams only.

2 1

[PATCH] dvdnav
by Scott Franzyshen 07 Apr '06

07 Apr '06

This is working great .... I have tried over 50 DVD's without a single problem ... graphics are working as expected ... so it works for me .... using fbdev2 & sdl & linux 2.4.27-2-686-smp nice job Ötvös Attila! by the way are you going to continue working on your osd-menu patch ... or is it dead ... I tried to patch it to the latest cvs ... there are problems with libmenu/menu.h &libmenu/menu_list.c ... to be exact, changes have been made to menu_draw_text_full() that break your code ... please advise sfranzyshen

2 1

[MPlayer-dev-eng] http://mplayerhq.hu/pipermail/mplayer-dev-eng/2006-April/041839.html
by Scott Franzyshen 07 Apr '06

07 Apr '06

This is working great .... I have tried over 50 DVD's without a single problem ... graphics are working as expected ... so it works for me .... using fbdev2 & sdl & linux 2.4.27-2-686-smp nice jobe Ötvös Attila! by the way are you going to continue working on your osd-menu patch ... or is it dead ... I tried to patch it to the latest cvs ... there are problems with libmenu/menu.h &libmenu/menu_list.c ... to be exact, changes have been made to menu_draw_text_full() that break your code ... please advise sfranzyshen

1 0

get vob file pts error
by qwen dux 07 Apr '06

07 Apr '06

hi, There was a error when last mplayer played vob file,the console line displayed the A-V pos abnormally,and the osd time is not right,there is the info of mplayer: Playing /home/qwdu/media/testmedia/mpeg12/mpeg1-352-288-1187-25.VOB. get_path('sub/') -> '/home/qwdu/.mplayer/sub/' [file] File size is 56020992 bytes STREAM: [file] /home/qwdu/media/testmedia/mpeg12/mpeg1-352-288-1187-25.VOB STREAM: Description: File STREAM: Author: Albeu STREAM: Comment: based on the code from ??? (probably Arpi) Checking for YUV4MPEG2 ASF_check: not ASF guid! Checking for NuppelVideo Checking for REAL Checking for SMJPEG Searching demuxer type for filename /home/qwdu/media/testmedia/mpeg12/mpeg1- 352-288-1187-25.VOB ext: .VOB Trying demuxer 2 based on filename extension system stream synced at 0xD (13)! ==> Found video stream: 0 ==> Found audio stream: 0 MPEG Stream reached EOF ds_fill_buffer: EOF reached (stream: video) MPEG-PS file format detected. Searching for sequence header... OK! VIDEO: MPEG1 352x288 (aspect 8) 25.000 fps 1000.0 kbps (125.0 kbyte/s) [V] filefmt:2 fourcc:0x10000001 size:352x288 fps:25.00 ftime:=0.0400 get_path('sub/') -> '/home/qwdu/.mplayer/sub/' get_path('default.sub') -> '/home/qwdu/.mplayer/default.sub' File not found: '/home/qwdu/.mplayer/default.sub' Failed to open /home/qwdu/.mplayer/default.sub ========================================================================== Opening audio decoder: [mp3lib] MPEG layer-2, layer-3 dec_audio: Allocating 4608 + 65536 = 70144 bytes for output buffer. mp3lib: made decode tables with MMX optimization mp3lib: using MMX optimized decore! MP3lib: init layer2&3 finished, tables done MPEG 1.0, Layer II, 48000 Hz 64 kbit Stereo, BPF: 192 Channels: 2, copyright: No, original: No, CRC: Yes, emphasis: 0 AUDIO: 48000 Hz, 2 ch, s16le, 64.0 kbit/4.17% (ratio: 8000->192000) Selected audio codec: [mp3] afm: mp3lib (mp3lib MPEG layer-2, layer-3) ========================================================================== X11 opening display: :0.0 vo: X11 color mask: FFFFFF (R:FF0000 G:FF00 B:FF) vo: X11 running at 1024x768 with depth 24 and 32 bpp (":0.0" => local display) [x11] Detected wm supports NetWM. [x11] Detected wm supports FULLSCREEN state. [x11] Detected wm supports ABOVE state. [x11] Detected wm supports BELOW state. [x11] Detected wm supports STAYS_ON_TOP state. [x11] Current fstype setting honours FULLSCREEN STAYS_ON_TOP ABOVE BELOW X atoms Disabling DPMS DPMSDisable stat: 1 [xv common] Drawing no colorkey. [xv common] Maximum source image dimensions: 2046x2046 ========================================================================== Opening video decoder: [mpegpes] MPEG 1/2 Video passthrough VDec: vo config request - 352 x 288 (preferred colorspace: Mpeg PES) Trying filter chain: vo Could not find matching colorspace - retrying with -vf scale... Opening video filter: [scale] SwScale params: -1 x -1 (-1=no scaling) Trying filter chain: scale vo The selected video_out device is incompatible with this codec. Try adding the scale filter, e.g. -vf spp,scale instead of -vf spp. VDecoder init failed :( Opening video decoder: [libmpeg2] MPEG 1/2 Video decoder libmpeg2-v0.4.0b Selected video codec: [mpeg12] vfm: libmpeg2 (MPEG-1 or 2 (libmpeg2)) ========================================================================== Building audio filter chain for 48000Hz/2ch/s16le -> 0Hz/0ch/??... [libaf] Adding filter dummy [dummy] Was reinitialized: 48000Hz/2ch/s16le [dummy] Was reinitialized: 48000Hz/2ch/s16le ao2: 48000 Hz 2 chans s16le audio_setup: using '/dev/dsp' dsp device audio_setup: using '/dev/mixer' mixer device audio_setup: using 'pcm' mixer device audio_setup: sample format: s16le (requested: s16le) audio_setup: using 2 channels (requested: 2) audio_setup: using 48000 Hz samplerate (requested: 48000) audio_setup: frags: 4/4 (16384 bytes/frag) free: 65536 AO: [oss] 48000Hz 2ch s16le (2 bytes per sample) AO: Description: OSS/ioctl audio output AO: Author: A'rpi Building audio filter chain for 48000Hz/2ch/s16le -> 48000Hz/2ch/s16le... [dummy] Was reinitialized: 48000Hz/2ch/s16le [dummy] Was reinitialized: 48000Hz/2ch/s16le Starting playback... VDec: vo config request - 352 x 288 (preferred colorspace: Planar YV12) Trying filter chain: vo VDec: using Planar YV12 as output csp (no 0) Movie-Aspect is 1.33:1 - prescaling to correct movie aspect. VO Config (352x288->384x288,flags=0,'MPlayer',0x32315659) VO: [xv] 352x288 => 384x288 Planar YV12 VO: Description: X11/Xv VO: Author: Gerd Knorr <kraxel(a)goldbach.in-berlin.de> and others Xvideo image format: 0x32595559 (YUY2) packed Xvideo image format: 0x32315659 (YV12) planar Xvideo image format: 0x59565955 (UYVY) packed Xvideo image format: 0x30323449 (I420) planar Xvideo image format: 0x3 ( ) packed using Xvideo port 65 for hw scaling [xv] dx: 0 dy: 0 dw: 384 dh: 288 *** [vo] Allocating mp_image_t, 352x288x12bpp YUV planar, 152064 bytes [xv] dx: 0 dy: 0 dw: 384 dh: 288 *** [vo] Allocating mp_image_t, 352x288x12bpp YUV planar, 152064 bytes get_path('subfont.ttf') -> '/home/qwdu/.mplayer/subfont.ttf',?% 0 0 Unicode font: 22074 glyphs. *** [vo] Allocating mp_image_t, 352x288x12bpp YUV planar, 152064 bytes [xv] dx: 0 dy: 0 dw: 384 dh: 288 A:5589.1 V: 0.0 A-V:5589.073 ct: 0.000 1/ 1 you can found the first audio frame pos is displayed with 5589 by mistake.

2 1

demux_audio segfault
by Alan Curry 06 Apr '06

06 Apr '06

The story of the bug: Once upon a time, when I was looking for endianness bugs in swscale, I had a script that ran through various -vf format options with this loop header: for fmt in none rgb24 bgr24 rgb32 bgr32 yv12 yvu9 ("none" was a special case where -vf format was omitted.) This script was created in the directory where the test movies were located. After the endianness bugs were mostly taken care of, I forgot about that old test script, until one day I ran "mplayer *" in the video directory, and it segfaulted. Do you see the bug yet? It turns out the string "fmt " being anywhere near the beginning of the file is good enough for demux_audio to think it's a WAV. The next 4 bytes are expected to be an integer, which is immediately passed to malloc. In this case the next 4 bytes are "in n", corresponding to a malloc of 0x6e206e69 bytes - well over 1.5 gigabytes of memory. malloc failed, NULL was dereferenced, SEGV was received; all because I didn't call that loop variable "format" or "f". The bug: demux_audio.c:409: l = stream_read_dword_le(s); if(l < 16) { mp_msg(MSGT_DEMUX,MSGL_ERR,"[demux_audio] Bad wav header length: too short (%d)!!!\n",l); free_sh_audio(sh_audio); return 0; } sh_audio->wf = w = (WAVEFORMATEX*)malloc(l > sizeof(WAVEFORMATEX) ? l : size of(WAVEFORMATEX)); w->wFormatTag = sh_audio->format = stream_read_word_le(s); There should probably be an upper limit sanity check on the size of l. There should definitely be a don't-dereference-NULL check on the result of the malloc.

1 0

[PATCH] aviheader
by Björn Sandell 06 Apr '06

06 Apr '06

Neater and smaller risk for integer overflow

2 1

[PATCH] supress zero frames in index regeneration
by Yue Shi Lai 06 Apr '06

06 Apr '06

Hi, This patch supresses zero-length frames being mistaken for keyframes during regeneration of the AVI index ("-forceidx"). Yue Shi Lai -- ______________________________________________ Check out the latest SMS services @ http://www.linuxmail.org This allows you to send and receive SMS through your mailbox. Powered by Outblaze

4 3