April 2006 - MPlayer-dev-eng - lists.mplayerhq.hu

[PATCH] Fix mp_describe_titleset and related in stream_dvd.c
by kiriuja 14 Apr '06

14 Apr '06

This patch corrects a few problems introduced by the commit that added STREAM_CTRL_GET_TIME_LENGTH control in stream_dvd.c: 1. mp_describe_titleset opened by didn't close a vts if it didn't have a vtsi_mat or vts_pgcit. 2. if(tt_srpt->title[title_no].title_set_nr == vts_no) check moved to mp_get_titleset_length and so mp_describe_titleset produced heaps of wrong output. 3. STREAM_CTRL_GET_TIME_LENGTH control wrongly assumed that every title has its own vts. Need to use title_set_nr from tt_srpt->title instead. 4. mp_describe_titleset didn't return a value on success. Someone please apply. -- kiriuja

3 6

[PATCH] simplify TOOLS/checktree and add charset validation
by Reimar Döffinger 14 Apr '06

14 Apr '06

Hi, attached patch adds $subject. Comments? Greetings, Reimar Döffinger

2 2

playback seeking
by yiping chen 14 Apr '06

14 Apr '06

Hello, I need your help:) I want to have a more accurate playback seeking. In what file can I find the method for seeking, To attempt to a defined position? Thanks

3 2

[PATCH] Fix av sync calculations during lagging video
by Uoti Urpala 14 Apr '06

14 Apr '06

If video is lagging behind audio for performance reasons, the av sync code will incorrectly keep moving video timing forward to "compensate" for the lagging video (even though the video is not behind because of late timing but because it can't meet the current time target). As a result, if the performance problem goes away, the video will now jump ahead of audio until the timing gets gradually corrected back. The problem does not occur in autosync mode. The attached patch fixes this problem by taking the difference between the target and actual times for the current frame into account before adjusting timing for future frames. To test the patch, start mplayer and increase system load to make the video lag (nice mplayer if necessary to make it lag). After a while remove the load. Once the video catches up the av sync should be incorrect without the patch and correct with it.

5 11

Я тебя сегодня видела
by Michaelni 12 Apr '06

12 Apr '06

1 0

Re: [Mplayerplug-in-devel] incorrect handling of streaming video URL
by Reza Roboubi 11 Apr '06

11 Apr '06

Kevin DeKorte wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA1 > > Reza Roboubi wrote: > >>Thank you so much for the great plugin. >> >>The video at the top of this page is not handled properly. The video >>starts >>at the beginning of the entire news hour, rather than seeking to the >>specified story: >>http://www.pbs.org/newshour/bb/latin_america/jan-june01/colombiadrug_03-02.… >> >> >>It would be great to find out what's going on. >> >>Reza. > > > Reza, > > mplayer does not appear to support seeking within an mms stream. So > mplayerplug-in can't do any work arounds for this... > > ASX Contents > > > <ASX version = "3.0"> > <Entry> > <StartTime Value = "00:33:25.00" /> > <Duration Value = "00:09:58.28" /> > <Ref href = > "mms://wm.z1.mii-streaming.net/media/pbs/windows/general/windows/newshour/pb…" > /> > </Entry> > </ASX> > > > which would need an mplayer command line like this > > mplayer -ss 00:33:25 > "mms://wm.z1.mii-streaming.net/media/pbs/windows/general/windows/newshour/pb…" > > Which does not work, because mplayer reports that the stream is not > seekable. > > Sorry > > Kevin > [...] Thank you very much for your response Kevin. I'm cross posting this to the mplayer development mailing list, in order to ask the good people over there: - what are some of the technical issues involved in dealing with mms stream seeking? - and specifically, how may one attempt to modify the mplayer source code in order to add such support? I'm cross posting to the mplayer-users list, because I'm also curious about possible alternative ways to accomplish this (mms stream seeking.) I hope this cross posting isn't inappropriate. Otherwise, please let me know. Thank you so much. Reza.

1 0

[PATCH] GUI: segfault in gtk/menu.c
by Stanislav Maslovski 11 Apr '06

11 Apr '06

Hello, Noticed another segfault when playing a DVD disk in gmplayer. To reproduce play a short DVD clip (DVD->Play disc, DVD->Titles) and after it finishes try to invoke the menu by right-clicking on MPlayer's window => segfault. The segfault happens at line 492 of Gui/mplayer/gtk/menu.c. The reason of it is not updating the guiIntfStruct.demuxer pointer on the end of the play. This should be done by sending a notification event from within mplayer.c. (the gui events themselves are handled in Gui/interface.c). The patch is attached. -- Stanislav

3 5

coverity
by Attila Kinali 10 Apr '06

10 Apr '06

Moin, It has been brought to my attention, that coverity [1] scans our code for bugs. Does anyone know about this? Especialy how they create their numbers? [1] scan.coverity.com Attila Kinali -- 心をこめて聞け心をこめて話せ

2 1

Re: [PATCH] New mode for 'tinterlace' filter
by Walter Belhaven 09 Apr '06

09 Apr '06

Ivan Kalvachev writes: > 2006/4/2, Walter Belhaven : > > > > Here's a patch to libmpcodecs/vf_tinterlace.c which adds a new > > mode (-vf tinterlace=4). > > Committed. Thanks, but I was hoping to get some feedback/advice on the question I posed in my original E-mail and within the comments of the code. Namely, how should I set dmpi->fields of the image returned by vf_get_image() -- should I set MP_IMGFIELD_INTERLACED? -- how about MP_IMGFIELD_TOP_FIRST? etc. [NOTE: I should have placed those comment/lines inside the "if", right after dmpi=vf_get_image(...), not outside the "if". Uncommenting them where they are right now will causes a dereference-of-null segfault.] > Next time add to the patch and entry for the man page (i wrote one, i > hope you like it. if not, send patch ;) Can you point me to where I would find such a thing? Yours is fine, but I think the original documentation of tinterlace=0 is broken -- it should say double-height, and I'm not sure it's correct regarding field order. > About my_memcpy_pic(), i'm gonna make few benchmarks first and then > decide what to do. Sounds reasonable. Thanks for your help on this. WB __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

2 1

[PATCH] GUI: segfault in sb.c; window size & localization in eq.c;
by Stanislav Maslovski 09 Apr '06

09 Apr '06

Hello, The attached patch fixes the following issues in MPlayer's GTK+ GUI: * segfault in the skin browser when sbSelectedSkin gets dereferenced before setting, when no skin is selected in the skin list upon opening the browser, and "Cancel" or "OK" buttons get clicked. Noticed when runnig freshly compiled gmplayer on a system where the skins were still under the old location. * vertical size of "Configure Equalizer" window was not enough to hold all comboboxes. * the title of this window was not localized => added new en and ru strings. BR, Stanislav

3 5