March 2006 - MPlayer-dev-eng - lists.mplayerhq.hu

[PATCH] win32 gui
by Erik Lunchpail 25 Apr '06

25 Apr '06

Greetings, I was directed to post this here from the mplayer-cygwin list, so here goes. This is a heavily heavily modified version of Sascha Sommer's original win32 gui for win32. I began modifying it quite a while ago, with the help of Gianluigi Tiesi who has been kind enough to host binaries and fix my bugs. It's always been available on his site (http://oss.netfarm.it/mplayer-win32.php) which is also linked to from the mplayer homepage under related projects. It uses standard win32 api calls to emulate the current linux gui, so it works in both cygwin and mingw. The goal was to try and handle everything that we possibly could within the gui source, and to stay out of the external mplayer source tree as much as possible. It takes advantage of the gui code that is currently in place within the source tree, so only very minor patching is necessary. Only 3 files require patching, configure, Gui/Makefile, and mplayer.c. The former 2 are self explanitory, but i'll briefly explain the mplayer.c changes. Basically it works the opposite in windows as it does in linux (go figure huh?). The gui is enabled by default, however it is disabled when called via slave, so this still allows it to be used by any frontends around that call mplayer's slave functions. Secondly, i've added a COPYDATA struct which allows for IPC which is handled within gui.c. Lastly, since the sub window is fairly new, and is handled differently than the linux gui, a small 3-liner to allow the sub window to correctly adjust to new aspects when using runtime aspect switching. Some screenshots can be viewed here: http://vayne.fdns.net/mplayer/shot1.png http://vayne.fdns.net/mplayer/shot2.png http://vayne.fdns.net/mplayer/shot3.png Some features: IPC with WM_COPYDATA (as stated above) Fully skinnable with any supported mplayer skin. Playlist loading/saving/shuffling. Full drag&drop support (including playlists) DVD/vcd/cd support (the latter with libcdio) Aspect switching support, whether with -aspect on the cmdline or via runtime aspect switching. DVD title/chapter switching dialog. Preferences dialog. Skin browser. Support for loading external subtitle files. Systray support. Console toggle for stdout/stderr debug info. The sub window takes advantage of WinID when using vo directx, but will hide when using other vo's. And as well, the sub window should automatically hide when a file is audio only and only pop back up when we have video. Also included is an optional (to be applied last) patch for DVD menu's for use with Atvos Attila's dvd menu patches. Questions? comments? Regards, Erik __________________________________________________ Do You Yahoo!? Tired of spam? Yahoo! Mail has the best spam protection around http://mail.yahoo.com

8 27

[PATCH] printf -> mp_msg
by Ötvös Attila 24 Apr '06

24 Apr '06

Hi All! Files: find_sub.c, sub_cc.c, subreader.c liba52: parse.c, ao_oss.c, ao_sun.c, audio_out.c libdha: pci.c, sysdep/libdha_win32.c, sysdep/pci_win32.c libmenu: menu.c, menu_cmdlist.c, menu_console.c, menu_filesel.c, menu_param.c, menu_pt.c, menu_txt.c, vf_menu.c libmpcodecs: ad_libdv.c, mp_image.h, pullup.c, vd_dmo.c, vd_dshow.c, vd_ffmpeg.c, vd_realvid.c, vd_vfw.c, ve_lavc.c, ve_raw.c, ve_vfw.c, vf.c, vf_crop.c, vf_cropdetect.c, vf_expand.c, vf_fame.c, vf_format.c, vf_framestep.c, vf_noformat.c, vf_palette.c, vf_phase.c, vf_test.c, vf_tile.c, vf_yuy2.c, vf_yuy9.c libmpdemux: cache2.c, cddb.c, demux_asf.c, demux_audio.c, demux_demuxers.c, demux_film.c, demux_gif.c, demux_mov.c, demux_nuv.c, demux_real.c, demux_viv.c, demux_xmms.c, stream.c, tvi_v4l2.c, video.c libvo:aspect.c, mga_common.c, vesa_lvo.c, video_out.c, vo_3dfx.c, vo_dxr3.c, vo_mga.c, vo_null.c, vo_png.c, vo_sdl.c, vosub_vidix.c, vo_svga.c, vo_syncfb.c, vo_tdfxfb.c, vo_tdfx_vid.c, vo_tga.c, vo_vesa.c, vo_x11.c, vo_xv.c Best regards! Attila

8 23

[PATCH] if(verbose>X) --> mp_msg_test
by Diego Biurrun 23 Apr '06

23 Apr '06

Hi, I was staring at progress bars a lot at work yesterday, so I did some janitorial work that should help the pending mp_msg patch from attila. I've converted all the 'if (verbose > X)' calls to mp_msg_test, which is the proper way and gets us rid of a few global vars as an added bonus. I intend to apply this tomorrow, shout now if I messed up somewhere. Diego

4 22

[PATCH] Returned without freeing storage "cddb_info"
by Guillaume POIRIER 23 Apr '06

23 Apr '06

Hi, The attached patch addresses the following resource leak detected by Covertity's checker: CID: 154 Checker: RESOURCE_LEAK (help) File: main/libmpdemux/cdda.c Function: open_cdda Description: Returned without freeing storage "cddb_info" Do you think it's okay? Guillaume -- Reinventing the wheel certainly is annoying, but as long as all other wheels are square... Reimar Döffinger

2 3

[RFC] RTC check in configure
by Diego Biurrun 22 Apr '06

22 Apr '06

.. I couldn't sleep .. The RTC check we currently have in configure is suboptimal since we only check if RTC-related code can be compiled. On PPC this works because there is a RTC emulation, but it's not enough for MPlayer to use. The attached program performs the ioctl calls instead. Any better ideas or suggestions (the hardcoded /dev/rtc comes to mind)? Oh, does it work on x86? ;) Diego

6 9

ogg/mjpeg with corrupted first frame
by Sergey Khlutchin 20 Apr '06

20 Apr '06

Hi! There is one file which is normally played in old mplayer1.0try7 but failed to open in the current cvs version. http://www6.elphel.com/downloads/elphel333mjpeg/20060320-170056-20060320-17… Sergey

3 3

[PATCH] disable filters that depend on dsputil.h
by Nico Sabbi 19 Apr '06

19 Apr '06

Hi, last months we added dsputil.h to the install target of libavcodec; it was a mistake because that file is not supposed to be used outside of libavcodec. This patch disables the inclusion of filters that depend on that header when libavcodec is not imported in main/; if applied I'll post a patch to ffmpeg-devel to restore the previous behaviour (not install dsputil.h). Please, review. Nico

5 19

[PATCH] MPlayer properties
by Alban Bedel 16 Apr '06

16 Apr '06

Hi all, second try with this patch. Hopefully it'll get a bit more review and testing this time :) I already explained what this patch is about but for those too lazy to search the archives here is the whole story again. This patch try to implement a simple API to set and more importantly query the state of various things in MPlayer (like the current volume, name of the demuxer used, whatever). With the commands it is only possible to set things, so to query it is a no go for the internal ui (OSD menu and GUI). In the end the GUI use ugly hacks, the OSD menu have no preference menu, and the frontends are stuck with a couple get_* commands. This imho called for a new API: m_property Basically m_property is just a simple extension of m_option. Instead of using pointers to variables like in m_config, it use pointers to ioctl like functions. The function is then used to set/get the property. Currently the following operations exists: get, set, step up / down, print (to show a more approriate form for human) and parse (to eventually read back that human form). Many of the current commands must then be moved to properties to avoid useless code duplication. For this i implemented a command to property bridge. It can handle most commands automatically by setting the corresponding property and then querying it to display its state on the OSD (via msg and/or bar). In the end this patch have some side effect which are imho desirable things: * Move code from the big switch handeling commands to smaller functions. Not only easier to understand but also finnaly easily re-usable. * "Standardize" all commands going through the bridge. * Put an end to the get_* commands proliferation, everything can be handeled via the get_property command. As an extra (and a way to test the querying properties and the string expansion function i plan to use for the OSD menus) i added a command line option (-playing-msg) that will print a string at the start of the main loop. Before printing the string is expanded allowing to print the state of any property. The following expansion are supported: * \e \n \r \t \xNN : expand to escape, new line, etc * ${NAME} : expand to the value of the property NAME * ?(NAME:TEXT) : print TEXT only if property NAME is available A useful application is to get the currently played file in the title bar of your terminal. For example in an xterm: "\e]0;MPlayer - ${filename}?(length: - ${length})\x07" would set the title to something like: "MPlayer - mymovie.avi - 1:20:02" if the length is available and "MPlayer - mymovie.avi" if not. Please test. In particular subtitle switching and EDL as i can't really test those (not much subs around and i have never used EDL). I know this patch is big, probably too big already, but pls take a bit of time and consider that if this patch had 3 properties it wouldn't be very useful. I tried to resist the temptation of converting too many commands, but if this patch is to be accepted i plan to add more things like tv, etc. Albeu

3 3

Re: [MPlayer-dev-eng] http stream basic auth base64_encode() fix
by Jeff D'Angelo 15 Apr '06

15 Apr '06

On Mon, 6 Mar 2006, Reimar Döffinger wrote: > Hi, > It's late so excuse any thinking-errors... > > > } else { > > - // Terminate with Mime style '=' > > - *out = '='; > > - outLen++; > > - > > - return outLen; > > + // Pad with 0 to 2 '=' chars as needed > > + if (outLen & 3) > > + memset(out, '=', 4 - (outLen & 3) ); > > + return (outLen + 3) & ~3; > > Actually, IMHO memset is actually not a good idea in this case, I > prefer your old patch in this regard. > The real reason I posted my patch is because you do not check the maxlen > value here and might be writing beyond the buffer. Ahh I see it now. I was relying on the while( outLen<outMax ) loop to keep things in check as that would run after the last encode set. Rounding outLen down to be divisible by 4 should cover that. > So I think the best solution would be your original patch + my > maxlen &= ~3; > line. Ok, how's this attached patch look? I added a couple speed ups to my original. -- Jeff > Greetings, > Reimar Döffinger > > _______________________________________________ > MPlayer-dev-eng mailing list > MPlayer-dev-eng(a)mplayerhq.hu > http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng >

2 5

[PATCH] correct mp3lib -v output on PPC
by Alexander Strange 15 Apr '06

15 Apr '06

This simply makes mp3lib say that it's using Altivec to decode instead of generic C when it uses the optimized IMDCT. I notice the Altivec code in decod386.c checks gCpuCaps every time it calls dct64; you could save a very small amount of time by using a function pointer there like the rest of the SIMD code.

2 4