July 2004 - MPlayer-dev-eng - lists.mplayerhq.hu

Synchronization of players in LAN
by J.A. Gutierrez 18 Jun '08

18 Jun '08

Hello I'm trying to synchronise several players running on several computers connected to a dedicated 10/100 Ethernet switch. Each one reads a different movie (video only) from its internal hard disk, and resolution will be 768x576. I'm thinking of a simple solution: - Add some code at mplayer startup so it will wait for an UDP broadcast packet (sent by a central master in the LAN). This way all the players would start at the same time. - Use NTP to keep in sync all the computers' clocks, and trust mplayer's rtc synchronisation feature. With this simple setup, could we be sure all the players would keep the synchronisation? Or should the master computer track them all and take control on their speeds? How difficult would be to add code so all the player synchronise using the LAN? Or should I use some external clock connected to all serial ports? Or use a totally different approach? Thanks. -- finger spd(a)shiva.cps.unizar.es for PGP / .mailcap tip of the day: / La vida es una carcel application/ms-tnef; cat '%s' > /dev/null / con las puertas abiertas text/x-vcard; cat '%s' > /dev/null / (A. Calamaro)

14 40

[PATCH] supress zero frames in index regeneration
by Yue Shi Lai 06 Apr '06

06 Apr '06

Hi, This patch supresses zero-length frames being mistaken for keyframes during regeneration of the AVI index ("-forceidx"). Yue Shi Lai -- ______________________________________________ Check out the latest SMS services @ http://www.linuxmail.org This allows you to send and receive SMS through your mailbox. Powered by Outblaze

4 3

[PATCH] -wid: get initial window geometry
by kiriuja 21 May '05

21 May '05

When -wid option is used, most VOs that support it start playing video at its original (unscaled) size in the top left corner of the window, and only scale it to the full window upon receipt of a ConfigureNotify event, if and when the window is resized. Also some VOs forget to map the window back after unmapping it and setting attributes, again when -wid is in use. Attached patch solved the problem here. It would remove the need for (some of) ugly hackery in MPlayer frontends. -- kiriuja

5 9

[PATCH] don't skip first mp3 frame
by Nehal 08 Jan '05

08 Jan '05

for some reason, the current code skips the first frame of mp3 files (using any decoder), i'm assuming this is a bug as i can't see any good reason for this. this probably isn't noticeable with most files, but i have a couple of test cases that have audible sound data in the first frame. if someone wants, email me and i'll send you the starting part of the files for testing purposes. please apply the patch that i've attached Nehal

8 35

[PATCH] ve_lavc delayed frames
by Loren Merritt 01 Dec '04

01 Dec '04

When encoding to lavc with b-frames, mencoder emits some dummy frames at the beginning of the output video (because lavc hasn't returned any compressed frames yet). This causes A-V desync, and (the case that I first noticed) messes with timestamps in a variable-framerate video. This patch supresses the dummy frames. I also noticed that mencoder drops the last few frames (for the same reason). I don't know a good fix for this: avcodec.h says to feed in some NULL data at the end. So I tried simply calling put_image(vf, NULL), which does flush the delayed frames, but doesn't stop them from being encoded as B-frames based on the NULLs. --Loren Merritt

5 10

Stuck mouse buttons
by Marius Gedminas 23 Nov '04

23 Nov '04

Hi, (resending this to mplayer-dev-eng as requested) Occasionally (but often enough to get annoying) when I click a mouse button on an mplayer window the button gets stuck -- hitting any key afterwards produces messages like No bind found for key MOUSE_BTN1-SPACE although MOUSE_BTN1 is *not* held down. It is easy for me to reproduce the problem by hitting a mouse button for a very brief period of time. It is even easier with tp-scroll[1], which is a gpm-like program that lets me emulate the mouse wheel on a ThinkPad with its 3-button trackpoint. Tp-scroll emits the middle button release event immediately after the press event and always triggers the problem. [1] http://rsim.cs.uiuc.edu/~sachs/tp-scroll/ More than one mouse button can get stuck. I managed all three of them. I've traced the problem to mplayer_put_key in fifo.c. After uncommenting the line that warns about dropped key events (FIFO full) I started seeing these messages every time a button got stuck. While ignoring keypresses on a full FIFO buffer is a sensible thing to do with normal keys, it does not work well with mouse button release events... I should mention that HAVE_NO_POSIX_SELECT is not defined here and thus the first version of mplayer_put_key is used (the one which uses select on a pipe). This is a Debian system (mixed stable/testing/unstable) with glibc 2.3.2 (libc6 2.3.2.ds1-11), and kernel 2.4.24. I do not use the mplayer GUI. What seems strange to me is that the FIFO becomes full with just one key event in it. Apparently trying to use a Unix pipe as a generic FIFO buffer does not work as expected. When I defined HAVE_NO_POSIX_SELECT in config.h and recompiled mplayer the problem went away. I suspect that select on a pipe will not say the fd is ready for writing if the buffer is not completely empty. Normally you can write up to PIPE_BUF bytes without blocking, but if the buffer already contains something, then writing PIPE_BUF bytes would block. IOW using select for a generic FIFO buffer does not work well. I think a better solution would be to use nonblocking writes. Something like the attached patch (tested here, but not tested for portability -- and the #ifdef with HAVE_NO_POSIX_SELECT should be changed to something different as well). Or maybe it would be simplest to always use the in-memory array solution (mplayer_put_key + mplayer_get_key). I expect it to be marginally faster as well (no syscalls, no context switches). Marius Gedminas -- QOTD: "A child of 5 could understand this! Fetch me a child of 5."

20 39

[PATCH][RFC] Font layer fixes/improvements
by Krzysztof Rusocki 09 Nov '04

09 Nov '04

Hi, While using MPlayer 1.0pre3 we've encountered few issues related to font handling, attached patch (against CVS as of 2004-02-13) (implicitly or explicitly) tries to deal with them. Before you go on and your blood pressure reaches extraordinarily high values... keep in mind that: - although I've tried not to break mplayer's design it is quite possible that I missed something (these are my first steps with mplayer sources), - this patch does not tend to be a complete solution (docs modification is not done, console messages are probably excessive), I'd rather would like to hear from you whether the steps I've taken are the good way to fix things, THE DETAILS If mplayer is compiled with HAVE_FREETYPE and HAVE_FONTCONFIG following things happen: 1. When launched: $ (g)mplayer -font nonexistant mplayer segfaults when it's about to show osd see libvo/sub.c:~610 - vo_font->font[40] is -1 thus we end with negative array offset (the patch does not fix this since I didn't figure out how to cope with this cleanly) 2. In Gui font is reloaded on every widget activity (size bars and scale radio buttons), it seems to be quite significant and needless (?) overhead. 3. With -fontconfig, it is impossible to load font via file dialog in Gui (or by -font parameter), this seems pretty confusing - one would expect a .ttf/.pfb to be loaded from file dialog. 4. Despite being configured with Freetype, mplayer tries (needlessly) to load .desc font on startup and if such font gets loaded - then: 4.1. If -font is specified - loaded .desc font is overridden by freetype font_load_ft codepath anyway 4.2. If -font is NOT specified - default freetype font (subfont.ttf) isn't touched at all, while (I believe) it should be tried. 5. When launched: $ mplayer -zoom -fs (with autoscale enabled) font is scaled to original (unzoomed) movie dimensions. The patch is fairly large, but, I think that changes will ease future development... Here's what has been done (in general), I've created a fairly unified interface for font loading (libvo/font_if.{c,h}), so there's no need to put so many #ifdefs around or wonder ,,what if we have freetype enabled? or not?'' int init_font(); int uninit_font(); void render_one_glyph(font_desc_t *desc, int c); int kerning(font_desc_t *desc, int prevc, int c); These work similarily to the previous ones, i.e. they do things when freetype is enabled, otherwise they are no-ops. void free_font_desc(font_desc_t *desc); free_font_desc() has been moved from load_font_ft.c, since it's rather common function for fonts. #define load_font(n, w, h) _load_font(n, w, h, __FILE__, __LINE__) void _load_font(char * name, int width, int height, char * fn, int ln); That's the most tricky thing, load_font tries to load font with specified name, the font is loaded in either of three cases: - no font has been loaded at all - screen dimensions's changed - force_load_font variable was set to non-zero value The way font is loaded depends on HAVE_FREETYPE. If defined - the order of things is as follows (font_if.c/try_load_font_ft()): - load font "name" via freetype, if it fails, - load font "name" via freetype+fontconfig (if supported), if it fails, - load default font (subfont.ttf) via freetype, if it fails, - load default fontconfig font ("sans-serif") (if supported), If font still isn't loaded, there is a codepath that loads only OSD face, however that causes a segfault mentioned earlier (1), hence it is disabled. Now, let's move to the case when there's no freetype (try_load_font_desc()). That is a simple - load font "name" - load default font fallback. Mentioned changes allow easier font (re)loading and unloading, see changes in Gui/interface.c, mplayer.c, mencoder.c. I have removed -fontconfig/-nofontconfig options since they seem superfluous in face of font load code proposed in the patch, I didn't find any reason why they should be kept. If you need more info, feel free to mail, also, any feedback is welcome (including napalm). Cheers, Krzysztof

7 15

Re: [PATCH][BUG] GUI shows black when X depth is16/15
by Andreas Leitgeb 08 Nov '04

08 Nov '04

I use the latest version (from CVS main branch) updated almost daily. I recently wanted to try the gui, and it showed up all black, so I googled for "mplayer gui black" and found this thread on this mailing list (which I'm not subscribed to) from Jul 12th 2003. (Indeed, my Xserver is set to 16bpp.) With this, I looked into Gui/wm/ws.c's history and found the change in 1.69->1.70 Anyway, my gui is still black (at least it was this weekend), so perhaps the patch didn't solve it completely. Is anyone of the developers working on a 16bpp-display? PS: debian woody, gcc-2.95.4, gtk-2.0, XFree86 (4.3 when I last tried, meanwhile upgraded to 4.4)

2 1

[PATCH] Impose output FPS on mplayer
by Frédéric Dupuis 07 Nov '04

07 Nov '04

Hello I made a patch that optionally lets the user impose an output fps on mplayer. With this, mplayer tries to "fit" the input video to a given fps much like mencoder does. This allows one to use inverse telecine filters or divtc in real time and have the correct output framerate, thus avoiding the ugly flickering one gets with the current version. The usage is very much like the one for mencoder, ie: mplayer -ofps 23.976 -vf divtc incorrect_ivtc.avi -- Frédéric Dupuis <frederic.dupont.dupuis(a)utoronto.ca>

6 7

[PATCH] fix for -srate bug
by Giacomo Comes 03 Nov '04

03 Nov '04

Some time ago I reported a bug with the -srate option. I have been digging around a little bit and I found the solution. This patch solve the problem. --- libaf/af.c.ori 2004-07-15 17:42:07.000000000 -0400 +++ libaf/af.c 2004-07-15 17:42:28.000000000 -0400 @@ -382,12 +382,6 @@ if(!af || (AF_OK != af->control(af,AF_CONTROL_RESAMPLE_RATE, &(s->output.rate)))) return -1; - // Use lin int if the user wants fast - if ((AF_INIT_TYPE_MASK & s->cfg.force) == AF_INIT_FAST) { - char args[32]; - sprintf(args, "%d:0:0", s->output.rate); - af->control(af, AF_CONTROL_COMMAND_LINE, args); - } if(AF_OK != af_reinit(s,af)) return -1; } This code went in 2004-01-27 and it's what cause the problem with -srate. Can somebody explain if it can be safely removed or it has to stay but it needs some modification? Giacomo

10 86