July 2002 - MPlayer-dev-eng - lists.mplayerhq.hu

[PATCH] qtrle decoder can read beyond end of input buffer
by Michael Lampe 01 Jul '02

01 Jul '02

Hi! --- qtrle.c-old Mon Jul 1 17:17:41 2002 +++ qtrle.c Mon Jul 1 17:17:41 2002 @@ -61,7 +61,8 @@ { pixel_ptr = row_ptr + ((encoded[stream_ptr++] - 1) * bytes_per_pixel); - while ((rle_code = (signed char)encoded[stream_ptr++]) != -1) + while (stream_ptr < encoded_size && + (rle_code = (signed char)encoded[stream_ptr++]) != -1) { if (rle_code == 0) // there's another skip code in the stream See http://cox.iwr.uni-heidelberg.de/~ug/films/stefan.mov for a file demonstrating the bug. -Michael

1 0

encoding to huffyuv
by Marian Jancar 01 Jul '02

01 Jul '02

I want to do higher quality capturing on slow machine eg capture to a losless format and then compress. Huffyuv seems to be good choice for the capturing so if noone adds support for it to mencoder or plans to do so I would do it. The usage of huffyuv is not fundamental though, if someone has smart ideas about highspeed losless compression I would like to implement them. Marian

5 9

Fw:mplayer-dev-eng,congratulations
by angelhsu 01 Jul '02

01 Jul '02

1 0

Architect: follow mode
by Sam Liddicott 01 Jul '02

01 Jul '02

I'm slowly modifying mplayer for a follow mode as part of my introduction to it's internals, and I think it advisable to consult here from time to time so I don't make any major errors. I want a mode where if mplayer is playing a file and the file grows while playing mplayer doesn't stop early. I figure the first stage is for mplayer to know when it has such a stream that is follow-able. I reckon around line 467 of libmpdemux/open.c we see STREAMTYPE_FILE - I guess these are the only grow-able seek-able streams anyway. Now a few things refer to stream->end_pos from time to time, but most things cache it like: demuxer->movi_end=stream->end_pos; So I guess periodically on of the demuxer functions is going to want to call a new stream function to get a new end_pos, using: len-lseek(f,0,SEEK_END); lseek(f,0,SEEK_SET); If I'm not too far out then I'll start to look for a suitable demuxer function into which I can put the check-if-stream-has-grown code. I would think in the read-blocks but only if so long has passed since last time, or so much K has been read or we are near what we think is the end; ftell() should be cheap enough? What say you guys? Later I would like for it to also record in the stream struct whether or not the file is observed to be growing; for if the file has been observed to grow recently (or maybe if file mod_time is less than 20 seconds?) at the point we seem to reach the real end of file we might wait a bit to see if it does grow a bit more and also if we are doing a user-seek we can choose not to quit beause the file is quite likely to grow. Even later-later I want to implement stretchable-circular buffers for tivo like buffering, but much later.

4 8

SVCD subtitles ?
by Stefan Fendt 01 Jul '02

01 Jul '02

Hi! at first a big thank you for that nice player! (You don't seem to get nice notes on it very often, do you? I just wonder because of the homepage *gg*) Well, I'd like to know if there are plans to support SVCD-subtitles? Probably it's in CVS? I only ask because it would be a nice feature to see'em before burning a CD... Stefan -- +-[ ciphered mail preferred ]----------------------------------------+ | current key : 0x717A662A (OpenPGP) | | Fingerprint : 87BD 7BFB DA16 49CA 9596 5327 865C B6D2 717A 662A | +--------------------------------------------------------------------+

4 6