July 2001 - MPlayer-dev-eng - lists.mplayerhq.hu

ffmpeg/libavcodec
by Arpi 02 Aug '01

02 Aug '01

Hi, Nick: can I remove libavcodec from mplayer CVS? does it still have something interesting code, or all things are poretd to ffmpeg CVS? What about ffmpeg support? I think it could be added for ffmpeg cvs version, like: #ifdef USE_FASTMEMCPY #include "../libvo/fastmemcpy.h" #endif or so. USE_FASTMEMCPY is already defined in mplayer's config.h did you check divx4linux? it's much faster, but i can't imagine how. i think that DLL codecs are optimized enough, but it's 2 times faster in some cases! also, ffmpeg codec is usually faster than DLL, so maybe DLLs aren't so good as they said. btw divx4 is still buggy, while ffmpeg plays everything. and it's opensource, and portable, while divx4 is linux/windows only :( A'rpi / Astral & ESP-team -- mailto:arpi@thot.banki.hu http://esp-team.scene.hu _______________________________________________ Mplayer-dev-eng mailing list Mplayer-dev-eng(a)lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/mplayer-dev-eng

2 4

Largefiles patch
by Stephen Davies 01 Aug '01

01 Aug '01

Hi, Here's my largefiles patch again; against today's CVS. I removed the %qd's, mostly. Where I thought they should stay, I ifdeffed for _LARGEFILE_SOURCE. And replaced %qd with %lld - I see that "q" is deprecated in the printf man page. Your comments and I'll make a final tweak if necessary. Steve

2 3

Re: Dynamic Output Quality Patch, Take 2
by Timothy B. Terriberry 31 Jul '01

31 Jul '01

Of course, immediately after I sent that, I noticed that decode_video() was called in two places, and so that patch will not initialize vdecode_time correctly. A new mplayer.c diff (still from the original 7/31 snapshot) is attached. 228c228,229 < int divx_quality=0; --- > int divx_quality=-1; > int output_quality; 387a389,390 > extern int get_video_quality_max(sh_video_t *sh_video); > extern void set_video_quality(sh_video_t *sh_video,int quality); 878a882,887 > /*Set the initial video quality on codecs that support it.*/ > output_quality=get_video_quality_max(sh_video); > if(divx_quality<0||divx_quality>output_quality)divx_quality=output_quality; > else output_quality=divx_quality; > set_video_quality(sh_video,output_quality); > 997c1006 < //float frame_correction=0; // average of A-V timestamp differences --- > float frame_correction=0; // average of A-V timestamp differences 1007a1017,1019 > double cvideo_base_vtime; > double cvideo_base_vframe; > double vdecode_time; 1189a1202,1203 > cvideo_base_vframe=sh_video->timer; > cvideo_base_vtime=video_time_usage; 1246a1261 > vdecode_time=video_time_usage; 1247a1263 > vdecode_time-=video_time_usage; 1289c1305 < --- > 1367a1384 > frame_correction=0; 1404c1421 < float x=(a_pts-delay-audio_delay)-v_pts; --- > float x=frame_correction=(a_pts-delay-audio_delay)-v_pts; 1438a1456,1474 > > /*Output quality adjustments:*/ > /*If we took a long time decoding this frame, downgrade the quality.*/ > if(output_quality>0&& > (video_time_usage-cvideo_base_vtime)*sh_video->timer>= > (0.95*sh_video->timer-(vout_time_usage+audio_time_usage))* > (sh_video->timer-cvideo_base_vframe-frame_correction)){ > output_quality>>=1; > /*printf("Downgrading quality to %i.\n",output_quality);*/ > set_video_quality(sh_video,output_quality);} > /*If we had plenty of extra time, upgrade the quality.*/ > if(output_quality<divx_quality&& > vdecode_time<0.5*frame_time&& > (video_time_usage-cvideo_base_vtime)*sh_video->timer< > (0.67*sh_video->timer-(vout_time_usage+audio_time_usage))* > (sh_video->timer-cvideo_base_vframe-frame_correction)){ > output_quality++; > /*printf("Upgrading quality to %i.\n",output_quality);*/ > set_video_quality(sh_video,output_quality);}

2 1

Re: Re: Re: [Mplayer-users] bugs?
by Christoph Lampert 31 Jul '01

31 Jul '01

Hi Arpi! On Tue, 31 Jul 2001, Arpi wrote: > Hi, > > > Doesn't sound too bad. However, I still have a problem with the file: It > > plays for 3 or 4 minutes (after -idx skipping there is possible), then stops > > with message "file doesn't contain the selected audio or video stream" > > > > I know the file is broken, but: Is this repairable? > yes, everything is repairable. even a broken HDD driver with ntfs partition > containing very important data -> but should be done manually -> lots' of > money :) > > if you send me teh file & money, i'll hack it with hex editor and get it > work :) > > ok. stop joking:) > i don't know any program or method for automatically fix broken avi files. > avi is the worst file format i've ever seen. it has zero error tolerance. Yes, I know... And I pity you for having to always answer the same questions :-) I really didn't want you to write an omnipotent AviFix program (although... maybe... no, mplayer is more important ;-) I was just wondering (same with the other files, that said "no video stream"), since this does not seem to be a broken downloads (because several file show same behaviour) but wrongly written header, that you maybe had an idea how to "cure" this. E.g. the file I wrote about seems to look for another video stream, although it already started to play one. I find that strange, but on the other hand, I know nothing about AVI (and am happy to admit that). Well, I'll just keep loading, one day, non-broken files will show up :-) gruel P.S. I checked it, this was the longest mail I ever got from A'rpi :-) > for example, asf and mpeg-ts files are from constant-length blocks, so > if a block is broken, you can skip it and read next (you know where is it). > for mpeg, there are sync codes (0x0 0x0 0x1), so it's easy to resync. > same for mpeg audio, but sync code is something like f3ffxxxx, i duno now, > but you can check in mp3lib/sr1.c resync method. > > for avi, you have nothing. > it has variable sized chunks, each chunks contains its length. > if a chunk is broken, you don't know where is the next and you don't know > is it broken or not...) > > i can imagine a brute-force method (but should be impemenetd in a standalone > util prog, not in mplayer): > if teh parser thinks that chunk is broken (too large chunksize, or invalid > chunk id), it can recursive call itself (parser), and try to find next > chunk probing each byte position after the buggy chunk. if it's ok, try to > check next chunk if still ok, then we can skip broken chunk. > it isn't 100% perfect, and can fail for good chunks and pass broken chunks, > but may help in most cases (or not, didn't try). > > i personally hate the avi file format, and really hope thay people will > change to something more usefull (mpeg/asf/quicktime). > > and i forget to saym but you already noticed: A-V sync in avi files is > terrible.. there is only one standard way (in avi file format specification) > but nobody uses it (i have only oen file using this, it's about 5 years old, > using CRAM codec...). it specifies that audio-video chunk pairs should be > defined in a LIST item. > > currently there are 3 formats, none of them is standard. > 1. interleaved streams: same as standard, but they left out LIST chunks, > only list A and V and A and V etc after eachother. > 2. bps method: audio and video streams are totally independent (usually > -ni streams), but audio timestamp can be calculated by dividing audio > byte position by a 'average bytes per second' value specified in audio > stream format header. it can't handle VBR audio. > 3. combination of 1. and 2. i just got such file, it's Lola Rennt german > dvdrip version (thanx Atmos :)). > it plays with mplayer using method 1., but you can't seek (lost A-V > sync if seeking). i'ev found that avifile handle this file, because it > uses combination of 1. and 2. methods (at least fersh avifile 9.6 cvs). > i'll implement this and try, mayeb help for some special streams. > btw there are some streams (about 5% of all) which works with mpalyer's > method 1., but fails with avifile's mixed method 3. > windows media player uses something between 1. and 3., couldn't find > yet how it works. old avifile and mplayer -bps uses method 2. > > i really don't know, what are standards made for? > but i'm sure, m$ doesn't know too. > > sorry for being offtopic, this should go to mplayer-dev-eng. > > > "Epsilon < 0" - chl > is it standard? =) > > > A'rpi / Astral & ESP-team > > -- > mailto:arpi@thot.banki.hu > http://esp-team.scene.hu > > _______________________________________________ > Mplayer-users mailing list > Mplayer-users(a)lists.sourceforge.net > http://lists.sourceforge.net/lists/listinfo/mplayer-users > -- Dipl. math. Christoph Lampert (complex analysis, integral formulae) Gibraltargatan 86 | CTH, Matematiskt centrum rum 637 | Eklandagatan 86, rum 2235 41279 Gothenburg | 41296 Gothenburg SWEDEN | SWEDEN Email: gruel(a)gmx.de | Email: lampert(a)math.chalmers.se | Tel. +46 31 772 5323 (office) _______________________________________________ Mplayer-dev-eng mailing list Mplayer-dev-eng(a)lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/mplayer-dev-eng

1 0

Dynamic Output Quality Patch, Take 2
by Timothy B. Terriberry 31 Jul '01

31 Jul '01

Okay, I recently upgraded to the 7/31 CVS snapshot (the 0.18pre5 deb package was broken), and noticed my previous patch had not been included. I checked the mailing list history to see why, and saw your comments on diff format and timing changes. I am not currently subscribed to this list, so please cc replies to this attempt to my e-mail address (mailto:tterribe@vt.edu) if you want me to see them. The patch introduces two new functions into dec_video.c: get_video_quality_max(): returns the maximum allowed video quality for the current codec (0 is the minimum) set_video_quality(): sets the video quality The new variable output_quality contains the current video quality. The variable divx_quality represents the maximum allowed quality. If the user specifies a negative amount, or too large an amount, the maximum allowed quality for the current codec is used. The default was changed to -1 (to always use the maximum allowed). The scale from the OpenDivX postprocessing filters was changed from 0-63 to 0-6. Yes, I know, you can't select exactly which filters are used, but it probably makes more sense from a user's perspective. Easy enough to undo if you don't agree. A few other variables were introduced to keep track of how much CPU time is being spent on decoding each frame, and adjusting the quality accordingly (cvideo_base_vtime, cvideo_base_vframe, vdecode_time, frame_correction). --- dec_video.c Sun Jul 29 22:00:54 2001 +++ dec_video.c~ Tue Jul 31 02:54:23 2001 @@ -84,6 +84,40 @@ } #endif +int get_video_quality_max(sh_video_t *sh_video){ + switch(sh_video->codec->driver){ +#ifdef ARCH_X86 +#ifdef USE_DIRECTSHOW + case VFM_DSHOW:return 4; +#endif +#endif +#ifdef MPEG12_POSTPROC + case VFM_MPEG : +#endif + case VFM_DIVX4: + case VFM_ODIVX:return 6; + default :return 0;} } + +void set_video_quality(sh_video_t *sh_video,int quality){ + switch(sh_video->codec->driver){ +#ifdef ARCH_X86 +#ifdef USE_DIRECTSHOW + case VFM_DSHOW:{ + if(quality<0||quality>4)quality=4; + DS_SetValue_DivX("Quality",quality);}break; +#endif +#endif +#ifdef MPEG12_POSTPROC + case VFM_MPEG :{ + if(quality<0||quality>6)quality=6; + picture->pp_options=(1<<quality)-1;}break; +#endif + case VFM_DIVX4: + case VFM_ODIVX:{ + DEC_SET dec_set; + if(quality<0||quality>6)quality=6; + dec_set.postproc_level=(1<<quality)-1; + decore(0x123,DEC_OPT_SETPP,&dec_set,NULL);}break;} } int init_video(sh_video_t *sh_video){ unsigned int out_fmt=sh_video->codec->outfmt[sh_video->outfmtidx]; @@ -148,7 +182,7 @@ DS_VideoDecoder_Start(); - DS_SetAttr_DivX("Quality",divx_quality); +// DS_SetAttr_DivX("Quality",divx_quality); // printf("DivX setting result = %d\n", DS_SetAttr_DivX("Quality",divx_quality) ); // printf("DivX setting result = %d\n", DS_SetValue_DivX("Brightness",60) ); @@ -176,8 +210,8 @@ dec_param.x_dim = sh_video->bih->biWidth; dec_param.y_dim = sh_video->bih->biHeight; decore(0x123, DEC_OPT_INIT, &dec_param, NULL); - dec_set.postproc_level = divx_quality; - decore(0x123, DEC_OPT_SETPP, &dec_set, NULL); +// dec_set.postproc_level = divx_quality; +// decore(0x123, DEC_OPT_SETPP, &dec_set, NULL); } if(verbose) printf("INFO: OpenDivX video codec init OK!\n"); break; @@ -208,8 +242,8 @@ dec_param.x_dim = sh_video->bih->biWidth; dec_param.y_dim = sh_video->bih->biHeight; decore(0x123, DEC_OPT_INIT, &dec_param, NULL); - dec_set.postproc_level = divx_quality; - decore(0x123, DEC_OPT_SETPP, &dec_set, NULL); +// dec_set.postproc_level = divx_quality; +// decore(0x123, DEC_OPT_SETPP, &dec_set, NULL); sh_video->our_out_buffer = shmem_alloc(((bits*dec_param.x_dim+7)/8)*dec_param.y_dim); // sh_video->our_out_buffer = shmem_alloc(dec_param.x_dim*dec_param.y_dim*5); } @@ -247,10 +281,8 @@ case VFM_MPEG: { // init libmpeg2: -#ifdef MPEG12_POSTPROC - picture->pp_options=divx_quality; -#else - if(divx_quality){ +#ifndef MPEG12_POSTPROC + if(divx_quality>0){ printf("WARNING! You requested image postprocessing for an MPEG 1/2 video,\n"); printf(" but compiled MPlayer without MPEG 1/2 postprocessing support!\n"); printf(" #define MPEG12_POSTPROC in config.h, and recompile libmpeg2!\n"); --- mplayer.c Sun Jul 29 22:00:54 2001 +++ mplayer.c~ Tue Jul 31 02:54:14 2001 @@ -225,7 +225,8 @@ // options: int osd_level=2; -int divx_quality=0; +int divx_quality=-1; +int output_quality; char *seek_to_sec=NULL; int seek_to_byte=0; int has_audio=1; @@ -385,6 +386,8 @@ extern void skip_audio_frame(sh_audio_t *sh_audio); // dec_video.c: +extern int get_video_quality_max(sh_video_t *sh_video); +extern void set_video_quality(sh_video_t *sh_video,int quality); extern int init_video(sh_video_t *sh_video); #ifdef USE_LIBVO2 extern int decode_video(vo2_handle_t *video_out,sh_video_t *sh_video,unsigned char *start,int in_size,int drop_frame); @@ -876,6 +879,12 @@ GUI_MSG( mplUnknowError ) exit(1); } +/*Set the initial video quality on codecs that support it.*/ +output_quality=get_video_quality_max(sh_video); +if(divx_quality<0||divx_quality>output_quality)divx_quality=output_quality; +else output_quality=divx_quality; +set_video_quality(sh_video,output_quality); + // ================== Init output files for encoding =============== if(encode_name){ @@ -994,7 +1003,7 @@ //================== MAIN: ========================== { -//float frame_correction=0; // average of A-V timestamp differences +float frame_correction=0; // average of A-V timestamp differences //int frame_corr_num=0; // //float v_frame=0; // Video float time_frame=0; // Timer @@ -1005,6 +1014,9 @@ char osd_text_buffer[64]; int drop_frame=0; int drop_frame_cnt=0; +double cvideo_base_vtime; +double cvideo_base_vframe; +double vdecode_time; #ifdef HAVE_LIRC #ifdef HAVE_GUI @@ -1187,6 +1199,8 @@ #endif /*========================== PLAY VIDEO ============================*/ +cvideo_base_vframe=sh_video->timer; +cvideo_base_vtime=video_time_usage; if(1) while(1){ @@ -1244,7 +1258,9 @@ fclose(f); } + vdecode_time=video_time_usage; blit_frame=decode_video(video_out,sh_video,videobuffer,videobuf_len,drop_frame); + vdecode_time-=video_time_usage; // get mpeg fps: newfps=frameratecode2framerate[picture->frame_rate_code]*0.0001f; @@ -1286,7 +1302,7 @@ } sh_video->timer+=frame_time; time_frame+=frame_time; // for nosound - + if(file_format==DEMUXER_TYPE_MPEG_PS) d_video->pts+=frame_time; if(verbose>1) printf("*** ftime=%5.3f ***\n",frame_time); @@ -1365,6 +1381,7 @@ #if 1 /*================ A-V TIMESTAMP CORRECTION: =========================*/ + frame_correction=0; if(sh_audio){ float a_pts=0; float v_pts=0; @@ -1401,7 +1418,7 @@ if(verbose>1)printf("### A:%8.3f (%8.3f) V:%8.3f A-V:%7.4f \n",a_pts,a_pts-audio_delay-delay,v_pts,(a_pts-delay-audio_delay)-v_pts); if(delay_corrected){ - float x=(a_pts-delay-audio_delay)-v_pts; + float x=frame_correction=(a_pts-delay-audio_delay)-v_pts; // printf("A:%6.1f V:%6.1f A-V:%7.3f",a_pts-audio_delay-delay,v_pts,x); printf("A:%6.1f (%6.1f) V:%6.1f A-V:%7.3f",a_pts,a_pts-audio_delay-delay,v_pts,x); x*=0.1f; @@ -1436,6 +1453,25 @@ } #endif + + /*Output quality adjustments:*/ + /*If we took a long time decoding this frame, downgrade the quality.*/ + if(output_quality>0&& + (video_time_usage-cvideo_base_vtime)*sh_video->timer>= + (0.95*sh_video->timer-(vout_time_usage+audio_time_usage))* + (sh_video->timer-cvideo_base_vframe-frame_correction)){ + output_quality>>=1; + /*printf("Downgrading quality to %i.\n",output_quality);*/ + set_video_quality(sh_video,output_quality);} + /*If we had plenty of extra time, upgrade the quality.*/ + if(output_quality<divx_quality&& + vdecode_time<0.5*frame_time&& + (video_time_usage-cvideo_base_vtime)*sh_video->timer< + (0.67*sh_video->timer-(vout_time_usage+audio_time_usage))* + (sh_video->timer-cvideo_base_vframe-frame_correction)){ + output_quality++; + /*printf("Upgrading quality to %i.\n",output_quality);*/ + set_video_quality(sh_video,output_quality);} #ifdef USE_OSD if(osd_visible){

1 0

Patch for non-root DVD Auth
by Gregoire Sutre 30 Jul '01

30 Jul '01

Hi, Attached is a small patch for non-root DVD authentication. Instead of using the FIBMAP ioctl (which requires root priviledges?), the VOB file's LBA is obtained using a DVD UDF library (I took the one in OMS). Greg.

1 0

patch for widescreen videos
by Vaclav Slavik 30 Jul '01

30 Jul '01

Hello, attached small patch enabled MPlayer to play widescreen videos (aspect ratio of 16:9). This is pretty useful when you want to play widescreen DVDs with MPlayer ;) The patch adds -widescreen cmd line option and changes mplayer.c so that it passes altered desired screen height to the video driver. Some drivers follow d_height hint, some don't. Windowed modes work just fine with -widescreen, some fullscreen ones do, some don't (I had to modify Xv driver, which I use). Hope you'll find this useful... Regards, Vaclav Slavik

3 2

ffmpeg
by Arpi 30 Jul '01

30 Jul '01

Hi, Just checked ffmpeg's libavcodec again, after Nick commited sync changes. Results are still bad :( VIDEO: [DIV3] 640x352 24bpp 23.98 fps 951.2 kbps (116.1 kbyte/s) Dshow: BENCHMARKs: V: 14.368s VO: 0.005s A: 0.000s Sys: 0.494s = 14.867s BENCHMARK%: V: 96.6455% VO: 0.0310% A: 0.0000% Sys: 3.3234% = 100.0000% libavcodec (mplayer cvs): BENCHMARKs: V: 12.834s VO: 0.007s A: 0.000s Sys: 0.507s = 13.347s BENCHMARK%: V: 96.1524% VO: 0.0524% A: 0.0000% Sys: 3.7952% = 100.0000% libavcodec (ffmpeg cvs): BENCHMARKs: V: 14.596s VO: 0.007s A: 0.000s Sys: 0.528s = 15.131s BENCHMARK%: V: 96.4649% VO: 0.0483% A: 0.0000% Sys: 3.4868% = 100.0000% isn't all optimizations synced yet, or it's a highlevel slowness problem of libavcodec (maybe the non-n*16 height movie fix?)? A'rpi / Astral & ESP-team -- mailto:arpi@thot.banki.hu http://esp-team.scene.hu _______________________________________________ Mplayer-dev-eng mailing list Mplayer-dev-eng(a)lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/mplayer-dev-eng

1 1

gcc-3.0.1: update for configure + problems with mmx & ffdivx
by pl 29 Jul '01

29 Jul '01

Hi! gcc-3.0.1 isn't officially released but current snapshots return 3.0.1 as version number, which lead to a misleading error ("found 3.0.1 please upgrade/downgrade...") [patch below]. Btw, it compiles with 3.0.x _but_ I think there is a gcc-3.0.x bug (?) with the ffdivx driver when mmx support is enabled => the image is completely garbled... I've narrowed the problem to the compilation of libavcodec/mpegvideo.c (and especially libavcodec/i386/mpegvideo.c): by changing the level of optimization from -O4 to -O0 it works... So if anyone litterate in asm can check that, I can provide -S outputs... else maybe it should be added to the BUGS files. Best regards. --- configure 20 Jul 2001 00:01:08 -0000 1.112 +++ configure 23 Jul 2001 11:57:27 -0000 @@ -341,7 +341,7 @@ cc_version=`$_cc -v 2>&1 | sed -n 's/^.*version $[aegcygnustp-]*[0-9.]*$.*$/\1/p'` case $cc_version in '') cc_version="v. ?.??, bad"; cc_verc_fail=yes;; + 2.95.[2-9]|2.95.[2-9].[0-9]|3.[0-9]|3.[0-9].[0-9]) - 2.95.[2-9]|2.95.[2-9].[0-9]|3.[0-9]) cc_version="$cc_version, ok";; *) cc_version="$cc_version, bad"; cc_verc_fail=yes;; esac _______________________________________________ Mplayer-dev-eng mailing list Mplayer-dev-eng(a)lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/mplayer-dev-eng

4 10

Fwd: mplayer configure fails to detect sdl
by Arpi 29 Jul '01

29 Jul '01

--------- Forwarded message --------- From: Nilmoni Deb <ndeb(a)ece.cmu.edu> To: Arpi <arpi(a)thot.banki.hu> Subject: mplayer configure fails to detect sdl Hi, Lines 346-349 of configure are not letting detection of sdl-config. I added two echo statements before and after so they look like: echo $_sdlconfig if [ "$system_name" = "FreeBSD" ]; then _sdlconfig='sdl11-config' else _sdlconfig='sdl-config' echo $_sdlconfig Then I ran ./configure and the two echo statements give: /opt/sdl/bin/sdl-config sdl-config It will fail in any system (FreeBSD or not) bcos the absolute path is missing. Please fix this. thanks - Nil _______________________________________________ Mplayer-dev-eng mailing list Mplayer-dev-eng(a)lists.sourceforge.net http://lists.sourceforge.net/lists/listinfo/mplayer-dev-eng

2 1