r18858 - trunk/libmpdemux/librtsp/rtsp.c
Author: ben Date: Thu Jun 29 23:53:35 2006 New Revision: 18858 Modified: trunk/libmpdemux/librtsp/rtsp.c Log: cosmetic patch to remove useless sizeof(char) statements Modified: trunk/libmpdemux/librtsp/rtsp.c ============================================================================== --- trunk/libmpdemux/librtsp/rtsp.c (original) +++ trunk/libmpdemux/librtsp/rtsp.c Thu Jun 29 23:53:35 2006 @@ -201,7 +201,7 @@ mp_msg(MSGT_OPEN, MSGL_FATAL, "librtsp: buffer overflow in rtsp_get\n"); exit(1); } - string=malloc(sizeof(char)*n); + string=malloc(n); memcpy(string,buffer,n-1); string[n-1]=0; @@ -221,7 +221,7 @@ static void rtsp_put(rtsp_t *s, const char *string) { int len=strlen(string); - char *buf=malloc(sizeof(char)*len+2); + char *buf=malloc(len+2); #ifdef LOG mp_msg(MSGT_OPEN, MSGL_INFO, "librtsp: >> '%s'", string); @@ -405,7 +405,7 @@ buf=strdup(what); } else { - buf=malloc(sizeof(char)*(strlen(s->host)+16)); + buf=malloc(strlen(s->host)+16); sprintf(buf,"rtsp://%s:%i", s->host, s->port); } rtsp_send_request(s,RTSP_METHOD_OPTIONS,buf); @@ -422,7 +422,7 @@ buf=strdup(what); } else { - buf=malloc(sizeof(char)*(strlen(s->host)+strlen(s->path)+16)); + buf=malloc(strlen(s->host)+strlen(s->path)+16); sprintf(buf,"rtsp://%s:%i/%s", s->host, s->port, s->path); } rtsp_send_request(s,RTSP_METHOD_DESCRIBE,buf); @@ -461,7 +461,7 @@ buf=strdup(what); } else { - buf=malloc(sizeof(char)*(strlen(s->host)+strlen(s->path)+16)); + buf=malloc(strlen(s->host)+strlen(s->path)+16); sprintf(buf,"rtsp://%s:%i/%s", s->host, s->port, s->path); } rtsp_send_request(s,RTSP_METHOD_SET_PARAMETER,buf); @@ -479,7 +479,7 @@ buf=strdup(what); } else { - buf=malloc(sizeof(char)*(strlen(s->host)+strlen(s->path)+16)); + buf=malloc(strlen(s->host)+strlen(s->path)+16); sprintf(buf,"rtsp://%s:%i/%s", s->host, s->port, s->path); } rtsp_send_request(s,RTSP_METHOD_PLAY,buf); @@ -548,7 +548,7 @@ } /* let's make the server happy */ rtsp_put(s, "RTSP/1.0 451 Parameter Not Understood"); - rest=malloc(sizeof(char)*17); + rest=malloc(17); sprintf(rest,"CSeq: %u", seq); rtsp_put(s, rest); rtsp_put(s, "");
On Thu, Jun 29, 2006 at 11:53:35PM +0200, ben wrote:
Author: ben Date: Thu Jun 29 23:53:35 2006 New Revision: 18858
Modified: trunk/libmpdemux/librtsp/rtsp.c
Log: cosmetic patch to remove useless sizeof(char) statements
gcc really should issue a warning for sizeof(char) and other nonsense constant statements. rich
participants (2)
-
ben -
Rich Felker